All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: christian.koenig-5C7GfCeVMHo@public.gmane.org
Cc: "Sibren Vasse"
	<freedesktop-DLwv2wemLo05ZU0pBKPMFg@public.gmane.org>,
	"Konrad Rzeszutek Wilk"
	<konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	"Michel Dänzer" <michel-otUistvHUpPR7s880joybQ@public.gmane.org>,
	x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	"Robin Murphy" <robin.murphy-5wv7dgnIgG8@public.gmane.org>,
	"Christoph Hellwig" <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: amdgpu/TTM oopses since merging swiotlb_dma_ops into the dma_direct code
Date: Thu, 10 Jan 2019 15:48:37 +0100	[thread overview]
Message-ID: <20190110144837.GA10362@lst.de> (raw)
In-Reply-To: <a3f0fd49-2286-ee2a-f0e8-dfe82aac73fb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Thu, Jan 10, 2019 at 03:00:31PM +0100, Christian König wrote:
>>  From the trace it looks like we git the case where swiotlb tries
>> to copy back data from a bounce buffer, but hits a dangling or NULL
>> pointer.  So a couple questions for the submitter:
>>
>>   - does the system have more than 4GB memory and thus use swiotlb?
>>     (check /proc/meminfo, and if something SWIOTLB appears in dmesg)
>>   - does the device this happens on have a DMA mask smaller than
>>     the available memory, that is should swiotlb be used here to start
>>     with?
>
> Rather unlikely. The device is an AMD GPU, so we can address memory up to 
> 1TB.

So we probably somehow got a false positive.

For now I'like the reported to confirm that the dma_direct_unmap_page+0x92
backtrace really is in the swiotlb code (I can't think of anything else,
but I'd rather be sure).

Second it would be great to print what the contents of io_tlb_start
and io_tlb_end are, e.g. by doing a printk_once in is_swiotlb_buffer,
maybe that gives a clue why we are hitting the swiotlb code here.

  parent reply	other threads:[~2019-01-10 14:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10  9:59 amdgpu/TTM oopses since merging swiotlb_dma_ops into the dma_direct code Michel Dänzer
2019-01-10 13:57 ` Christoph Hellwig
2019-01-10 14:00   ` Christian König
     [not found]     ` <a3f0fd49-2286-ee2a-f0e8-dfe82aac73fb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2019-01-10 14:48       ` Christoph Hellwig [this message]
     [not found]         ` <20190110144837.GA10362-jcswGhMUV9g@public.gmane.org>
2019-01-10 17:52           ` Sibren Vasse
2019-01-14 18:10             ` Christoph Hellwig
     [not found]               ` <20190114181041.GB8897-jcswGhMUV9g@public.gmane.org>
2019-01-14 19:00                 ` Sibren Vasse
2019-01-14 17:22           ` Michel Dänzer
     [not found]   ` <20190110135741.GA9255-jcswGhMUV9g@public.gmane.org>
2019-01-10 15:26     ` Sibren Vasse
     [not found]       ` <CAF=iVctGGs1OzHBg6MgpxrFbT_19T4YvH8muBZtsLJBDwGhrvQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-01-10 17:05         ` Konrad Rzeszutek Wilk
     [not found]           ` <20190110170557.GD27546-he5eyhs8q0BAdwtm4QZOy9BPR1lH4CV8@public.gmane.org>
2019-01-10 17:34             ` Sibren Vasse
2019-01-14 18:13       ` Christoph Hellwig
     [not found]         ` <20190114181314.GC8897-jcswGhMUV9g@public.gmane.org>
2019-01-14 19:32           ` Sibren Vasse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190110144837.GA10362@lst.de \
    --to=hch-jcswghmuv9g@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=christian.koenig-5C7GfCeVMHo@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=freedesktop-DLwv2wemLo05ZU0pBKPMFg@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=konrad.wilk-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=michel-otUistvHUpPR7s880joybQ@public.gmane.org \
    --cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
    --cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.