All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Christian Brauner <christian@brauner.io>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation/filesystems: add binderfs
Date: Thu, 10 Jan 2019 16:47:03 -0700	[thread overview]
Message-ID: <20190110164703.1dd6cee1@lwn.net> (raw)
In-Reply-To: <20190110231309.12653-1-christian@brauner.io>

On Fri, 11 Jan 2019 00:13:09 +0100
Christian Brauner <christian@brauner.io> wrote:

> This documents the Android binderfs filesystem used to dynamically add and
> remove binder devices that are private to each instance.
> 
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

Seems like a worthwhile addition overall.  I know nothing about binderfs,
so can't speak to the accuracy, of course.  I do have a couple of
metacomments, though:

 - Please consider doing this in RST and tying it into our documentation
   tree.  It's *almost* RST now, so the effort required will be almost
   zero.

 - It should probably have an SPDX line at the top.

 - Is it worth putting the example program in the samples/ directory?  Is
   it something that would ever make any sense to run in its current form?

Thanks,

jon

  reply	other threads:[~2019-01-10 23:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-10 23:13 [PATCH] Documentation/filesystems: add binderfs Christian Brauner
2019-01-10 23:47 ` Jonathan Corbet [this message]
2019-01-10 23:56   ` Christian Brauner
2019-01-11  0:08     ` Jonathan Corbet
2019-01-11 10:22       ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190110164703.1dd6cee1@lwn.net \
    --to=corbet@lwn.net \
    --cc=christian@brauner.io \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.