From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC3CC43387 for ; Thu, 10 Jan 2019 19:12:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FC4020874 for ; Thu, 10 Jan 2019 19:12:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kroah.com header.i=@kroah.com header.b="C5yapWsr"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="kRPkcEkP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729109AbfAJTMS (ORCPT ); Thu, 10 Jan 2019 14:12:18 -0500 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]:57085 "EHLO wnew4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728572AbfAJTMR (ORCPT ); Thu, 10 Jan 2019 14:12:17 -0500 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 8AB9D163D; Thu, 10 Jan 2019 14:12:16 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Thu, 10 Jan 2019 14:12:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=6jR9zJrQGvHbOwJHmQILTNSRqF6 I0bMvt/2XdlNiMCU=; b=C5yapWsrnD7hyY+F1b/xzrSnwIUxhfHlwLLCAAbg8qR O6YZqDQ+IJ0g6grf5NyOA7VZBV88TsBfRNbQDOY+T9urmUngmFCT6HSKZSbjXg52 n3JU/0rXKX/6M57GPho5LMsIp0+8stksqx2cmkEv+yM6lo3O9hKTUv/EkfRSBkBM e4dvP9oarElDRAOOw3mej83eVSllVMEcnQop2WoUw8wZyQjIohOe7IkQs/uMvbDq /qstgUP8lbAoAMuHB68jMDg0PEIj/53t0BegOly+MqtNTHtjQYMe9MgjkzKTETTl y/MWYnUlI1poAR7C+mxm7vbOwdzPHTMenHuzox9mteA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=6jR9zJ rQGvHbOwJHmQILTNSRqF6I0bMvt/2XdlNiMCU=; b=kRPkcEkPDlh4GwUxRDtDkK UXq3FykanS4PfJDumgbuqEyGHbo0fhN42+T0cQN+TwNyTrA0TUYpMSCb5GibW9QF 7lpVXcEJFJ6vopU3z+FdLtIqqUtrb+K4VQYu9NFf6FUrF7IBVn/6fR1uwd/lId9S eE9IKE/VH0S53j2MUYFeWLreF8OMcVCcwgRrt4HqTajcofNLNXtZVZ5y1iu5y7Pz BxEM5MtUzQp902vMyZlsmOhtJFFSTYUKFS1QimeB60aSkgPHAKBmMmbN+DA0c+0S MeSuHY5+DQK/TyEdET09b3qGrpr16E+TQpi84DCctut+O6AqoP7RoH0weg/PRQBg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrfeefgdduvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenogfuphgrmhfkphculdeftd dtmdenucfjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefi rhgvghcumffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucfkphepkeefrdekiedrke elrddutdejnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtgho mhenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from localhost (5356596b.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) by mail.messagingengine.com (Postfix) with ESMTPA id F0A91E425A; Thu, 10 Jan 2019 14:12:14 -0500 (EST) Date: Thu, 10 Jan 2019 20:12:13 +0100 From: Greg KH To: Daniel Verkamp Cc: stable@vger.kernel.org, Stefan Hajnoczi Subject: Re: [v4.9, v4.14] vhost/vsock: fix uninitialized vhost_vsock->guest_cid Message-ID: <20190110191213.GC18221@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jan 07, 2019 at 02:49:02PM -0800, Daniel Verkamp wrote: > Please apply mainline commit a72b69dc083a931422cc8a5e33841aff7d5312f2 > ("vhost/vsock: fix uninitialized vhost_vsock->guest_cid") to the v4.9 > and v4.14 stable branches. > > I believe this is the root cause of an issue uncovered by applying > "vhost/vsock: fix use-after-free in network stack callers" in these > branches. I sometimes see a crash in hash_del_rcu() with vsock in the > call stack, and that call is protected by a newly-added check of > vsock->guest_cid, which was uninitialized before this commit. Now queued up, thanks. greg k-h