All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Milan Broz <gmazyland@gmail.com>
Cc: dm-devel@redhat.com, mpatocka@redhat.com
Subject: Re: dm-crypt: Fix parsing of extended IV arguments.
Date: Thu, 10 Jan 2019 15:27:35 -0500	[thread overview]
Message-ID: <20190110202735.GB1169@redhat.com> (raw)
In-Reply-To: <43e7c378-b87e-03d9-ceb7-348ba84c71e1@gmail.com>

On Thu, Jan 10 2019 at  2:50pm -0500,
Milan Broz <gmazyland@gmail.com> wrote:

> On 10/01/2019 20:18, Mike Snitzer wrote:
> > On Wed, Jan 09 2019 at  5:57am -0500,
> > Milan Broz <gmazyland@gmail.com> wrote:
> 
> >> This patch fixes the dm-crypt constructor to ignore additional dash in IV options and also removes
> >> bogus warning (that is ignored anyway).
> >>
> >> [This patch should go into stable tree as well.]
> > 
> > Rather than this it'd be useful to just be more explicit, e.g.:
> 
> There is no single reference commit.
> 
> The new capi: was introduced in
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/md/dm-crypt.c?id=33d2f09fcb357fd1861c4959d1d3505492bf91f8
> 
> but I think the second part applies even to older kernel, but not sure it makes sense to fix it there (I guess not)...
> 
> So perhaps the best is to apply it to stable kernel >= 4.12

OK, now staged, I tweaked your header though because (like your email
reply) it was lacking proper wrapping.

See: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.0&id=1856b9f7bcc8e9bdcccc360aabb56fbd4dd6c565

Thanks,
Mike

      reply	other threads:[~2019-01-10 20:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09 10:57 [PATCH] dm-crypt: Fix parsing of extended IV arguments Milan Broz
2019-01-10 19:18 ` Mike Snitzer
2019-01-10 19:50   ` Milan Broz
2019-01-10 20:27     ` Mike Snitzer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190110202735.GB1169@redhat.com \
    --to=snitzer@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=gmazyland@gmail.com \
    --cc=mpatocka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.