diff for duplicates of <20190110202744.GA149637@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 4458c75..1ca9943 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,7 +2,7 @@ On Wed, Nov 28, 2018 at 03:19:41PM -0800, Eric Biggers wrote: > On Fri, Nov 02, 2018 at 06:58:54PM -0700, Eric Biggers wrote: > > From: Eric Biggers <ebiggers@google.com> > > -> > syzbot hit the 'BUG_ON(index_key->desc_len = 0);' in __key_link_begin() +> > syzbot hit the 'BUG_ON(index_key->desc_len == 0);' in __key_link_begin() > > called from construct_alloc_key() during sys_request_key(), because the > > length of the key description was never calculated. > > @@ -49,8 +49,8 @@ On Wed, Nov 28, 2018 at 03:19:41PM -0800, Eric Biggers wrote: > > --- a/security/keys/keyring.c > > +++ b/security/keys/keyring.c > > @@ -661,9 +661,6 @@ static bool search_nested_keyrings(struct key *keyring, -> > BUG_ON((ctx->flags & STATE_CHECKS) = 0 || -> > (ctx->flags & STATE_CHECKS) = STATE_CHECKS); +> > BUG_ON((ctx->flags & STATE_CHECKS) == 0 || +> > (ctx->flags & STATE_CHECKS) == STATE_CHECKS); > > > > - if (ctx->index_key.description) > > - ctx->index_key.desc_len = strlen(ctx->index_key.description); diff --git a/a/content_digest b/N1/content_digest index c8aabf6..7211854 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020181128231940.GB131170@gmail.com\0" "From\0Eric Biggers <ebiggers@kernel.org>\0" "Subject\0Re: [PATCH v2] KEYS: always initialize keyring_index_key::desc_len\0" - "Date\0Thu, 10 Jan 2019 20:27:46 +0000\0" + "Date\0Thu, 10 Jan 2019 12:27:46 -0800\0" "To\0keyrings@vger.kernel.org" " David Howells <dhowells@redhat.com>\0" "Cc\0linux-security-module@vger.kernel.org" @@ -15,7 +15,7 @@ "> On Fri, Nov 02, 2018 at 06:58:54PM -0700, Eric Biggers wrote:\n" "> > From: Eric Biggers <ebiggers@google.com>\n" "> > \n" - "> > syzbot hit the 'BUG_ON(index_key->desc_len = 0);' in __key_link_begin()\n" + "> > syzbot hit the 'BUG_ON(index_key->desc_len == 0);' in __key_link_begin()\n" "> > called from construct_alloc_key() during sys_request_key(), because the\n" "> > length of the key description was never calculated.\n" "> > \n" @@ -62,8 +62,8 @@ "> > --- a/security/keys/keyring.c\n" "> > +++ b/security/keys/keyring.c\n" "> > @@ -661,9 +661,6 @@ static bool search_nested_keyrings(struct key *keyring,\n" - "> > \tBUG_ON((ctx->flags & STATE_CHECKS) = 0 ||\n" - "> > \t (ctx->flags & STATE_CHECKS) = STATE_CHECKS);\n" + "> > \tBUG_ON((ctx->flags & STATE_CHECKS) == 0 ||\n" + "> > \t (ctx->flags & STATE_CHECKS) == STATE_CHECKS);\n" "> > \n" "> > -\tif (ctx->index_key.description)\n" "> > -\t\tctx->index_key.desc_len = strlen(ctx->index_key.description);\n" @@ -134,4 +134,4 @@ "\n" Ping. -06f3e764e53a1987f17930fe80f72d06f81e80725d9dbdb21a9515b7fbd16362 +f1c8c7c71c3da537a997a801ea08579f93e50cad91dd993e2fbcb366f04f671b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.