From: Halil Pasic <pasic@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Tony Krowiak <akrowiak@linux.ibm.com>,
imammedo@redhat.com, qemu-devel@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full()
Date: Fri, 11 Jan 2019 11:31:21 +0100 [thread overview]
Message-ID: <20190111113121.05199eac@oc2783563651> (raw)
In-Reply-To: <20190110175722.4ee8d4d6.cohuck@redhat.com>
On Thu, 10 Jan 2019 17:57:22 +0100
Cornelia Huck <cohuck@redhat.com> wrote:
> > I thought the same. They could also be made unsigned long or
> > unsigned long long to increase the number of child devices that can be
> > plugged in before having to deal with exceeding the index value.
>
> Making them unsigned long long would push the problem out far enough to
> be irrelevant in practice. Not sure if we care about fixing it
> completely, though.
My intuition says that INT_MAX hotplug's on a bus is already an
'academic' thing. The rationale behind asking about unsigned is that
I would consider something like 'child[-42]' weird.
My intuition was that this is something that the community considers
not important enough to invest in. If we don't want to leave it as is, I
would prefer some proper fix (explicit limit on the number of hotplug
operations, or scanning for the first free one).
Regards,
Halil
next prev parent reply other threads:[~2019-01-11 10:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 15:57 [Qemu-devel] [PATCH v3] qdev/core: fix qbus_is_full() Tony Krowiak
2018-12-18 14:18 ` Igor Mammedov
2019-01-08 16:08 ` Tony Krowiak
2019-01-08 16:31 ` Cornelia Huck
2019-01-08 16:50 ` Halil Pasic
2019-01-08 17:06 ` Cornelia Huck
2019-01-08 20:34 ` Tony Krowiak
2019-01-09 10:14 ` Cornelia Huck
2019-01-09 15:36 ` Tony Krowiak
2019-01-09 17:35 ` Halil Pasic
2019-01-10 15:50 ` Tony Krowiak
2019-01-10 16:57 ` Cornelia Huck
2019-01-11 10:31 ` Halil Pasic [this message]
2019-01-11 10:21 ` Halil Pasic
2019-01-28 20:35 ` Tony Krowiak
2019-02-06 8:34 ` Igor Mammedov
2019-02-18 17:02 ` Tony Krowiak
2019-02-28 17:17 ` Eduardo Habkost
2019-03-04 17:35 ` Tony Krowiak
2019-03-05 8:01 ` Pierre Morel
2019-03-05 8:28 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111113121.05199eac@oc2783563651 \
--to=pasic@linux.ibm.com \
--cc=akrowiak@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=imammedo@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.