From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 1/5] dt-bindings: display: bridge: fork out ti,ds90c185 from lvds-transmitter Date: Fri, 11 Jan 2019 08:49:04 -0600 Message-ID: <20190111144904.GA5052@bogus> References: <20181229070649.21308-1-peda@axentia.se> <20181229070649.21308-2-peda@axentia.se> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20181229070649.21308-2-peda@axentia.se> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Peter Rosin Cc: Mark Rutland , "devicetree@vger.kernel.org" , David Airlie , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Laurent Pinchart List-Id: devicetree@vger.kernel.org T24gU2F0LCBEZWMgMjksIDIwMTggYXQgMDc6MDc6MTlBTSArMDAwMCwgUGV0ZXIgUm9zaW4gd3Jv dGU6Cj4gRFM5MEMxODUgaGFzIGEgc2h1dGRvd24gcGluIHdoaWNoIGRvZXMgbm90IGZpdCBpbiB0 aGUgbHZkcy10cmFuc21pdHRlcgo+IGJpbmRpbmcsIHdoaWNoIGlzIG1lYW50IHRvIGJlIGdlbmVy aWMuCj4gCj4gVGhlIHNpc3RlciBjaGlwIERTOTBDMTg3IGlzIHNpbWlsYXIgdG8gRFM5MEMxODUs IGRlc2NyaWJlIGl0IGhlcmUgYXMgd2VsbC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBQZXRlciBSb3Np biA8cGVkYUBheGVudGlhLnNlPgo+IC0tLQo+ICAuLi4vYmluZGluZ3MvZGlzcGxheS9icmlkZ2Uv bHZkcy10cmFuc21pdHRlci50eHQgICB8ICA4ICstLS0KPiAgLi4uL2JpbmRpbmdzL2Rpc3BsYXkv YnJpZGdlL3RpLGRzOTBjMTg1LnR4dCAgICAgICAgfCA1NSArKysrKysrKysrKysrKysrKysrKysr Cj4gIDIgZmlsZXMgY2hhbmdlZCwgNTYgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAg Y3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNw bGF5L2JyaWRnZS90aSxkczkwYzE4NS50eHQKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlv bi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2x2ZHMtdHJhbnNtaXR0ZXIudHh0 IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2x2ZHMt dHJhbnNtaXR0ZXIudHh0Cj4gaW5kZXggNTAyMjAxOTBjMjAzLi5mZDM5YWQzNGMzODMgMTAwNjQ0 Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdl L2x2ZHMtdHJhbnNtaXR0ZXIudHh0Cj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2x2ZHMtdHJhbnNtaXR0ZXIudHh0Cj4gQEAgLTIyLDEzICsy Miw3IEBAIGFtb25nIG90aGVycy4KPiAgCj4gIFJlcXVpcmVkIHByb3BlcnRpZXM6Cj4gIAo+IC0t IGNvbXBhdGlibGU6IE11c3QgYmUgb25lIG9yIG1vcmUgb2YgdGhlIGZvbGxvd2luZwo+IC0gIC0g InRpLGRzOTBjMTg1IiBmb3IgdGhlIFRJIERTOTBDMTg1IEZQRC1MaW5rIFNlcmlhbGl6ZXIKPiAt ICAtICJsdmRzLWVuY29kZXIiIGZvciBhIGdlbmVyaWMgTFZEUyBlbmNvZGVyIGRldmljZQo+IC0K PiAtICBXaGVuIGNvbXBhdGlibGUgd2l0aCB0aGUgZ2VuZXJpYyB2ZXJzaW9uLCBub2RlcyBtdXN0 IGxpc3QgdGhlCj4gLSAgZGV2aWNlLXNwZWNpZmljIHZlcnNpb24gY29ycmVzcG9uZGluZyB0byB0 aGUgZGV2aWNlIGZpcnN0Cj4gLSAgZm9sbG93ZWQgYnkgdGhlIGdlbmVyaWMgdmVyc2lvbi4KCkkg dGhpbmsgeW91IHNob3VsZCBrZWVwIHNvbWV0aGluZyBoZXJlLiBJJ2QgcmV3b3JkIGl0IHRvIHNh eSBhbnkgZW5jb2RlciAKd2l0aCBhZGRpdGlvbmFsIHByb3BlcnRpZXMgbXVzdCBoYXZlIGEgZGV2 aWNlIHNwZWNpZmljIGNvbXBhdGlibGUgaW4gCmFkZGl0aW9uLgoKPiArLSBjb21wYXRpYmxlOiBN dXN0IGJlICJsdmRzLWVuY29kZXIiCj4gIAo+ICBSZXF1aXJlZCBub2RlczoKPiAgCj4gZGlmZiAt LWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS90 aSxkczkwYzE4NS50eHQgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxh eS9icmlkZ2UvdGksZHM5MGMxODUudHh0Cj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAw MDAwMDAwMDAwMDAuLmU1NzVmOTk2OTU5YQo+IC0tLSAvZGV2L251bGwKPiArKysgYi9Eb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlkZ2UvdGksZHM5MGMxODUudHh0 Cj4gQEAgLTAsMCArMSw1NSBAQAo+ICtUZXhhcyBJbnN0cnVtZW50cyBGUEQtTGluayAoTFZEUykg U2VyaWFsaXplcgo+ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQo+ICsKPiArVGhlIERTOTBDMTg1IGFuZCBEUzkwQzE4NyBhcmUgbG93LXBvd2VyIHNlcmlhbGl6 ZXJzIGZvciBwb3J0YWJsZQo+ICtiYXR0ZXJ5LXBvd2VyZWQgYXBwbGljYXRpb25zIHRoYXQgcmVk dWNlcyB0aGUgc2l6ZSBvZiB0aGUgUkdCCj4gK2ludGVyZmFjZSBiZXR3ZWVuIHRoZSBob3N0IEdQ VSBhbmQgdGhlIGRpc3BsYXkuCj4gKwo+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ICsKPiArLSBj b21wYXRpYmxlOiBTaG91bGQgYmUKPiArICAidGksZHM5MGMxODUiLCAibHZkcy1lbmNvZGVyIiAg Zm9yIHRoZSBUSSBEUzkwQzE4NSBGUEQtTGluayBTZXJpYWxpemVyCj4gKyAgInRpLGRzOTBjMTg3 IiwgImx2ZHMtZW5jb2RlciIgIGZvciB0aGUgVEkgRFM5MEMxODcgRlBELUxpbmsgU2VyaWFsaXpl cgo+ICsKPiArT3B0aW9uYWwgcHJvcGVydGllczoKPiArCj4gKy0gcG93ZXJkb3duLWdwaW9zOiBQ b3dlciBkb3duIGNvbnRyb2wgR1BJTyAodGhlIFBEQiBwaW4sIGFjdGl2ZS1sb3cpCj4gKwo+ICtS ZXF1aXJlZCBub2RlczoKPiArCj4gK1RoZSBkZXZpY2VzIGhhdmUgdHdvIHZpZGVvIHBvcnRzLiBU aGVpciBjb25uZWN0aW9ucyBhcmUgbW9kZWxlZCB1c2luZyB0aGUgT0YKPiArZ3JhcGggYmluZGlu Z3Mgc3BlY2lmaWVkIGluIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9ncmFwaC50 eHQuCj4gKwo+ICstIFZpZGVvIHBvcnQgMCBmb3IgcGFyYWxsZWwgaW5wdXQKPiArLSBWaWRlbyBw b3J0IDEgZm9yIExWRFMgb3V0cHV0Cj4gKwo+ICsKPiArRXhhbXBsZQo+ICstLS0tLS0tCj4gKwo+ ICtsdmRzLWVuY29kZXIgewo+ICsJY29tcGF0aWJsZSA9ICJ0aSxkczkwYzE4NSIsICJsdmRzLWVu Y29kZXIiOwo+ICsKPiArCXBvd2VyZG93bi1ncGlvcyA9IDwmZ3BpbyAxNyBHUElPX0FDVElWRV9M T1c+Owo+ICsKPiArCXBvcnRzIHsKPiArCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiArCQkjc2l6 ZS1jZWxscyA9IDwwPjsKPiArCj4gKwkJcG9ydEAwIHsKPiArCQkJcmVnID0gPDA+Owo+ICsKPiAr CQkJbHZkc19lbmNfaW46IGVuZHBvaW50IHsKPiArCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmbGNk Y19vdXRfcmdiPjsKPiArCQkJfTsKPiArCQl9Owo+ICsKPiArCQlwb3J0QDEgewo+ICsJCQlyZWcg PSA8MT47Cj4gKwo+ICsJCQlsdmRzX2VuY19vdXQ6IGVuZHBvaW50IHsKPiArCQkJCXJlbW90ZS1l bmRwb2ludCA9IDwmbHZkc19wYW5lbF9pbj47Cj4gKwkJCX07Cj4gKwkJfTsKPiArCX07Cj4gK307 Cj4gLS0gCj4gMi4xMS4wCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0EBCC43387 for ; Fri, 11 Jan 2019 14:49:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF4B02063F for ; Fri, 11 Jan 2019 14:49:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547218150; bh=YLobwEjBadq0DVtEDFj3zfoYD/c4Lf1OfoVgLGY4aUM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=nEpIbtNRuWaBqKAahnx/OepxEhMOsBEhRapw6P6FOn2TBPzRYTrzaDlu88Ot94GvD SPbCJT8/Ad+EfuI56apolwf7WlvgET5Gy5q8h2I3kgGPg17CeOla5705aJGK00sxJz BzyqYBs0Ov30UI/BrUo36pwaWT1/Xj+YSyoIFwcg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391563AbfAKOtJ (ORCPT ); Fri, 11 Jan 2019 09:49:09 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:46294 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390588AbfAKOtH (ORCPT ); Fri, 11 Jan 2019 09:49:07 -0500 Received: by mail-oi1-f194.google.com with SMTP id x202so12352468oif.13; Fri, 11 Jan 2019 06:49:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SIPdx1HAsZRsvph0eZMR6v07pA/jnpTy7e7w+WEoxts=; b=ivS1Xm+OA5lArE5Y3tqFKwUl+dnR+sBd3FquZebNN0auhUyiVaDWmgJO3U0gCd7scP biBExIgefYCd1Nqa+LDERTMtPnIVQo7dN2ZkbxWeZCoTBoK5Vv4447QTefEFukC+SgZn s2QmG9gnrnVYYSms7IbuU3tMcvlVPfnyfY5j/jT6Mmg8RKQYVWFRU52WCQ89GmzPakwp 0LHgTHyFZgsDQ1rwiSQFqhMiy9fxpuOr3vsTqu9GdIjL4/5bKSG364pfwZTTRe+qFgVQ YpAf0061bL3OXTsrpp21xZvuU5mtU54soGlfmbgm73AoEwoEk6zv2nVfssv7gLt6ozIC FyCA== X-Gm-Message-State: AJcUukcCehBysXY3jySUupJQ3r4SAMg2xRUHk5Ho8sUNuVlQ0bsPNuqE 0xjECpJoAdi70QZZwMkfXw== X-Google-Smtp-Source: ALg8bN77ZAY0JivJCtUfM9C5FOyALXB5CxO6pcEdphsMjI6nHgaEcWGXpufLcuMTNmlM1Ymaz1GPKQ== X-Received: by 2002:aca:ef0b:: with SMTP id n11mr9053611oih.116.1547218145338; Fri, 11 Jan 2019 06:49:05 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id k13sm59184088otj.19.2019.01.11.06.49.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Jan 2019 06:49:04 -0800 (PST) Date: Fri, 11 Jan 2019 08:49:04 -0600 From: Rob Herring To: Peter Rosin Cc: "linux-kernel@vger.kernel.org" , David Airlie , Mark Rutland , Archit Taneja , Andrzej Hajda , Laurent Pinchart , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH v3 1/5] dt-bindings: display: bridge: fork out ti,ds90c185 from lvds-transmitter Message-ID: <20190111144904.GA5052@bogus> References: <20181229070649.21308-1-peda@axentia.se> <20181229070649.21308-2-peda@axentia.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181229070649.21308-2-peda@axentia.se> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 29, 2018 at 07:07:19AM +0000, Peter Rosin wrote: > DS90C185 has a shutdown pin which does not fit in the lvds-transmitter > binding, which is meant to be generic. > > The sister chip DS90C187 is similar to DS90C185, describe it here as well. > > Signed-off-by: Peter Rosin > --- > .../bindings/display/bridge/lvds-transmitter.txt | 8 +--- > .../bindings/display/bridge/ti,ds90c185.txt | 55 ++++++++++++++++++++++ > 2 files changed, 56 insertions(+), 7 deletions(-) > create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > index 50220190c203..fd39ad34c383 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt > @@ -22,13 +22,7 @@ among others. > > Required properties: > > -- compatible: Must be one or more of the following > - - "ti,ds90c185" for the TI DS90C185 FPD-Link Serializer > - - "lvds-encoder" for a generic LVDS encoder device > - > - When compatible with the generic version, nodes must list the > - device-specific version corresponding to the device first > - followed by the generic version. I think you should keep something here. I'd reword it to say any encoder with additional properties must have a device specific compatible in addition. > +- compatible: Must be "lvds-encoder" > > Required nodes: > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt b/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt > new file mode 100644 > index 000000000000..e575f996959a > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt > @@ -0,0 +1,55 @@ > +Texas Instruments FPD-Link (LVDS) Serializer > +-------------------------------------------- > + > +The DS90C185 and DS90C187 are low-power serializers for portable > +battery-powered applications that reduces the size of the RGB > +interface between the host GPU and the display. > + > +Required properties: > + > +- compatible: Should be > + "ti,ds90c185", "lvds-encoder" for the TI DS90C185 FPD-Link Serializer > + "ti,ds90c187", "lvds-encoder" for the TI DS90C187 FPD-Link Serializer > + > +Optional properties: > + > +- powerdown-gpios: Power down control GPIO (the PDB pin, active-low) > + > +Required nodes: > + > +The devices have two video ports. Their connections are modeled using the OF > +graph bindings specified in Documentation/devicetree/bindings/graph.txt. > + > +- Video port 0 for parallel input > +- Video port 1 for LVDS output > + > + > +Example > +------- > + > +lvds-encoder { > + compatible = "ti,ds90c185", "lvds-encoder"; > + > + powerdown-gpios = <&gpio 17 GPIO_ACTIVE_LOW>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + lvds_enc_in: endpoint { > + remote-endpoint = <&lcdc_out_rgb>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + lvds_enc_out: endpoint { > + remote-endpoint = <&lvds_panel_in>; > + }; > + }; > + }; > +}; > -- > 2.11.0 >