From: Brian Masney <masneyb@onstation.org>
To: linus.walleij@linaro.org, sboyd@kernel.org,
bjorn.andersson@linaro.org, andy.gross@linaro.org
Cc: marc.zyngier@arm.com, shawnguo@kernel.org, dianders@chromium.org,
linux-gpio@vger.kernel.org, nicolas.dechesne@linaro.org,
niklas.cassel@linaro.org, david.brown@linaro.org,
robh+dt@kernel.org, mark.rutland@arm.com,
thierry.reding@gmail.com, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: [PATCH v4 05/14] gpio: add irq domain activate/deactivate functions
Date: Sun, 13 Jan 2019 10:47:07 -0500 [thread overview]
Message-ID: <20190113154716.5145-6-masneyb@onstation.org> (raw)
In-Reply-To: <20190113154716.5145-1-masneyb@onstation.org>
This adds the two new functions gpiochip_irq_domain_activate and
gpiochip_irq_domain_deactivate that can be used as the activate and
deactivate functions in the struct irq_domain_ops. This is for
situations where only gpiochip_{lock,unlock}_as_irq needs to be called.
SPMI and SSBI GPIO are two users that will initially use these
functions.
Signed-off-by: Brian Masney <masneyb@onstation.org>
Suggested-by: Stephen Boyd <sboyd@kernel.org>
Reviewed-by: Stephen Boyd <sboyd@kernel.org>
---
Changes since v3:
- Correct kernel doc syntax: 'struct &foo' -> '&struct foo'
'&func' -> 'func()'
drivers/gpio/gpiolib.c | 37 +++++++++++++++++++++++++++++++++++++
include/linux/gpio/driver.h | 5 +++++
2 files changed, 42 insertions(+)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 1651d7f0a303..ca81252b97b9 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1775,6 +1775,43 @@ static const struct irq_domain_ops gpiochip_domain_ops = {
.xlate = irq_domain_xlate_twocell,
};
+/**
+ * gpiochip_irq_domain_activate() - Lock a GPIO to be used as an IRQ
+ * @domain: The IRQ domain used by this IRQ chip
+ * @data: Outermost irq_data associated with the IRQ
+ * @reserve: If set, only reserve an interrupt vector instead of assigning one
+ *
+ * This function is a wrapper that calls gpiochip_lock_as_irq() and is to be
+ * used as the activate function for the &struct irq_domain_ops. The host_data
+ * for the IRQ domain must be the &struct gpiochip.
+ */
+int gpiochip_irq_domain_activate(struct irq_domain *domain,
+ struct irq_data *data, bool reserve)
+{
+ struct gpio_chip *chip = domain->host_data;
+
+ return gpiochip_lock_as_irq(chip, data->hwirq);
+}
+EXPORT_SYMBOL_GPL(gpiochip_irq_domain_activate);
+
+/**
+ * gpiochip_irq_domain_deactivate() - Unlock a GPIO used as an IRQ
+ * @domain: The IRQ domain used by this IRQ chip
+ * @data: Outermost irq_data associated with the IRQ
+ *
+ * This function is a wrapper that will call gpiochip_unlock_as_irq() and is to
+ * be used as the deactivate function for the &struct irq_domain_ops. The
+ * host_data for the IRQ domain must be the &struct gpiochip.
+ */
+void gpiochip_irq_domain_deactivate(struct irq_domain *domain,
+ struct irq_data *data)
+{
+ struct gpio_chip *chip = domain->host_data;
+
+ return gpiochip_unlock_as_irq(chip, data->hwirq);
+}
+EXPORT_SYMBOL_GPL(gpiochip_irq_domain_deactivate);
+
static int gpiochip_to_irq(struct gpio_chip *chip, unsigned offset)
{
if (!gpiochip_irqchip_irq_valid(chip, offset))
diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 07cddbf45186..01497910f023 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -472,6 +472,11 @@ int gpiochip_irq_map(struct irq_domain *d, unsigned int irq,
irq_hw_number_t hwirq);
void gpiochip_irq_unmap(struct irq_domain *d, unsigned int irq);
+int gpiochip_irq_domain_activate(struct irq_domain *domain,
+ struct irq_data *data, bool reserve);
+void gpiochip_irq_domain_deactivate(struct irq_domain *domain,
+ struct irq_data *data);
+
void gpiochip_set_chained_irqchip(struct gpio_chip *gpiochip,
struct irq_chip *irqchip,
unsigned int parent_irq,
--
2.17.2
next prev parent reply other threads:[~2019-01-13 15:47 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-13 15:47 [PATCH v4 00/14] qcom: spmi: add support for hierarchical IRQ chip Brian Masney
2019-01-13 15:47 ` [PATCH v4 01/14] dt-bindings: pinctrl: qcom-pmic-gpio: add qcom,pmi8998-gpio binding Brian Masney
2019-01-14 23:42 ` Stephen Boyd
2019-01-15 0:28 ` Bjorn Andersson
2019-01-15 20:07 ` Rob Herring
2019-01-13 15:47 ` [PATCH v4 02/14] pinctrl: qcom: spmi-gpio: add support for three new variants Brian Masney
2019-01-14 23:43 ` Stephen Boyd
2019-01-15 0:28 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 03/14] pinctrl: qcom: spmi-gpio: hardcode IRQ counts Brian Masney
2019-01-14 23:43 ` Stephen Boyd
2019-01-15 0:34 ` Bjorn Andersson
2019-01-15 1:14 ` Brian Masney
2019-01-15 1:24 ` Brian Masney
2019-01-13 15:47 ` [PATCH v4 04/14] spmi: pmic-arb: convert to v2 irq interfaces to support hierarchical IRQ chips Brian Masney
2019-01-13 15:47 ` Brian Masney [this message]
2019-01-13 15:47 ` [PATCH v4 06/14] spmi: pmic-arb: disassociate old virq if hwirq mapping already exists Brian Masney
2019-01-14 23:50 ` Stephen Boyd
2019-01-15 0:42 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 07/14] qcom: spmi-gpio: add support for hierarchical IRQ chip Brian Masney
2019-01-13 15:47 ` [PATCH v4 08/14] ARM: dts: qcom: pm8941: add interrupt controller properties Brian Masney
2019-01-15 0:42 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 09/14] ARM: dts: qcom: pma8084: " Brian Masney
2019-01-14 23:44 ` Stephen Boyd
2019-01-15 0:42 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 10/14] arm64: dts: qcom: pm8005: " Brian Masney
2019-01-14 23:44 ` Stephen Boyd
2019-01-15 0:43 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 11/14] arm64: dts: qcom: pm8998: " Brian Masney
2019-01-14 23:44 ` Stephen Boyd
2019-01-15 0:43 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 12/14] arm64: dts: qcom: pmi8994: " Brian Masney
2019-01-14 23:43 ` Stephen Boyd
2019-01-15 0:43 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 13/14] arm64: dts: qcom: pmi8998: " Brian Masney
2019-01-14 23:43 ` Stephen Boyd
2019-01-15 0:43 ` Bjorn Andersson
2019-01-13 15:47 ` [PATCH v4 14/14] spmi: pmic-arb: revert "disassociate old virq if hwirq mapping already exists" Brian Masney
2019-01-14 8:43 ` [PATCH v4 00/14] qcom: spmi: add support for hierarchical IRQ chip Linus Walleij
2019-01-14 8:45 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190113154716.5145-6-masneyb@onstation.org \
--to=masneyb@onstation.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.dechesne@linaro.org \
--cc=niklas.cassel@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.