From: Olaf Hering <olaf@aepfle.de>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH] tools/firmware: update OVMF Makefile
Date: Sun, 13 Jan 2019 21:17:44 +0100 [thread overview]
Message-ID: <20190113201744.GA11328@aepfle.de> (raw)
In-Reply-To: <20181128174333.15672-1-wei.liu2@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 731 bytes --]
On Wed, Nov 28, Wei Liu wrote:
> OVMF has become dependent on OpenSSL, which it is included as a submodule.
> Initialise submodules before building.
> +++ b/tools/firmware/ovmf-makefile
> build:
> + $(GIT) submodule update --init --recursive
At least ef529e6ab7c31290a33045bb1f1837447cc0eb56 seems to have no
submodules. Also the referenced qemu-xen.git has submodules, but
building xen.git works fine if none of the download-on-demand extra
sources are actually git trees. I have not checked how qemu-xen.git
would get its submodules, but today there is most likely no
"$(GIT) submodule" call in the "build" make target.
I think to fix the build breakage introduced by b16281870 this call must
be moved somewhere else.
Olaf
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-01-13 20:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 17:43 [PATCH] tools/firmware: update OVMF Makefile Wei Liu
2018-11-28 17:47 ` Wei Liu
2018-11-29 11:31 ` Anthony PERARD
2018-11-29 11:39 ` Wei Liu
2018-11-29 12:02 ` Anthony PERARD
2018-11-29 13:03 ` Wei Liu
2019-01-09 10:58 ` Anthony PERARD
2019-01-09 11:11 ` Wei Liu
2019-01-09 14:56 ` Tamas K Lengyel
2019-01-09 14:56 ` Tamas K Lengyel
2019-01-09 15:46 ` Anthony PERARD
2019-01-09 16:03 ` Tamas K Lengyel
2019-01-09 18:27 ` Anthony PERARD
2019-01-13 20:17 ` Olaf Hering [this message]
2019-01-14 11:28 ` Wei Liu
2019-01-14 11:48 ` Olaf Hering
2019-01-14 17:11 ` Anthony PERARD
2019-01-14 17:27 ` Olaf Hering
2019-01-14 17:44 ` Wei Liu
2019-01-14 18:22 ` Anthony PERARD
2019-01-14 19:22 ` Olaf Hering
2019-01-14 17:42 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190113201744.GA11328@aepfle.de \
--to=olaf@aepfle.de \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.