From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v5,4/6] usb: gadget: add mechanism to specify an explicit status stage From: Paul Elder Message-Id: <20190114051113.GD32268@localhost.localdomain> Date: Mon, 14 Jan 2019 00:11:13 -0500 To: Alan Stern Cc: laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, b-liu@ti.com, rogerq@ti.com, balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gRnJpLCBKYW4gMTEsIDIwMTkgYXQgMTA6NTA6MTFBTSAtMDUwMCwgQWxhbiBTdGVybiB3cm90 ZToKPiBPbiBGcmksIDExIEphbiAyMDE5LCBQYXVsIEVsZGVyIHdyb3RlOgo+IAo+ID4gT24gV2Vk LCBKYW4gMDksIDIwMTkgYXQgMDI6MDY6MzFQTSAtMDUwMCwgQWxhbiBTdGVybiB3cm90ZToKPiA+ ID4gT24gV2VkLCA5IEphbiAyMDE5LCBQYXVsIEVsZGVyIHdyb3RlOgo+ID4gPiAKPiA+ID4gPiBB IHVzYiBnYWRnZXQgZnVuY3Rpb24gZHJpdmVyIG1heSBvciBtYXkgbm90IHdhbnQgdG8gZGVsYXkg dGhlIHN0YXR1cwo+ID4gPiA+IHN0YWdlIG9mIGEgY29udHJvbCBPVVQgcmVxdWVzdC4gQW4gaW5z dGFuY2Ugd2hlcmUgaXQgbWlnaHQgd2FudCB0byBpcyB0bwo+ID4gPiA+IGFzeW5jaHJvbm91c2x5 IHZhbGlkYXRlIHRoZSBkYXRhIG9mIGEgY2xhc3Mtc3BlY2lmaWMgcmVxdWVzdC4KPiA+ID4gPiAK PiA+ID4gPiBBIGZ1bmN0aW9uIGRyaXZlciB0aGF0IHdhbnRzIGFuIGV4cGxpY2l0IHN0YXR1cyBz dGFnZSBzaG91bGQgc2V0IHRoZQo+ID4gPiA+IG5ld2x5IGFkZGVkIGV4cGxpY2l0X3N0YXR1cyBm bGFnIG9mIHRoZSB1c2JfcmVxdWVzdCBjb3JyZXNwb25kaW5nIHRvIHRoZQo+ID4gPiA+IGRhdGEg c3RhZ2UuIExhdGVyIG9uLCB0aGUgZnVuY3Rpb24gZHJpdmVyIGNhbiBleHBsaWNpdGx5IGNvbXBs ZXRlIHRoZQo+ID4gPiA+IHN0YXR1cyBzdGFnZSBieSBlbnF1ZXVlaW5nIGEgdXNiX3JlcXVlc3Qg Zm9yIEFDSywgb3IgY2FsbGluZwo+ID4gPiA+IHVzYl9lcF9zZXRfaGFsdCgpIGZvciBTVEFMTC4K PiA+ID4gPiAKPiA+ID4gPiBUbyBzdXBwb3J0IGJvdGggZXhwbGljaXQgYW5kIGltcGxpY2l0IHN0 YXR1cyBzdGFnZXMsIGEgVURDIGRyaXZlciBtdXN0Cj4gPiA+ID4gY2FsbCB0aGUgbmV3bHkgYWRk ZWQgdXNiX2dhZGdldF9jb250cm9sX2NvbXBsZXRlIGZ1bmN0aW9uIHJpZ2h0IGJlZm9yZQo+ID4g PiA+IGNhbGxpbmcgdXNiX2dhZGdldF9naXZlYmFja19yZXF1ZXN0LiBUbyBzdXBwb3J0IHRoZSBl eHBsaWNpdCBzdGF0dXMKPiA+ID4gPiBzdGFnZSwgaXQgbWlnaHQgdGhlbiBjaGVjayB3aGF0IHN0 YWdlIHRoZSB1c2JfcmVxdWVzdCB3YXMgcXVldWVkIGluLCBhbmQKPiA+ID4gPiBmb3IgY29udHJv bCBJTiBBQ0sgdGhlIGhvc3QncyB6ZXJvLWxlbmd0aCBkYXRhIHBhY2tldCwgb3IgZm9yIGNvbnRy b2wKPiA+ID4gPiBPVVQgc2VuZCBhIHplcm8tbGVuZ3RoIERBVEExIEFDSyBwYWNrZXQuCj4gPiA+ ID4gCj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogUGF1bCBFbGRlciA8cGF1bC5lbGRlckBpZGVhc29u Ym9hcmQuY29tPgo+ID4gPiA+IHY0IEFja2VkLWJ5OiBBbGFuIFN0ZXJuIDxzdGVybkByb3dsYW5k LmhhcnZhcmQuZWR1Pgo+ID4gPiA+IHYxIFJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxs YXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gPiA+IAo+ID4gPiBUaGlzIGxvb2tz IGdvb2QgYW5kIGhhcyBwYXNzZWQgbXkgdGVzdHMgc28gZmFyLgo+ID4gCj4gPiBHb29kISBUaGFu ayB5b3UgOikKPiA+IAo+ID4gPiBDYW4geW91IGNoZWNrIHlvdXIgdXZjCj4gPiA+IGNoYW5nZXMg dXNpbmcgZHVtbXlfaGNkIHdpdGggdGhlIHBhdGNoIGJlbG93Pwo+ID4gCj4gPiBJJ20gbm90IHN1 cmUgd2hhdCB0byBtYWtlIG9mIHRoZSB0ZXN0IHJlc3VsdHMuIEkgZ2V0IHRoZSBzYW1lIHJlc3Vs dHMKPiA+IHdpdGggb3Igd2l0aG91dCB0aGUgcGF0Y2guIFdoaWNoIEkgZ3Vlc3MgbWFrZXMgc2Vu c2UuLi4gaW4gZHVtbXlfcXVldWUsCj4gPiB0aGlzIGlzIGdldHRpbmcgaGl0IHdoZW4gdGhlIHV2 YyBmdW5jdGlvbiBkcml2ZXIgdHJpZXMgdG8gY29tcGxldGUgdGhlCj4gPiBkZWxheWVkIHN0YXR1 czoKPiA+IAo+ID4gCXJlcSA9IHVzYl9yZXF1ZXN0X3RvX2R1bW15X3JlcXVlc3QoX3JlcSk7Cj4g PiAJaWYgKCFfcmVxIHx8ICFsaXN0X2VtcHR5KCZyZXEtPnF1ZXVlKSB8fCAhX3JlcS0+Y29tcGxl dGUpCj4gPiAJCXJldHVybiAtRUlOVkFMOwo+ID4gCj4gPiBTbyB0aGUgZGVsYXllZC9leHBsaWNp dCBzdGF0dXMgc3RhZ2UgaXMgbmV2ZXIgY29tcGxldGVkLCBhZmFpY3QuCj4gCj4gSSBwcmVzdW1l IHlvdSBhcmUgaGl0dGluZyB0aGUgIWxpc3RfZW1wdHkoJnJlcS0+cXVldWUpIHRlc3QsIHllcz8g IFRoZSAKPiBvdGhlciB0d28gdGVzdHMgYXJlIHRyaXZpYWwuCgpZZXMsIHRoYXQgaXMgd2hhdCdz IGhhcHBlbmluZy4KCj4gVHJpZ2dlcmluZyB0aGUgIWxpc3RfZW1wdHkoKSB0ZXN0IG1lYW5zIHRo ZSByZXF1ZXN0IGhhcyBhbHJlYWR5IGJlZW4KPiBzdWJtaXR0ZWQgYW5kIG5vdCB5ZXQgY29tcGxl dGVkLiAgVGhpcyBwcm9iYWJseSBpbmRpY2F0ZXMgdGhlcmUgaXMgYQo+IGJ1ZyBpbiB0aGUgdXZj IGZ1bmN0aW9uIGRyaXZlciBjb2RlLgoKVGhlIHV2YyBmdW5jdGlvbiBkcml2ZXIgd29ya3Mgd2l0 aCBtdXNiLCB0aG91Z2ggOi8KCkkgY29tcGFyZWQgdGhlIHNlcXVlbmNlIG9mIGNhbGxzIHRvIHRo ZSB1dmMgc2V0dXAsIGNvbXBsZXRpb24gaGFuZGxlciwKYW5kIHN0YXR1cyBzdGFnZSBzZW5kaW5n LCBhbmQgZm9yIHNvbWUgcmVhc29uIGR1bW15X2hjZCwgYWZ0ZXIgYW4gT1VUCnNldHVwLWNvbXBs ZXRpb24tc3RhdHVzIHNlcXVlbmNlLCBjYWxscyBhIGNvbXBsZXRpb24tc3RhdHVzLWNvbXBsZXRp b24Kc2VxdWVuY2UsIGFuZCB0aGVuIGdvZXMgb24gdGhlIHRoZSBuZXh0IHJlcXVlc3QuIG11c2Ig c2ltcGx5IGdvZXMgb24gdG8KdGhlIG5leHQgcmVxdWVzdCBhZnRlciB0aGUgc2V0dXAtY29tcGxl dGlvbi1zdGF0dXMgc2VxdWVuY2UuCgpJIGNvbW1lbnRlZCBvdXQgdGhlIHBhcmFub2lhIGJsb2Nr IGluIGR1bW15X3RpbWVyLCBhbmQgZHVtbXlfaGNkIHN0aWxsCmRvZXMgdGhlIGV4dHJhIGNvbXBs ZXRpb24sIGJ1dCBpdCBkb2Vzbid0IGVycm9yIG91dCBhbnltb3JlLiBJIGRvdWJ0CnRoYXQncyB0 aGUvYSBzb2x1dGlvbiB0aG91Z2gsIGVzcGVjaWFsbHkgc2luY2UgSSBnZXQ6CgpbICAgMjIuNjE2 NTc3XSB1dmN2aWRlbzogRmFpbGVkIHRvIHF1ZXJ5ICgxMjkpIFVWQyBwcm9iZSBjb250cm9sIDog LTc1IChleHAuIDI2KS4KWyAgIDIyLjYyNDQ4MV0gdXZjdmlkZW86IEZhaWxlZCB0byBpbml0aWFs aXplIHRoZSBkZXZpY2UgKC01KS4KCk5vdCBzdXJlIGlmIHRoYXQncyBhIHJlc3VsdCBvZiBkdW1t eV9oY2Qgbm90IHN1cHBvcnRpbmcgaXNvY2hyb25vdXMKdHJhbnNmZXJzIG9yIG5vdC4KCkknbSBu b3Qgc3VyZSB3aGVyZSB0byBjb250aW51ZSBpbnZlc3RpZ2F0aW5nIDovCgoKVGhhbmtzLAoKUGF1 bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D255C43387 for ; Mon, 14 Jan 2019 05:11:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CABF420659 for ; Mon, 14 Jan 2019 05:11:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="u9Dz3Tie" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726522AbfANFLX (ORCPT ); Mon, 14 Jan 2019 00:11:23 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:35994 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725910AbfANFLX (ORCPT ); Mon, 14 Jan 2019 00:11:23 -0500 Received: from localhost.localdomain (unknown [96.44.9.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 74FA7505; Mon, 14 Jan 2019 06:11:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1547442680; bh=esYPm4b0uDdBX5f/Z8E07u3/w+FPQbC3SDb9m+cNhaw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u9Dz3TieCLdVPwgi1YF+nMtdIJB/H+aPWNsxMgeRi4bBGMUGPvtWSd8odlNSBhwyh bVUg/3KH9sEyaUXFgH96bF1y9EXHJ3DAiIEhW1CGG8xqD5xHLpYi4hut6aVzTE+5SD obuB35ZGRPK5XnNRNp6gRRr0vMg+NN0vM2aif+9A= Date: Mon, 14 Jan 2019 00:11:13 -0500 From: Paul Elder To: Alan Stern Cc: laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, b-liu@ti.com, rogerq@ti.com, balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 4/6] usb: gadget: add mechanism to specify an explicit status stage Message-ID: <20190114051113.GD32268@localhost.localdomain> References: <20190111082340.GB32268@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 11, 2019 at 10:50:11AM -0500, Alan Stern wrote: > On Fri, 11 Jan 2019, Paul Elder wrote: > > > On Wed, Jan 09, 2019 at 02:06:31PM -0500, Alan Stern wrote: > > > On Wed, 9 Jan 2019, Paul Elder wrote: > > > > > > > A usb gadget function driver may or may not want to delay the status > > > > stage of a control OUT request. An instance where it might want to is to > > > > asynchronously validate the data of a class-specific request. > > > > > > > > A function driver that wants an explicit status stage should set the > > > > newly added explicit_status flag of the usb_request corresponding to the > > > > data stage. Later on, the function driver can explicitly complete the > > > > status stage by enqueueing a usb_request for ACK, or calling > > > > usb_ep_set_halt() for STALL. > > > > > > > > To support both explicit and implicit status stages, a UDC driver must > > > > call the newly added usb_gadget_control_complete function right before > > > > calling usb_gadget_giveback_request. To support the explicit status > > > > stage, it might then check what stage the usb_request was queued in, and > > > > for control IN ACK the host's zero-length data packet, or for control > > > > OUT send a zero-length DATA1 ACK packet. > > > > > > > > Signed-off-by: Paul Elder > > > > v4 Acked-by: Alan Stern > > > > v1 Reviewed-by: Laurent Pinchart > > > > > > This looks good and has passed my tests so far. > > > > Good! Thank you :) > > > > > Can you check your uvc > > > changes using dummy_hcd with the patch below? > > > > I'm not sure what to make of the test results. I get the same results > > with or without the patch. Which I guess makes sense... in dummy_queue, > > this is getting hit when the uvc function driver tries to complete the > > delayed status: > > > > req = usb_request_to_dummy_request(_req); > > if (!_req || !list_empty(&req->queue) || !_req->complete) > > return -EINVAL; > > > > So the delayed/explicit status stage is never completed, afaict. > > I presume you are hitting the !list_empty(&req->queue) test, yes? The > other two tests are trivial. Yes, that is what's happening. > Triggering the !list_empty() test means the request has already been > submitted and not yet completed. This probably indicates there is a > bug in the uvc function driver code. The uvc function driver works with musb, though :/ I compared the sequence of calls to the uvc setup, completion handler, and status stage sending, and for some reason dummy_hcd, after an OUT setup-completion-status sequence, calls a completion-status-completion sequence, and then goes on the the next request. musb simply goes on to the next request after the setup-completion-status sequence. I commented out the paranoia block in dummy_timer, and dummy_hcd still does the extra completion, but it doesn't error out anymore. I doubt that's the/a solution though, especially since I get: [ 22.616577] uvcvideo: Failed to query (129) UVC probe control : -75 (exp. 26). [ 22.624481] uvcvideo: Failed to initialize the device (-5). Not sure if that's a result of dummy_hcd not supporting isochronous transfers or not. I'm not sure where to continue investigating :/ Thanks, Paul