From: Cornelia Huck <cohuck@redhat.com>
To: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Cc: qemu-devel@nongnu.org, yuval.shaia@oracle.com, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/3] contrib/rdmacm-mux: fix clang compilation
Date: Mon, 14 Jan 2019 12:42:46 +0100 [thread overview]
Message-ID: <20190114124246.6de38d67.cohuck@redhat.com> (raw)
In-Reply-To: <20190112150225.20294-1-marcel.apfelbaum@gmail.com>
On Sat, 12 Jan 2019 17:02:22 +0200
Marcel Apfelbaum <marcel.apfelbaum@gmail.com> wrote:
> Fix Commit a5d2f6f877 (contrib/rdmacm-mux: Add implementation
> of RDMA User MAD multiplexer).
>
> The above commit introduces a new contrib target, adding a global dependency
> to libumad library in case pvrdma configuration option is enabled.
> Clang forbids it:
> clang-6.0: error: -libumad: 'linker' input unused
> [-Werror,-Wunused-command-line-argument]
>
> Fix by limiting the scope to the rdmacm-mux target itself.
> Fix related clang errors while at it.
>
> Marcel Apfelbaum (3):
> contrib/rdmacm-mux: remove Wno-format-truncation flag
> hw/rdma: modify struct initialization
> contrib/rdmacm-mux: fix clang compilation
>
> Makefile | 2 ++
> contrib/rdmacm-mux/Makefile.objs | 1 -
> contrib/rdmacm-mux/main.c | 18 +++++++++++++-----
> hw/rdma/rdma_backend.c | 16 ++++++++++++----
> 4 files changed, 27 insertions(+), 10 deletions(-)
>
This fixes building on x86 with clang 6 for me. On s390x with clang 7,
I run into further problems when building the s390-ccw bios (the
maintainers are aware of that), but the rdma-related errors are gone.
Tested-by: Cornelia Huck <cohuck@redhat.com>
next prev parent reply other threads:[~2019-01-14 11:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 15:02 [Qemu-devel] [PATCH 0/3] contrib/rdmacm-mux: fix clang compilation Marcel Apfelbaum
2019-01-12 15:02 ` [Qemu-devel] [PATCH 1/3] contrib/rdmacm-mux: remove Wno-format-truncation flag Marcel Apfelbaum
2019-01-13 20:32 ` Yuval Shaia
2019-01-12 15:02 ` [Qemu-devel] [PATCH 2/3] hw/rdma: modify struct initialization Marcel Apfelbaum
2019-01-13 19:24 ` Yuval Shaia
2019-01-13 19:36 ` Yuval Shaia
2019-01-14 21:23 ` Marcel Apfelbaum
2019-01-14 11:47 ` Cornelia Huck
2019-01-14 21:22 ` Marcel Apfelbaum
2019-01-12 15:02 ` [Qemu-devel] [PATCH 3/3] contrib/rdmacm-mux: fix clang compilation Marcel Apfelbaum
2019-01-13 19:26 ` Yuval Shaia
2019-01-14 11:42 ` Cornelia Huck [this message]
2019-01-14 21:26 ` [Qemu-devel] [PATCH 0/3] " Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114124246.6de38d67.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.