From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a5d:6089:0:0:0:0:0 with SMTP id w9csp3333649wrt; Mon, 14 Jan 2019 10:35:55 -0800 (PST) X-Google-Smtp-Source: ALg8bN4PMXKsflp6O7Nrf0s2u/YaEomUu4FzM/Ky9TfPX3D5eXfkuReXmauPo5F+4kGV1sr68k1Z X-Received: by 2002:a1c:ad43:: with SMTP id w64mr368198wme.32.1547490955086; Mon, 14 Jan 2019 10:35:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547490955; cv=none; d=google.com; s=arc-20160816; b=YhBHs/1J9HoWaZ2IYOn49ht1COJWxRAfstQBEYcbNeXp76p4WdUhsg5y+QZOCb6QT0 nP25w51Rqn35JKLHXVYyJRmex5jJKRX4l8EthcddUNyd5l7mr8en0/zPqmCTeat91JwH E+dsuNxCkXt6vbF29SScMO6jvMwfD1LbivemLbWGlodC3fMU2mLHGt74+V0Pu5EIthtt xeFEhFvw2N2+9SPrij806PD0pnk+3itc57N/8YGjIS2/edbadoYKQo8X47WrC5A83sYL UQMviMuGSjnOKNe7PBndYUq81p9obQlnanKgmK2KvYDLJnc987XD1S2Y4295CuJerDzV lwUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:in-reply-to :content-disposition:mime-version:references:message-id:to:from:date; bh=gotMr8j/g6ZJMHJSh6vI2/ivRgjiQ8uPLRW08MOC8AU=; b=OVyZV4eSK2A8vxxnXdHpVMdEO0boEobgPNc/JtpQ0EdldgY8vyCATYQq0nEfVvmVtu nu3aNo/SfbSVdEoZgaadYX+NfaI1KQfIYL0ynzfuVB28MSBY3fF5xXVSm7ZzGYGlM8sp moROtGR14dOhx5YZjaPZ31L7nJdTUxEjKU87s9x7HEHcIGZ/bYE5s36KTaQ6HVU1DqMo s/v1LOhb/phI/7y3y6cppfPkFB+TGt3RC+odOAQMqhysAhZIwAVhF4eKY9B4wNlFfCvX fasf0ZnnIdSCkxK3WX9fdKxBEsZw8lgE3VEZDkVWznhswCbHRaIYTgQOtYgJXmee4vxf B8DQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m12si19037292wmd.167.2019.01.14.10.35.54 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 14 Jan 2019 10:35:55 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([127.0.0.1]:43851 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj75W-0007Za-65 for alex.bennee@linaro.org; Mon, 14 Jan 2019 13:35:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj75P-0007ZP-5o for qemu-arm@nongnu.org; Mon, 14 Jan 2019 13:35:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gj75O-0006Ga-Gh for qemu-arm@nongnu.org; Mon, 14 Jan 2019 13:35:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50120) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gj75O-0006FY-AT; Mon, 14 Jan 2019 13:35:46 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AB0657F3EC; Mon, 14 Jan 2019 18:35:44 +0000 (UTC) Received: from redhat.com (ovpn-124-229.rdu2.redhat.com [10.10.124.229]) by smtp.corp.redhat.com (Postfix) with SMTP id C7B695D76A; Mon, 14 Jan 2019 18:35:42 +0000 (UTC) Date: Mon, 14 Jan 2019 13:35:37 -0500 From: "Michael S. Tsirkin" To: Igor Mammedov Message-ID: <20190114133455-mutt-send-email-mst@kernel.org> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181105014047.26447-17-sameo@linux.intel.com> <20181108152341.68e5a147@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181108152341.68e5a147@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 14 Jan 2019 18:35:44 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-arm] [PATCH v5 16/24] hw: acpi: Fix memory hotplug AML generation error X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Yang Zhong , Peter Maydell , Stefano Stabellini , Samuel Ortiz , qemu-devel@nongnu.org, Eduardo Habkost , Shannon Zhao , qemu-arm@nongnu.org, Marcel Apfelbaum , Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: 8cGkgBUV/PKf On Thu, Nov 08, 2018 at 03:23:41PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:39 +0100 > Samuel Ortiz wrote: > > > From: Yang Zhong > > > > When using the generated memory hotplug AML, the iasl > > compiler would give the following error: > > > > dsdt.dsl 266: Return (MOST (_UID, Arg0, Arg1, Arg2)) > > Error 6080 - Called method returns no value ^ > > > > Signed-off-by: Yang Zhong > Reviewed-by: Igor Mammedov > > I suggest to put this patch at the beginning of the series > before reference tables in test are updated. Samuel how about a separate small series with just bugfixes for starters? > > --- > > hw/acpi/memory_hotplug.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c > > index db2c4df961..893fc2bd27 100644 > > --- a/hw/acpi/memory_hotplug.c > > +++ b/hw/acpi/memory_hotplug.c > > @@ -686,15 +686,15 @@ void build_memory_hotplug_aml(Aml *table, uint32_t nr_mem, > > > > method = aml_method("_OST", 3, AML_NOTSERIALIZED); > > s = MEMORY_SLOT_OST_METHOD; > > - aml_append(method, aml_return(aml_call4( > > - s, aml_name("_UID"), aml_arg(0), aml_arg(1), aml_arg(2) > > - ))); > > + aml_append(method, > > + aml_call4(s, aml_name("_UID"), aml_arg(0), > > + aml_arg(1), aml_arg(2))); > > aml_append(dev, method); > > > > method = aml_method("_EJ0", 1, AML_NOTSERIALIZED); > > s = MEMORY_SLOT_EJECT_METHOD; > > - aml_append(method, aml_return(aml_call2( > > - s, aml_name("_UID"), aml_arg(0)))); > > + aml_append(method, > > + aml_call2(s, aml_name("_UID"), aml_arg(0))); > > aml_append(dev, method); > > > > aml_append(dev_container, dev); From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v5 16/24] hw: acpi: Fix memory hotplug AML generation error Date: Mon, 14 Jan 2019 13:35:37 -0500 Message-ID: <20190114133455-mutt-send-email-mst@kernel.org> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181105014047.26447-17-sameo@linux.intel.com> <20181108152341.68e5a147@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1gj75N-0002da-Pz for xen-devel@lists.xenproject.org; Mon, 14 Jan 2019 18:35:45 +0000 Content-Disposition: inline In-Reply-To: <20181108152341.68e5a147@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Igor Mammedov Cc: Yang Zhong , Peter Maydell , Stefano Stabellini , Samuel Ortiz , qemu-devel@nongnu.org, Eduardo Habkost , Shannon Zhao , qemu-arm@nongnu.org, Marcel Apfelbaum , Paolo Bonzini , Anthony Perard , xen-devel@lists.xenproject.org, Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBOb3YgMDgsIDIwMTggYXQgMDM6MjM6NDFQTSArMDEwMCwgSWdvciBNYW1tZWRvdiB3 cm90ZToKPiBPbiBNb24sICA1IE5vdiAyMDE4IDAyOjQwOjM5ICswMTAwCj4gU2FtdWVsIE9ydGl6 IDxzYW1lb0BsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+IAo+ID4gRnJvbTogWWFuZyBaaG9uZyA8 eWFuZy56aG9uZ0BpbnRlbC5jb20+Cj4gPiAKPiA+IFdoZW4gdXNpbmcgdGhlIGdlbmVyYXRlZCBt ZW1vcnkgaG90cGx1ZyBBTUwsIHRoZSBpYXNsCj4gPiBjb21waWxlciB3b3VsZCBnaXZlIHRoZSBm b2xsb3dpbmcgZXJyb3I6Cj4gPiAKPiA+IGRzZHQuZHNsIDI2NjogUmV0dXJuIChNT1NUIChfVUlE LCBBcmcwLCBBcmcxLCBBcmcyKSkKPiA+IEVycm9yIDYwODAgLSBDYWxsZWQgbWV0aG9kIHJldHVy bnMgbm8gdmFsdWUgXgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBZYW5nIFpob25nIDx5YW5nLnpo b25nQGludGVsLmNvbT4KPiBSZXZpZXdlZC1ieTogSWdvciBNYW1tZWRvdiA8aW1hbW1lZG9AcmVk aGF0LmNvbT4KPiAKPiBJIHN1Z2dlc3QgdG8gcHV0IHRoaXMgcGF0Y2ggYXQgdGhlIGJlZ2lubmlu ZyBvZiB0aGUgc2VyaWVzCj4gYmVmb3JlIHJlZmVyZW5jZSB0YWJsZXMgaW4gdGVzdCBhcmUgdXBk YXRlZC4KClNhbXVlbCBob3cgYWJvdXQgYSBzZXBhcmF0ZSBzbWFsbCBzZXJpZXMgd2l0aCBqdXN0 IGJ1Z2ZpeGVzCmZvciBzdGFydGVycz8KCgo+ID4gLS0tCj4gPiAgaHcvYWNwaS9tZW1vcnlfaG90 cGx1Zy5jIHwgMTAgKysrKystLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMo KyksIDUgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9ody9hY3BpL21lbW9yeV9o b3RwbHVnLmMgYi9ody9hY3BpL21lbW9yeV9ob3RwbHVnLmMKPiA+IGluZGV4IGRiMmM0ZGY5NjEu Ljg5M2ZjMmJkMjcgMTAwNjQ0Cj4gPiAtLS0gYS9ody9hY3BpL21lbW9yeV9ob3RwbHVnLmMKPiA+ ICsrKyBiL2h3L2FjcGkvbWVtb3J5X2hvdHBsdWcuYwo+ID4gQEAgLTY4NiwxNSArNjg2LDE1IEBA IHZvaWQgYnVpbGRfbWVtb3J5X2hvdHBsdWdfYW1sKEFtbCAqdGFibGUsIHVpbnQzMl90IG5yX21l bSwKPiA+ICAKPiA+ICAgICAgICAgICAgICBtZXRob2QgPSBhbWxfbWV0aG9kKCJfT1NUIiwgMywg QU1MX05PVFNFUklBTElaRUQpOwo+ID4gICAgICAgICAgICAgIHMgPSBNRU1PUllfU0xPVF9PU1Rf TUVUSE9EOwo+ID4gLSAgICAgICAgICAgIGFtbF9hcHBlbmQobWV0aG9kLCBhbWxfcmV0dXJuKGFt bF9jYWxsNCgKPiA+IC0gICAgICAgICAgICAgICAgcywgYW1sX25hbWUoIl9VSUQiKSwgYW1sX2Fy ZygwKSwgYW1sX2FyZygxKSwgYW1sX2FyZygyKQo+ID4gLSAgICAgICAgICAgICkpKTsKPiA+ICsg ICAgICAgICAgICBhbWxfYXBwZW5kKG1ldGhvZCwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAg IGFtbF9jYWxsNChzLCBhbWxfbmFtZSgiX1VJRCIpLCBhbWxfYXJnKDApLAo+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGFtbF9hcmcoMSksIGFtbF9hcmcoMikpKTsKPiA+ICAg ICAgICAgICAgICBhbWxfYXBwZW5kKGRldiwgbWV0aG9kKTsKPiA+ICAKPiA+ICAgICAgICAgICAg ICBtZXRob2QgPSBhbWxfbWV0aG9kKCJfRUowIiwgMSwgQU1MX05PVFNFUklBTElaRUQpOwo+ID4g ICAgICAgICAgICAgIHMgPSBNRU1PUllfU0xPVF9FSkVDVF9NRVRIT0Q7Cj4gPiAtICAgICAgICAg ICAgYW1sX2FwcGVuZChtZXRob2QsIGFtbF9yZXR1cm4oYW1sX2NhbGwyKAo+ID4gLSAgICAgICAg ICAgICAgICAgICAgICAgcywgYW1sX25hbWUoIl9VSUQiKSwgYW1sX2FyZygwKSkpKTsKPiA+ICsg ICAgICAgICAgICBhbWxfYXBwZW5kKG1ldGhvZCwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAg IGFtbF9jYWxsMihzLCBhbWxfbmFtZSgiX1VJRCIpLCBhbWxfYXJnKDApKSk7Cj4gPiAgICAgICAg ICAgICAgYW1sX2FwcGVuZChkZXYsIG1ldGhvZCk7Cj4gPiAgCj4gPiAgICAgICAgICAgICAgYW1s X2FwcGVuZChkZXZfY29udGFpbmVyLCBkZXYpOwoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlz dHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xp c3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:35783) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gj75Q-0007ZY-J1 for qemu-devel@nongnu.org; Mon, 14 Jan 2019 13:35:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gj75P-0006Hv-Vk for qemu-devel@nongnu.org; Mon, 14 Jan 2019 13:35:48 -0500 Date: Mon, 14 Jan 2019 13:35:37 -0500 From: "Michael S. Tsirkin" Message-ID: <20190114133455-mutt-send-email-mst@kernel.org> References: <20181105014047.26447-1-sameo@linux.intel.com> <20181105014047.26447-17-sameo@linux.intel.com> <20181108152341.68e5a147@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181108152341.68e5a147@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 16/24] hw: acpi: Fix memory hotplug AML generation error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: Samuel Ortiz , qemu-devel@nongnu.org, Shannon Zhao , Stefano Stabellini , Anthony Perard , Richard Henderson , Marcel Apfelbaum , xen-devel@lists.xenproject.org, Paolo Bonzini , qemu-arm@nongnu.org, Peter Maydell , Eduardo Habkost , Yang Zhong On Thu, Nov 08, 2018 at 03:23:41PM +0100, Igor Mammedov wrote: > On Mon, 5 Nov 2018 02:40:39 +0100 > Samuel Ortiz wrote: > > > From: Yang Zhong > > > > When using the generated memory hotplug AML, the iasl > > compiler would give the following error: > > > > dsdt.dsl 266: Return (MOST (_UID, Arg0, Arg1, Arg2)) > > Error 6080 - Called method returns no value ^ > > > > Signed-off-by: Yang Zhong > Reviewed-by: Igor Mammedov > > I suggest to put this patch at the beginning of the series > before reference tables in test are updated. Samuel how about a separate small series with just bugfixes for starters? > > --- > > hw/acpi/memory_hotplug.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c > > index db2c4df961..893fc2bd27 100644 > > --- a/hw/acpi/memory_hotplug.c > > +++ b/hw/acpi/memory_hotplug.c > > @@ -686,15 +686,15 @@ void build_memory_hotplug_aml(Aml *table, uint32_t nr_mem, > > > > method = aml_method("_OST", 3, AML_NOTSERIALIZED); > > s = MEMORY_SLOT_OST_METHOD; > > - aml_append(method, aml_return(aml_call4( > > - s, aml_name("_UID"), aml_arg(0), aml_arg(1), aml_arg(2) > > - ))); > > + aml_append(method, > > + aml_call4(s, aml_name("_UID"), aml_arg(0), > > + aml_arg(1), aml_arg(2))); > > aml_append(dev, method); > > > > method = aml_method("_EJ0", 1, AML_NOTSERIALIZED); > > s = MEMORY_SLOT_EJECT_METHOD; > > - aml_append(method, aml_return(aml_call2( > > - s, aml_name("_UID"), aml_arg(0)))); > > + aml_append(method, > > + aml_call2(s, aml_name("_UID"), aml_arg(0))); > > aml_append(dev, method); > > > > aml_append(dev_container, dev);