All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] net: phy: fixed-phy: Drop GPIO from fixed_phy_add()
Date: Mon, 14 Jan 2019 15:15:29 +0100	[thread overview]
Message-ID: <20190114141529.GH4635@lunn.ch> (raw)
In-Reply-To: <20190114080225.3805-1-linus.walleij@linaro.org>

On Mon, Jan 14, 2019 at 09:02:25AM +0100, Linus Walleij wrote:
> All users of the fixed_phy_add() pass -1 as GPIO number
> to the fixed phy driver, and all users of fixed_phy_register()
> pass -1 as GPIO number as well, except for the device
> tree MDIO bus.
> 
> Any new users should create a proper device and pass the
> GPIO as a descriptor associated with the device so delete
> the GPIO argument from the calls and drop the code looking
> requesting a GPIO in fixed_phy_add().
> 
> In fixed phy_register(), investigate the "fixed-link"
> node and pick the GPIO descriptor from "link-gpios" if
> this property exists. Move the corresponding code out
> of of_mdio.c as the fixed phy code anyways requires
> OF to be in use.

Hi Linus

I have the one and only device which uses this GPIO. I will do some
test in the next couple of days.

Thanks
     Andrew

  reply	other threads:[~2019-01-14 14:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14  8:02 [PATCH] net: phy: fixed-phy: Drop GPIO from fixed_phy_add() Linus Walleij
2019-01-14 14:15 ` Andrew Lunn [this message]
2019-01-15  1:46 ` Andrew Lunn
2019-01-15  1:48 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190114141529.GH4635@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.