From: David Disseldorp <ddiss@suse.de>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org, Filipe Manana <fdmanana@suse.com>
Subject: Re: [PATCH 2/3] Btrfs-progs: add missing error handling in find_mount_root()
Date: Mon, 14 Jan 2019 15:02:59 +0100 [thread overview]
Message-ID: <20190114150259.26190266@suse.de> (raw)
In-Reply-To: <20190114133134.18374-1-fdmanana@kernel.org>
On Mon, 14 Jan 2019 13:31:34 +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
>
> The strdup() function can fail, in which case it returns NULL and sets
> errno [1]. Therefore add the missing error check after calling strdup()
> at find_mount_root().
>
> [1] - http://man7.org/linux/man-pages/man3/strdup.3p.html
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
> ---
> utils.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Looks good:
Reviewed-by: David Disseldorp <ddiss@suse.de>
prev parent reply other threads:[~2019-01-14 14:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 13:31 [PATCH 2/3] Btrfs-progs: add missing error handling in find_mount_root() fdmanana
2019-01-14 14:02 ` David Disseldorp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114150259.26190266@suse.de \
--to=ddiss@suse.de \
--cc=fdmanana@kernel.org \
--cc=fdmanana@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.