From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 14 Jan 2019 11:27:53 -0500 Subject: [U-Boot] [PATCH v2] spl: implement CRC check on U-Boot uImage In-Reply-To: <1a41a5df-e82e-6cfb-e50f-dc5425fc61ec@gmail.com> References: <20181128205245.13957-1-simon.k.r.goldschmidt@gmail.com> <1a41a5df-e82e-6cfb-e50f-dc5425fc61ec@gmail.com> Message-ID: <20190114162753.GL5463@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Jan 14, 2019 at 04:38:24PM +0100, Simon Goldschmidt wrote: > Tom, > > Am 11.12.2018 um 02:07 schrieb Simon Glass: > >On Wed, 28 Nov 2018 at 13:52, Simon Goldschmidt > > wrote: > >> > >>SPL currently does not check uImage CRCs when loading U-Boot. > >> > >>This patch adds checking the uImage CRC when SPL loads U-Boot. It does > >>this by reusing the existing config option SPL_CRC32_SUPPORT to allow > >>leaving out the CRC check on boards where the additional code size or > >>boot time is a problem (adding the CRC check currently adds ~1.4 kByte > >>to flash). > >> > >>The SPL_CRC32_SUPPORT config option now gets enabled by default if SPL > >>support for legacy images is enabled to check the CRC on all boards > >>that don't actively take countermeasures. > >> > >>Signed-off-by: Simon Goldschmidt > >>--- > >> > >>Changes in v2: > >>- added Kconfig option SPL_LEGACY_IMAGE_CRC_CHECK to enable/disable > >> checking CRC on legacy images > >> > >> common/spl/Kconfig | 21 +++++++++++++++------ > >> common/spl/spl.c | 30 +++++++++++++++++++++++++++++- > >> include/spl.h | 5 +++++ > >> 3 files changed, 49 insertions(+), 7 deletions(-) > > > >Reviewed-by: Simon Glass > > This is assigned to you in patchwork, any reason you did not add it for the > 2019.01 release? Is there anything missing or was this just lost? I think I might have filed this off mentally as "Did we still want to do this?", so I'll pick it up for the next release, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: