From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=V+Nl=PW=vger.kernel.org=linux-fsdevel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 7E434C43387
	for <linux-fsdevel@archiver.kernel.org>; Mon, 14 Jan 2019 16:53:15 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 56998206B7
	for <linux-fsdevel@archiver.kernel.org>; Mon, 14 Jan 2019 16:53:15 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726832AbfANQxO (ORCPT
        <rfc822;linux-fsdevel@archiver.kernel.org>);
        Mon, 14 Jan 2019 11:53:14 -0500
Received: from verein.lst.de ([213.95.11.211]:47741 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726674AbfANQxM (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Mon, 14 Jan 2019 11:53:12 -0500
Received: by newverein.lst.de (Postfix, from userid 2407)
        id 6A56968DCF; Mon, 14 Jan 2019 17:53:11 +0100 (CET)
Date:   Mon, 14 Jan 2019 17:53:11 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Carlos Maiolino <cmaiolino@redhat.com>
Cc:     linux-fsdevel@vger.kernel.org, hch@lst.de, adilger@dilger.ca,
        sandeen@redhat.com, david@fromorbit.com
Subject: Re: [PATCH 07/10] fs: Use a void pointer to store fiemap_extent
Message-ID: <20190114165311.GE7187@lst.de>
References: <20181205091728.29903-1-cmaiolino@redhat.com> <20181205091728.29903-8-cmaiolino@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181205091728.29903-8-cmaiolino@redhat.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-fsdevel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-fsdevel.vger.kernel.org>
X-Mailing-List: linux-fsdevel@vger.kernel.org

>  	u64		fi_len;
>  	unsigned int	fi_extents_mapped;	/* Number of mapped extents */
>  	unsigned int	fi_extents_max;		/* Size of fiemap_extent array */
> -	struct		fiemap_extent __user *fi_extents_start;	/* Start of
> -								   fiemap_extent
> -								   array */
> +	void		*fi_extents_start;	/* Start of fiemap_extent
> +						   array */

I think this patch should be merged into the one passing the callback
as it is logically related.  I'd also rename fi_extents_start to
fi_cb_data to make the relation clear.