From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF42EC43387 for ; Mon, 14 Jan 2019 18:49:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 822B52064C for ; Mon, 14 Jan 2019 18:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547491780; bh=A6iddAN5sHjsSozTUi/CneDD+mh/0BCk1ZcqXT5PAVE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kAbfBSgxhLbJz61WDbk97fum+oQzG2Ghyw0fhmP6UyZvdran+d0bUwADJ9WR5U8d6 jGh5jHV3cc7LZCptoFdZB/yLEOiwx/41GQE0jOZZ1DdI/UwtVRy48ELIWPRNhvd30W DgiN1IwskSJj0zdlq3+Nim6+GmHcKclKBb/s6+/A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726729AbfANStj (ORCPT ); Mon, 14 Jan 2019 13:49:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:33156 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726708AbfANStj (ORCPT ); Mon, 14 Jan 2019 13:49:39 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C77D12064C; Mon, 14 Jan 2019 18:49:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547491778; bh=A6iddAN5sHjsSozTUi/CneDD+mh/0BCk1ZcqXT5PAVE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lEAKmV13aAp00Es7xL98qVNxz89wkH1OtToDefbXzmhxc3yQpSN1ZIFrwYgHflxf9 0F09tqqz5tmkfwSKKGwPA/z5Ul6I/GBWxQss2SCKSExn+J+Z/VFhabk/prjBl8MTmn Bb17zPjfzwRLokMG2M/XI30FMuit8/RqJvSP09F0= Date: Mon, 14 Jan 2019 19:49:35 +0100 From: Greg KH To: Gwendal Grignou Cc: stable@vger.kernel.org, groeck@chromium.org, keescook@chromium.org Subject: Re: [PATCH] FIXUP: proc: Provide details on speculation flaw mitigations Message-ID: <20190114184935.GA13821@kroah.com> References: <20190112003212.103301-1-gwendal@chromium.org> <20190112080125.GA17489@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jan 14, 2019 at 10:00:54AM -0800, Gwendal Grignou wrote: > On Sat, Jan 12, 2019 at 12:01 AM Greg KH wrote: > > > > On Fri, Jan 11, 2019 at 04:32:12PM -0800, Gwendal Grignou wrote: > > > Prevent an empty line in /proc/self/status, allow iotop to work. > > > > > > iotop does not like empty lines, fails with: > > > File "/usr/local/lib64/python2.7/site-packages/iotop/data.py", line > > > 196, in parse_proc_pid_status > > > key, value = line.split(':\t', 1) > > > ValueError: need more than 1 value to unpack > > > > > > [reading /proc/self/status] > > > > > > Signed-off-by: Gwendal Grignou > > > --- > > > fs/proc/array.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > Why send this to me? Always use scripts/get_maintainer.pl on a patch to > > determine who and what lists to send patches to. > I did, your email address is on the first line: > ./scripts/get_maintainer.pl > 0001-CHROMIUM-FIXUP-proc-Provide-details-on-speculation-f.patch > Greg Kroah-Hartman (commit_signer:6/4=100%) Ah, wait, you are making a patch against the stable kernel tree? We can't go back in time, you need to work against Linus's latest kernel tree, that's why I am showing up in this list. I'm not the upstream developer for this file. > "Srivatsa S. Bhat" (commit_signer:3/4=75%) > Thomas Gleixner > (commit_signer:3/4=75%,authored:1/4=25%,added_lines:3/28=11%) > David Woodhouse (commit_signer:3/4=75%) > Bo Gan (commit_signer:3/4=75%) > Kees Cook (authored:1/4=25%,added_lines:23/28=82%) > Konrad Rzeszutek Wilk > (authored:1/4=25%,removed_lines:1/2=50%) > Gwendal Grignou (authored:1/4=25%,removed_lines:1/2=50%) > linux-kernel@vger.kernel.org (open list) > > > > > And is this a new bug? What commit caused this? > It is only in 4.4 stable. It has been introduced by: > "484964fa3e5a0 proc: Provide details on speculation flaw mitigations" That really is commit fae1fa0fc6cca8beee3ab8ed71d54f9a78fa3f64 in Linus's tree, and is in the 4.4, 4.9, 4.14, 4.16, and 4.17 kernel releases. So it also is included in 5.0-rc1, if this is still an issue there, please submit the patch to the correct developers and then the patch will be backported to the needed stable kernel trees if you add the correct "Fixes:" and "cc: stable@stable.kernel.org" lines to the patch. Documentation/SubmittingPatches will tell you all about how to do this. > That patch adds an extra \n in front of "Speculation Store Bypass" > that breaks iotop processing of /proc/../status. Why isn't iotop broken in the latest kernel release? It seems to work for me here. thanks, greg k-h