From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-5330-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 335B59849F6 for ; Tue, 15 Jan 2019 02:20:19 +0000 (UTC) Date: Mon, 14 Jan 2019 21:20:15 -0500 From: "Michael S. Tsirkin" Message-ID: <20190114211953-mutt-send-email-mst@kernel.org> References: <20190103160804.21438-1-cohuck@redhat.com> <20190103160804.21438-2-cohuck@redhat.com> <20190114150958.39a4a56a.cohuck@redhat.com> <5C3D424B.70400@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5C3D424B.70400@intel.com> Subject: [virtio-dev] Re: [PATCH 1/2] virtio: fix virtio_config_ops description To: Wei Wang Cc: Cornelia Huck , Jason Wang , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, virtio-dev@lists.oasis-open.org, Halil Pasic List-ID: On Tue, Jan 15, 2019 at 10:15:39AM +0800, Wei Wang wrote: > On 01/14/2019 10:09 PM, Cornelia Huck wrote: > > On Thu, 3 Jan 2019 17:08:03 +0100 > > Cornelia Huck wrote: > > > > > - get_features has returned 64 bits since commit d025477368792 > > > ("virtio: add support for 64 bit features.") > > > - properly mark all optional callbacks > > > > > > Signed-off-by: Cornelia Huck > > > --- > > > include/linux/virtio_config.h | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h > > > index 32baf8e26735..7087ef946ba7 100644 > > > --- a/include/linux/virtio_config.h > > > +++ b/include/linux/virtio_config.h > > > @@ -22,7 +22,7 @@ struct irq_affinity; > > > * offset: the offset of the configuration field > > > * buf: the buffer to read the field value from. > > > * len: the length of the buffer > > > - * @generation: config generation counter > > > + * @generation: config generation counter (optional) > > > * vdev: the virtio_device > > > * Returns the config generation counter > > > * @get_status: read the status byte > > > @@ -48,17 +48,17 @@ struct irq_affinity; > > > * @del_vqs: free virtqueues found by find_vqs(). > > > * @get_features: get the array of feature bits for this device. > > > * vdev: the virtio_device > > > - * Returns the first 32 feature bits (all we currently need). > > > + * Returns the first 64 feature bits (all we currently need). > > > * @finalize_features: confirm what device features we'll be using. > > > * vdev: the virtio_device > > > * This gives the final feature bits for the device: it can change > > > * the dev->feature bits if it wants. > > > * Returns 0 on success or error status > > > - * @bus_name: return the bus name associated with the device > > > + * @bus_name: return the bus name associated with the device (optional) > > > * vdev: the virtio_device > > > * This returns a pointer to the bus name a la pci_name from which > > > * the caller can then copy. > > > - * @set_vq_affinity: set the affinity for a virtqueue. > > > + * @set_vq_affinity: set the affinity for a virtqueue (optional). > > > * @get_vq_affinity: get the affinity for a virtqueue (optional). > > > */ > > > typedef void vq_callback_t(struct virtqueue *); > > Ping. Any feedback on that patch? > > Reviewed-by: Wei Wang > > Best, > Wei Pushed already, can't add tags. Sorry about that. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org