All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>,
	xiaoguangrong.eric@gmail.com, stefanha@redhat.com,
	pbonzini@redhat.com, pagupta@redhat.com,
	yu.c.zhang@linux.intel.com, imammedo@redhat.com,
	dan.j.williams@intel.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V8 2/5] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter
Date: Mon, 14 Jan 2019 22:16:57 -0500	[thread overview]
Message-ID: <20190114221620-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190115023914.GA67749@tiger-server>

On Tue, Jan 15, 2019 at 10:39:14AM +0800, Yi Zhang wrote:
> > It's needed for this series but yes, this ifdefery belongs in
> > a more central header. Maybe qemu/osdep.h
> > And it needs documentation and be a separate patch.
> Agree, Thank Michael's explanation, better to doing this in a separate
> patch series.

Separate patch, does not have to be a separate series.

  reply	other threads:[~2019-01-15  3:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-02  5:25 [Qemu-devel] [PATCH V8 0/5] support MAP_SYNC for memory-backend-file Zhang Yi
2019-01-02  5:25 ` [Qemu-devel] [PATCH V8 1/5] numa: Fixed the memory leak of numa error message Zhang Yi
2019-01-14 18:54   ` Eduardo Habkost
2019-01-02  5:26 ` [Qemu-devel] [PATCH V8 2/5] util/mmap-alloc: switch qemu_ram_mmap() to 'flags' parameter Zhang Yi
2019-01-14 18:50   ` Eduardo Habkost
2019-01-14 19:04     ` Michael S. Tsirkin
2019-01-15  2:39       ` Yi Zhang
2019-01-15  3:16         ` Michael S. Tsirkin [this message]
2019-01-02  5:26 ` [Qemu-devel] [PATCH V8 3/5] util/mmap-alloc: support MAP_SYNC in qemu_ram_mmap() Zhang Yi
2019-01-14 19:07   ` Eduardo Habkost
2019-01-15  2:49     ` Yi Zhang
2019-01-15  3:34       ` Michael S. Tsirkin
2019-01-02  5:26 ` [Qemu-devel] [PATCH V8 4/5] hostmem: add more information in error messages Zhang Yi
2019-01-14 19:16   ` Eduardo Habkost
2019-01-02  5:26 ` [Qemu-devel] [PATCH V8 5/5] hostmem-file: add 'sync' option Zhang Yi
2019-01-14 19:39   ` Eduardo Habkost
2019-01-15  3:13     ` Yi Zhang
2019-01-15  3:21       ` Michael S. Tsirkin
2019-01-15  3:31   ` Michael S. Tsirkin
2019-01-15  6:55     ` Yi Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190114221620-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=dan.j.williams@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=pagupta@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=xiaoguangrong.eric@gmail.com \
    --cc=yu.c.zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.