From: Steven Rostedt <rostedt@goodmis.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>, LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Clark Williams <williams@redhat.com>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: Real deadlock being suppressed in sbitmap
Date: Mon, 14 Jan 2019 22:50:17 -0500 [thread overview]
Message-ID: <20190114225017.336c2347@vmware.local.home> (raw)
In-Reply-To: <20190115032355.GE10121@ming.t460p>
On Tue, 15 Jan 2019 11:23:56 +0800
Ming Lei <ming.lei@redhat.com> wrote:
> Given 'swap_lock' can be acquired from blk_mq_dispatch_rq_list() via
> blk_mq_get_driver_tag() directly, the above deadlock may be possible.
>
> Sounds the correct fix may be the following one, and the irqsave cost
> should be fine given sbitmap_deferred_clear is only triggered when one
> word is run out of.
Since the lockdep splat only showed SOFTIRQ issues, I figured I would
only protect it from that. Linus already accepted my patch, can you run
tests on that kernel with LOCKDEP enabled and see if it will trigger
with IRQ issues, then we can most definitely upgrade that to
spin_lock_irqsave(). But I was trying to keep the overhead down, as
that's a bit more heavy weight than a spin_lock_bh().
-- Steve
next prev parent reply other threads:[~2019-01-15 3:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 17:14 Real deadlock being suppressed in sbitmap Steven Rostedt
2019-01-14 19:43 ` Jens Axboe
2019-01-15 3:23 ` Ming Lei
2019-01-15 3:41 ` Jens Axboe
2019-01-15 3:46 ` Ming Lei
2019-01-15 3:50 ` Steven Rostedt [this message]
2019-01-15 4:14 ` Ming Lei
2019-01-15 4:25 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190114225017.336c2347@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.