From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH] net: phy: fixed-phy: Drop GPIO from fixed_phy_add()
Date: Tue, 15 Jan 2019 02:48:42 +0100
Message-ID: <20190115014842.GD8882@lunn.ch>
References: <20190114080225.3805-1-linus.walleij@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Florian Fainelli <f.fainelli@gmail.com>,
        "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
To: Linus Walleij <linus.walleij@linaro.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from vps0.lunn.ch ([185.16.172.187]:43203 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726769AbfAOBso (ORCPT <rfc822;netdev@vger.kernel.org>);
        Mon, 14 Jan 2019 20:48:44 -0500
Content-Disposition: inline
In-Reply-To: <20190114080225.3805-1-linus.walleij@linaro.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

>  struct phy_device *fixed_phy_register(unsigned int irq,
>  				      struct fixed_phy_status *status,
> -				      int link_gpio,
>  				      struct device_node *np)
>  {
>  	struct fixed_mdio_bus *fmb = &platform_fmb;
>  	struct phy_device *phy;
> +	struct gpio_desc *gpiod = NULL;
>  	int phy_addr;
>  	int ret;

Hi Linus

Networking code uses reverse christmas tree. Please move gpiod higher
up by one line.

Thanks
	Andrew