From: Anthony PERARD <anthony.perard@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Olaf Hering <olaf@aepfle.de>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] tools: only call git when necessary in OVMF Makefile
Date: Tue, 15 Jan 2019 11:36:42 +0000 [thread overview]
Message-ID: <20190115113642.GE1271@perard.uk.xensource.com> (raw)
In-Reply-To: <20190115112938.wcvh67sokhtlpw6u@zion.uk.xensource.com>
On Tue, Jan 15, 2019 at 11:29:38AM +0000, Wei Liu wrote:
> On Tue, Jan 15, 2019 at 11:27:12AM +0000, Andrew Cooper wrote:
> > On 15/01/2019 11:09, Wei Liu wrote:
> > > Users may choose to export a snapshot of OVMF and build it
> > > with xen.git supplied ovmf-makefile. In that case we don't
> > > need to call `git submodule`.
> > >
> > > Fixes b16281870e.
> > >
> > > Reported-by: Olaf Hering <olaf@aepfle.de>
> > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > > ---
> > > tools/firmware/ovmf-makefile | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/firmware/ovmf-makefile b/tools/firmware/ovmf-makefile
> > > index 3de2fc0300..55f9992145 100644
> > > --- a/tools/firmware/ovmf-makefile
> > > +++ b/tools/firmware/ovmf-makefile
> > > @@ -16,7 +16,7 @@ all: build
> > >
> > > .PHONY: build
> > > build:
> > > - $(GIT) submodule update --init --recursive
> > > + if test -e .git ; then $(GIT) submodule update --init --recursive ; fi
> >
> > You want -d rather than -e.
>
> Anthony said .git could be a link.
Actually, it can be a file. Example when `git worktree add` as been
used:
$ ls -l .git
-rw-r--r-- 1 user users 59 Dec 6 14:23 .git
$ cat .git
gitdir: /local/home/user/work/xen/.git/worktrees/git.72d1
And that's a submodule:
$ ls -l .git
-rw-r--r-- 1 user users 43 Oct 18 2017 .git
$ cat .git
gitdir: ../../.git/modules/ui/keycodemapdb
--
Anthony PERARD
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-01-15 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 11:09 [PATCH] tools: only call git when necessary in OVMF Makefile Wei Liu
2019-01-15 11:13 ` Anthony PERARD
2019-01-15 11:27 ` Andrew Cooper
2019-01-15 11:29 ` Wei Liu
2019-01-15 11:33 ` Andrew Cooper
2019-01-15 11:36 ` Anthony PERARD [this message]
2019-01-15 11:39 ` Wei Liu
2019-01-15 11:40 ` Wei Liu
2019-01-15 11:41 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115113642.GE1271@perard.uk.xensource.com \
--to=anthony.perard@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=olaf@aepfle.de \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.