From: Andrew Lunn <andrew@lunn.ch>
To: Camelia Groza <camelia.groza@nxp.com>
Cc: f.fainelli@gmail.com, hkallweit1@gmail.com, davem@davemloft.net,
oss@buserror.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: phy: phy driver features are mandatory
Date: Tue, 15 Jan 2019 15:05:09 +0100 [thread overview]
Message-ID: <20190115140509.GH19687@lunn.ch> (raw)
In-Reply-To: <1547555719-13541-1-git-send-email-camelia.groza@nxp.com>
On Tue, Jan 15, 2019 at 02:35:19PM +0200, Camelia Groza wrote:
> Since phy driver features became a link_mode bitmap, phy drivers that
> don't have a list of features configured will cause the kernel to crash
> when probed.
>
> Prevent the phy driver from registering if the features field is missing.
>
> Fixes: 719655a14971 ("net: phy: Replace phy driver features u32 with link_mode bitmap")
> Reported-by: Scott Wood <oss@buserror.net>
> Signed-off-by: Camelia Groza <camelia.groza@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-01-15 14:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 12:35 [PATCH net] net: phy: phy driver features are mandatory Camelia Groza
2019-01-15 14:05 ` Andrew Lunn [this message]
2019-01-16 8:58 ` [net] b8154ef682: WARNING:at_drivers/net/phy/phy_device.c:#phy_driver_register kernel test robot
2019-01-16 8:58 ` kernel test robot
2019-01-16 13:40 ` Andrew Lunn
2019-01-16 13:40 ` Andrew Lunn
2019-01-17 7:36 ` Camelia Alexandra Groza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190115140509.GH19687@lunn.ch \
--to=andrew@lunn.ch \
--cc=camelia.groza@nxp.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss@buserror.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.