From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ayan Halder Subject: Re: [PATCH] [RFC] drm_hwcomposer: Add support for Arm Framebuffer Compression (AFBC) modifiers. Date: Tue, 15 Jan 2019 14:49:43 +0000 Message-ID: <20190115144942.GA16738@arm.com> References: <1547479696-14376-1-git-send-email-ayan.halder@arm.com> <20190115120547.GL10517@phenom.ffwll.local> <20190115122418.GS20661@e110455-lin.cambridge.arm.com> <20190115132703.GT20661@e110455-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0616.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1f::616]) by gabe.freedesktop.org (Postfix) with ESMTPS id BB6006E661 for ; Tue, 15 Jan 2019 14:49:47 +0000 (UTC) In-Reply-To: Content-Language: en-US Content-ID: <53C4E8592B91D9498EC904259EBA28D3@eurprd08.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: "seanpaul@google.com" , Liviu Dudau , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "malidp@foss.arm.com" , nd List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKYW4gMTUsIDIwMTkgYXQgMDI6Mjk6MTlQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBUdWUsIEphbiAxNSwgMjAxOSBhdCAyOjI3IFBNIExpdml1IER1ZGF1IDxMaXZp dS5EdWRhdUBhcm0uY29tPiB3cm90ZToKPiA+Cj4gPiBPbiBUdWUsIEphbiAxNSwgMjAxOSBhdCAw MTozODoxOVBNICswMTAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ID4gPiBPbiBUdWUsIEphbiAx NSwgMjAxOSBhdCAxOjI0IFBNIExpdml1IER1ZGF1IDxMaXZpdS5EdWRhdUBhcm0uY29tPiB3cm90 ZToKPiA+ID4gPgo+ID4gPiA+IE9uIFR1ZSwgSmFuIDE1LCAyMDE5IGF0IDAxOjA1OjQ3UE0gKzAx MDAsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiA+ID4gPiBPbiBNb24sIEphbiAxNCwgMjAxOSBh dCAwMzoyODoyN1BNICswMDAwLCBBeWFuIEhhbGRlciB3cm90ZToKPiA+ID4gPiA+ID4gT25lIG5l ZWRzIHRvIHRyYW5zbGF0ZSB0aGUgR3JhbGxvYyBidWZmZXIgZmxhZ3MgZm9yIEFGQkMgKGVnCj4g PiA+ID4gPiA+IE1BTElfR1JBTExPQ19JTlRGTVRfQUZCQ19CQVNJQykgdG8gdGhlIGNvcnJlc3Bv bmRpbmcgbGludXgga2VybmVsIGRybSBtb2RpZmllcnMuCj4gPiA+ID4gPiA+IFRoaXMgZ2V0cyBw YXNzZWQgdG8gbGliZHJtIHZpYSBkcm1Nb2RlQWRkRkIyV2l0aE1vZGlmaWVycy4KPiA+ID4gPiA+ ID4KPiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogQXlhbiBLdW1hciBIYWxkZXIgPGF5YW4uaGFs ZGVyQGFybS5jb20+Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IC8tLSBOb3RlIGZvciByZXZpZXdl cgo+ID4gPiA+ID4gPiBJIHdhcyBhYmxlIHRvIGdldCB0aGlzIHdvcmtpbmcgZm9yIEFuZHJvaWQg UCBvbiBKdW5vIHdpdGggTWFsaSBEUDY1MCBhbmQgTWFsaQo+ID4gPiA+ID4gPiBUODYwIGdwdSh3 aXRoIHNvbWUgYWRkaXRpb25hbCBoYWNrcykuIEkgaGF2ZSBub3QgeWV0IHZhbGlkYXRlZCB0aGlz IGhpa2V5OTYwLgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBJIGhhdmUgdXNlZCB0aGUgZm9sbG93 aW5nIGNvbXBvbmVudHM6LQo+ID4gPiA+ID4gPiAxLiBHcmFsbG9jIChmcm9tIGh0dHBzOi8vYW5k cm9pZC5nb29nbGVzb3VyY2UuY29tL2RldmljZS9saW5hcm8vaGlrZXkvKy9tYXN0ZXIvZ3JhbGxv Yzk2MCkKPiA+ID4gPiA+ID4gICAtIEJ1aWx0IHdpdGggTUFMSV9NTVNTPTEKPiA+ID4gPiA+ID4g Mi4gTGliZHJtIChmcm9tIGdpdDovL2Fub25naXQuZnJlZWRlc2t0b3Aub3JnL21lc2EvZHJtKQo+ ID4gPiA+ID4gPiAgIC0gWW91IHdvdWxkIG5lZWQgZHJtX2ZvdXJjYy5oIGFuZCBncmFsbG9jX2hh bmRsZS5oCj4gPiA+ID4gPiA+IC0tLwo+ID4gPiA+ID4KPiA+ID4gPiA+IEkgdGhvdWdodCBkcm1f aHdjb21wb3NlciBoYXMgc3dpdGNoZWQgb3ZlciB0byBnaXRsYWIgbWVyZ2UgcmVxdWVzdHM/Cj4g PiA+ID4gPiBSRUFETUUgYXQgbGVhc3Qgc2F5cyBzbzoKPiA+ID4gPiA+Cj4gPiA+ID4gPiBodHRw czovL2dpdGxhYi5mcmVlZGVza3RvcC5vcmcvZHJtLWh3Y29tcG9zZXIvZHJtLWh3Y29tcG9zZXIK PiA+ID4gPgo+ID4gPiA+IFNvIGFyZSB3ZSB0byBzZW5kIHB1bGwgcmVxdWVzdHMgZm9yIFJGQ3Mg YXMgd2VsbD8KPiA+ID4KPiA+ID4gSG0sIG5vdCBzdXJlIHlvdSBzaG91bGQgc3R1ZmYgUkZDIG1h dGVyaWFsIGludG8geW91ciBsaW51eC1uZXh0Cj4gPiA+IGJyYW5jaGVzLiBJIHRob3VnaHQgdGhh dCdzIG9ubHkgZm9yIHBhdGNoZXMgd2hpY2ggYnkgYWxsIGludGVudHMgYXJlCj4gPiA+IHJlYWR5 IGZvciB0aGUgbmV4dCBtZXJnZSB3aW5kb3csIGkuZS4gcmV2aWV3ZWQmdGVzdGVkIGFuZCBhbGwg dGhhdC4KPiA+ID4gTm90IGZvciBpbi1mbGlnaHQgc3R1ZmYgc3RpbGwgdW5kZXIgZGlzY3Vzc2lv bi4KPiA+Cj4gPiBJIHRoaW5rIHlvdSdyZSBjb25mdXNpbmcgdGhlIGRvY3VtZW50YXRpb24gcGF0 Y2ggd2l0aCB0aGUgZHJtX2h3Y29tcG9zZXIgb25lICh0aGlzIG9uZSkuCj4gCj4gSW5kZWVkLiBB bmQgeWVzIGV2ZXJ5dGhpbmcgZXZlbiBSRkMuIEdpdGxhYiBldmVuIGhhcyBzb21lIHNwZWNpYWwK PiBzdXBwb3J0IGZvciB3b3JrIGluIHByb2dyZXNzLCBqdXN0IHN0YXJ0IHlvdXIgcHVsbCByZXF1 ZXN0IHN1bW1hcnkKPiB3aXRoIFdJUC4KPiAtRGFuaWVsCj4KVGhhbmtzLCBJIGhhdmUgY3JlYXRl ZCBhIG1lcmdlIHJlcXVlc3Qgbm93LiBJIHdhc25vdCBzdXJlIGluaXRpYWxseQpob3cgdGhlIHJl dmlldyBwcm9jZXNzIHdvcmtlZCBmb3IgZ2l0bGFiIHByb2plY3RzLiAKPiA+Cj4gPiBCZXN0IHJl Z2FyZHMsCj4gPiBMaXZpdQo+ID4KPiA+ID4gLURhbmllbAo+ID4gPgo+ID4gPgo+ID4gPiA+IEJl c3QgcmVnYXJkcywKPiA+ID4gPiBMaXZpdQo+ID4gPiA+Cj4gPiA+ID4gPgo+ID4gPiA+ID4gQ2hl ZXJzLCBEYW5pZWwKPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiAgcGxhdGZv cm1kcm1nZW5lcmljLmNwcCB8IDQyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKwo+ID4gPiA+ID4gPiAgcGxhdGZvcm1kcm1nZW5lcmljLmggICB8ICAyICsrCj4gPiA+ ID4gPiA+ICBwbGF0Zm9ybWhpc2kuY3BwICAgICAgIHwgMTQgKysrKysrKysrKysrLS0KPiA+ID4g PiA+ID4gIDMgZmlsZXMgY2hhbmdlZCwgNTYgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK PiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gZGlmZiAtLWdpdCBhL3BsYXRmb3JtZHJtZ2VuZXJpYy5j cHAgYi9wbGF0Zm9ybWRybWdlbmVyaWMuY3BwCj4gPiA+ID4gPiA+IGluZGV4IDUwM2MwNGEuLmE1 MjAyMjQgMTAwNjQ0Cj4gPiA+ID4gPiA+IC0tLSBhL3BsYXRmb3JtZHJtZ2VuZXJpYy5jcHAKPiA+ ID4gPiA+ID4gKysrIGIvcGxhdGZvcm1kcm1nZW5lcmljLmNwcAo+ID4gPiA+ID4gPiBAQCAtMTgs NiArMTgsNyBAQAo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiAgI2luY2x1ZGUgInBsYXRmb3JtZHJt Z2VuZXJpYy5oIgo+ID4gPiA+ID4gPiAgI2luY2x1ZGUgImRybWRldmljZS5oIgo+ID4gPiA+ID4g PiArI2luY2x1ZGUgIm1hbGlfZ3JhbGxvY19mb3JtYXRzLmgiCj4gPiA+ID4gPiA+ICAjaW5jbHVk ZSAicGxhdGZvcm0uaCIKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gICNpbmNsdWRlIDxkcm0vZHJt X2ZvdXJjYy5oPgo+ID4gPiA+ID4gPiBAQCAtODMsNiArODQsMzEgQEAgdWludDMyX3QgRHJtR2Vu ZXJpY0ltcG9ydGVyOjpDb252ZXJ0SGFsRm9ybWF0VG9Ecm0odWludDMyX3QgaGFsX2Zvcm1hdCkg ewo+ID4gPiA+ID4gPiAgICB9Cj4gPiA+ID4gPiA+ICB9Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ ICt1aW50NjRfdCBEcm1HZW5lcmljSW1wb3J0ZXI6OkNvbnZlcnRHcmFsbG9jRm9ybWF0VG9Ecm1N b2RpZmllcnModWludDY0X3QgZmxhZ3MsCj4gPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYm9vbCBpc19yZ2Ip IHsKPiA+ID4gPiA+ID4gKyAgdWludDY0X3QgZmVhdHVyZXMgPSAwOwo+ID4gPiA+ID4gPiArCj4g PiA+ID4gPiA+ICsgIGlmIChmbGFncyAmIE1BTElfR1JBTExPQ19JTlRGTVRfQUZCQ19CQVNJQykK PiA+ID4gPiA+ID4gKyAgICBmZWF0dXJlcyB8PSBBRkJDX0ZPUk1BVF9NT0RfQkxPQ0tfU0laRV8x NngxNjsKPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiArICBpZiAoaXNfcmdiKQo+ID4gPiA+ID4g PiArICAgIGZlYXR1cmVzIHw9IEFGQkNfRk9STUFUX01PRF9ZVFI7Cj4gPiA+ID4gPiA+ICsKPiA+ ID4gPiA+ID4gKyAgaWYgKGZsYWdzICYgTUFMSV9HUkFMTE9DX0lOVEZNVF9BRkJDX1NQTElUQkxL KQo+ID4gPiA+ID4gPiArICAgIGZlYXR1cmVzIHw9IChBRkJDX0ZPUk1BVF9NT0RfU1BMSVQgfCBB RkJDX0ZPUk1BVF9NT0RfU1BBUlNFKTsKPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiArICBpZiAo ZmxhZ3MgJiBNQUxJX0dSQUxMT0NfSU5URk1UX0FGQkNfV0lERUJMSykKPiA+ID4gPiA+ID4gKyAg ICBmZWF0dXJlcyB8PSBBRkJDX0ZPUk1BVF9NT0RfQkxPQ0tfU0laRV8zMng4Owo+ID4gPiA+ID4g PiArCj4gPiA+ID4gPiA+ICsgIGlmIChmbGFncyAmIE1BTElfR1JBTExPQ19JTlRGTVRfQUZCQ19U SUxFRF9IRUFERVJTKQo+ID4gPiA+ID4gPiArICAgIGZlYXR1cmVzIHw9IEFGQkNfRk9STUFUX01P RF9USUxFRDsKPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiArICBpZiAoZmVhdHVyZXMpCj4gPiA+ ID4gPiA+ICsgICAgcmV0dXJuIERSTV9GT1JNQVRfTU9EX0FSTV9BRkJDKGZlYXR1cmVzKTsKPiA+ ID4gPiA+ID4gKyAgZWxzZQo+ID4gPiA+ID4gPiArICAgIHJldHVybiAwOwo+ID4gPiA+ID4gPiAr fQo+ID4gPiA+ID4gPiArCj4gPiA+ID4gPiA+ICB1aW50MzJfdCBEcm1HZW5lcmljSW1wb3J0ZXI6 OkRybUZvcm1hdFRvQml0c1BlclBpeGVsKHVpbnQzMl90IGRybV9mb3JtYXQpIHsKPiA+ID4gPiA+ ID4gICAgc3dpdGNoIChkcm1fZm9ybWF0KSB7Cj4gPiA+ID4gPiA+ICAgICAgY2FzZSBEUk1fRk9S TUFUX0FSR0I4ODg4Ogo+ID4gPiA+ID4gPiBAQCAtMTAxLDYgKzEyNywyMiBAQCB1aW50MzJfdCBE cm1HZW5lcmljSW1wb3J0ZXI6OkRybUZvcm1hdFRvQml0c1BlclBpeGVsKHVpbnQzMl90IGRybV9m b3JtYXQpIHsKPiA+ID4gPiA+ID4gICAgfQo+ID4gPiA+ID4gPiAgfQo+ID4gPiA+ID4gPgo+ID4g PiA+ID4gPiArYm9vbCBEcm1HZW5lcmljSW1wb3J0ZXI6OklzRHJtRm9ybWF0UmdiKHVpbnQzMl90 IGRybV9mb3JtYXQpIHsKPiA+ID4gPiA+ID4gKyAgc3dpdGNoIChkcm1fZm9ybWF0KSB7Cj4gPiA+ ID4gPiA+ICsgICAgY2FzZSBEUk1fRk9STUFUX0FSR0I4ODg4Ogo+ID4gPiA+ID4gPiArICAgIGNh c2UgRFJNX0ZPUk1BVF9YQkdSODg4ODoKPiA+ID4gPiA+ID4gKyAgICBjYXNlIERSTV9GT1JNQVRf QUJHUjg4ODg6Cj4gPiA+ID4gPiA+ICsgICAgY2FzZSBEUk1fRk9STUFUX0JHUjg4ODoKPiA+ID4g PiA+ID4gKyAgICBjYXNlIERSTV9GT1JNQVRfQkdSNTY1Ogo+ID4gPiA+ID4gPiArICAgICAgcmV0 dXJuIHRydWU7Cj4gPiA+ID4gPiA+ICsgICAgY2FzZSBEUk1fRk9STUFUX1lWVTQyMDoKPiA+ID4g PiA+ID4gKyAgICAgIHJldHVybiBmYWxzZTsKPiA+ID4gPiA+ID4gKyAgICBkZWZhdWx0Ogo+ID4g PiA+ID4gPiArICAgICAgQUxPR0UoIlVuc3VwcG9ydGVkIGZvcm1hdCAldSBhc3N1bWluZyByZ2I/ IiwgZHJtX2Zvcm1hdCk7Cj4gPiA+ID4gPiA+ICsgICAgICByZXR1cm4gdHJ1ZTsKPiA+ID4gPiA+ ID4gKyAgfQo+ID4gPiA+ID4gPiArfQo+ID4gPiA+ID4gPiArCj4gPiA+ID4gPiA+ICBpbnQgRHJt R2VuZXJpY0ltcG9ydGVyOjpJbXBvcnRCdWZmZXIoYnVmZmVyX2hhbmRsZV90IGhhbmRsZSwgaHdj X2RybV9ib190ICpibykgewo+ID4gPiA+ID4gPiAgICBncmFsbG9jX2hhbmRsZV90ICpncl9oYW5k bGUgPSBncmFsbG9jX2hhbmRsZShoYW5kbGUpOwo+ID4gPiA+ID4gPiAgICBpZiAoIWdyX2hhbmRs ZSkKPiA+ID4gPiA+ID4gZGlmZiAtLWdpdCBhL3BsYXRmb3JtZHJtZ2VuZXJpYy5oIGIvcGxhdGZv cm1kcm1nZW5lcmljLmgKPiA+ID4gPiA+ID4gaW5kZXggMjMzYmE1NS4uNDNjYjYxOCAxMDA2NDQK PiA+ID4gPiA+ID4gLS0tIGEvcGxhdGZvcm1kcm1nZW5lcmljLmgKPiA+ID4gPiA+ID4gKysrIGIv cGxhdGZvcm1kcm1nZW5lcmljLmgKPiA+ID4gPiA+ID4gQEAgLTM2LDYgKzM2LDggQEAgY2xhc3Mg RHJtR2VuZXJpY0ltcG9ydGVyIDogcHVibGljIEltcG9ydGVyIHsKPiA+ID4gPiA+ID4gICAgYm9v bCBDYW5JbXBvcnRCdWZmZXIoYnVmZmVyX2hhbmRsZV90IGhhbmRsZSkgb3ZlcnJpZGU7Cj4gPiA+ ID4gPiA+Cj4gPiA+ID4gPiA+ICAgIHVpbnQzMl90IENvbnZlcnRIYWxGb3JtYXRUb0RybSh1aW50 MzJfdCBoYWxfZm9ybWF0KTsKPiA+ID4gPiA+ID4gKyAgdWludDY0X3QgQ29udmVydEdyYWxsb2NG b3JtYXRUb0RybU1vZGlmaWVycyh1aW50NjRfdCBmbGFncywgYm9vbCBpc19yZ2IpOwo+ID4gPiA+ ID4gPiArICBib29sIElzRHJtRm9ybWF0UmdiKHVpbnQzMl90IGRybV9mb3JtYXQpOwo+ID4gPiA+ ID4gPiAgICB1aW50MzJfdCBEcm1Gb3JtYXRUb0JpdHNQZXJQaXhlbCh1aW50MzJfdCBkcm1fZm9y bWF0KTsKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gICBwcml2YXRlOgo+ID4gPiA+ID4gPiBkaWZm IC0tZ2l0IGEvcGxhdGZvcm1oaXNpLmNwcCBiL3BsYXRmb3JtaGlzaS5jcHAKPiA+ID4gPiA+ID4g aW5kZXggNzZmZTFlNy4uMWNiN2UyYyAxMDA2NDQKPiA+ID4gPiA+ID4gLS0tIGEvcGxhdGZvcm1o aXNpLmNwcAo+ID4gPiA+ID4gPiArKysgYi9wbGF0Zm9ybWhpc2kuY3BwCj4gPiA+ID4gPiA+IEBA IC03MSw2ICs3MSw5IEBAIGludCBIaXNpSW1wb3J0ZXI6OkluaXQoKSB7Cj4gPiA+ID4gPiA+ICB9 Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ICBpbnQgSGlzaUltcG9ydGVyOjpJbXBvcnRCdWZmZXIo YnVmZmVyX2hhbmRsZV90IGhhbmRsZSwgaHdjX2RybV9ib190ICpibykgewo+ID4gPiA+ID4gPiAr ICBib29sIGlzX3JnYjsKPiA+ID4gPiA+ID4gKyAgdWludDY0X3QgbW9kaWZpZXJzWzRdID0gezB9 Owo+ID4gPiA+ID4gPiArCj4gPiA+ID4gPiA+ICAgIG1lbXNldChibywgMCwgc2l6ZW9mKGh3Y19k cm1fYm9fdCkpOwo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiAgICBwcml2YXRlX2hhbmRsZV90IGNv bnN0ICpobmQgPSByZWludGVycHJldF9jYXN0PHByaXZhdGVfaGFuZGxlX3QgY29uc3QgKj4oCj4g PiA+ID4gPiA+IEBAIC05NCw2ICs5NywxMCBAQCBpbnQgSGlzaUltcG9ydGVyOjpJbXBvcnRCdWZm ZXIoYnVmZmVyX2hhbmRsZV90IGhhbmRsZSwgaHdjX2RybV9ib190ICpibykgewo+ID4gPiA+ID4g PiAgICBpZiAoZm10IDwgMCkKPiA+ID4gPiA+ID4gICAgICByZXR1cm4gZm10Owo+ID4gPiA+ID4g Pgo+ID4gPiA+ID4gPiArICBpc19yZ2IgPSBJc0RybUZvcm1hdFJnYihmbXQpOwo+ID4gPiA+ID4g PiArICBtb2RpZmllcnNbMF0gPSBDb252ZXJ0R3JhbGxvY0Zvcm1hdFRvRHJtTW9kaWZpZXJzKGhu ZC0+aW50ZXJuYWxfZm9ybWF0LAo+ID4gPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlzX3JnYik7Cj4gPiA+ID4gPiA+ICsKPiA+ID4g PiA+ID4gICAgYm8tPndpZHRoID0gaG5kLT53aWR0aDsKPiA+ID4gPiA+ID4gICAgYm8tPmhlaWdo dCA9IGhuZC0+aGVpZ2h0Owo+ID4gPiA+ID4gPiAgICBiby0+aGFsX2Zvcm1hdCA9IGhuZC0+cmVx X2Zvcm1hdDsKPiA+ID4gPiA+ID4gQEAgLTEyOSw4ICsxMzYsMTEgQEAgaW50IEhpc2lJbXBvcnRl cjo6SW1wb3J0QnVmZmVyKGJ1ZmZlcl9oYW5kbGVfdCBoYW5kbGUsIGh3Y19kcm1fYm9fdCAqYm8p IHsKPiA+ID4gPiA+ID4gICAgICAgIGJyZWFrOwo+ID4gPiA+ID4gPiAgICB9Cj4gPiA+ID4gPiA+ Cj4gPiA+ID4gPiA+IC0gIHJldCA9IGRybU1vZGVBZGRGQjIoZHJtXy0+ZmQoKSwgYm8tPndpZHRo LCBiby0+aGVpZ2h0LCBiby0+Zm9ybWF0LAo+ID4gPiA+ID4gPiAtICAgICAgICAgICAgICAgICAg ICAgIGJvLT5nZW1faGFuZGxlcywgYm8tPnBpdGNoZXMsIGJvLT5vZmZzZXRzLCAmYm8tPmZiX2lk LCAwKTsKPiA+ID4gPiA+ID4gKyAgcmV0ID0gZHJtTW9kZUFkZEZCMldpdGhNb2RpZmllcnMoZHJt Xy0+ZmQoKSwgYm8tPndpZHRoLCBiby0+aGVpZ2h0LAo+ID4gPiA+ID4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBiby0+Zm9ybWF0LCBiby0+Z2VtX2hhbmRsZXMsIGJvLT5w aXRjaGVzLAo+ID4gPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBi by0+b2Zmc2V0cywgbW9kaWZpZXJzLCAmYm8tPmZiX2lkLAo+ID4gPiA+ID4gPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBtb2RpZmllcnNbMF0gPyBEUk1fTU9ERV9GQl9NT0RJ RklFUlMgOiAwKTsKPiA+ID4gPiA+ID4gKwo+ID4gPiA+ID4gPiAgICBpZiAocmV0KSB7Cj4gPiA+ ID4gPiA+ICAgICAgQUxPR0UoImNvdWxkIG5vdCBjcmVhdGUgZHJtIGZiICVkIiwgcmV0KTsKPiA+ ID4gPiA+ID4gICAgICByZXR1cm4gcmV0Owo+ID4gPiA+ID4gPiAtLQo+ID4gPiA+ID4gPiAyLjcu NAo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+ID4gPiA+ID4gPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gPiA+ ID4gPiA+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+ID4gPiA+ID4gaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKPiA+ID4g PiA+Cj4gPiA+ID4gPiAtLQo+ID4gPiA+ID4gRGFuaWVsIFZldHRlcgo+ID4gPiA+ID4gU29mdHdh cmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCj4gPiA+ID4gPiBodHRwOi8vYmxvZy5mZnds bC5jaAo+ID4gPiA+Cj4gPiA+ID4gLS0KPiA+ID4gPiA9PT09PT09PT09PT09PT09PT09PQo+ID4g PiA+IHwgSSB3b3VsZCBsaWtlIHRvIHwKPiA+ID4gPiB8IGZpeCB0aGUgd29ybGQsICB8Cj4gPiA+ ID4gfCBidXQgdGhleSdyZSBub3QgfAo+ID4gPiA+IHwgZ2l2aW5nIG1lIHRoZSAgIHwKPiA+ID4g PiAgXCBzb3VyY2UgY29kZSEgIC8KPiA+ID4gPiAgIC0tLS0tLS0tLS0tLS0tLQo+ID4gPiA+ICAg ICA/P1xfKD8/PylfLz8/Cj4gPiA+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiA+ID4gPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gPiA+ID4gZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCj4gPiA+Cj4gPiA+Cj4gPiA+Cj4g PiA+IC0tCj4gPiA+IERhbmllbCBWZXR0ZXIKPiA+ID4gU29mdHdhcmUgRW5naW5lZXIsIEludGVs IENvcnBvcmF0aW9uCj4gPiA+ICs0MSAoMCkgNzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3 bGwuY2gKPiA+Cj4gPiAtLQo+ID4gPT09PT09PT09PT09PT09PT09PT0KPiA+IHwgSSB3b3VsZCBs aWtlIHRvIHwKPiA+IHwgZml4IHRoZSB3b3JsZCwgIHwKPiA+IHwgYnV0IHRoZXkncmUgbm90IHwK PiA+IHwgZ2l2aW5nIG1lIHRoZSAgIHwKPiA+ICBcIHNvdXJjZSBjb2RlISAgLwo+ID4gICAtLS0t LS0tLS0tLS0tLS0KPiA+ICAgICA/P1xfKD8/PylfLz8/Cj4gCj4gCj4gCj4gLS0gCj4gRGFuaWVs IFZldHRlcgo+IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+ICs0MSAoMCkg NzkgMzY1IDU3IDQ4IC0gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F24C43387 for ; Tue, 15 Jan 2019 14:49:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1C4D20657 for ; Tue, 15 Jan 2019 14:49:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="YoskICuR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730497AbfAOOtu (ORCPT ); Tue, 15 Jan 2019 09:49:50 -0500 Received: from mail-eopbgr140074.outbound.protection.outlook.com ([40.107.14.74]:4655 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728619AbfAOOtt (ORCPT ); Tue, 15 Jan 2019 09:49:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YS1fbPEplmOiVKd/QJ7ESZqFxlKZtvNdrorAhL6nAQE=; b=YoskICuRY/o6BIb2mUP4DsxF+pcMc0CGZDRFjuNEpStaqXa3pVom0fEdnG5CE1mKVuB9bC5xvhrlu8uYr0NAGfNqgAr3TVouV6j+MHPgZMZixoTuyRElG/flIjCjDbDcCfBMQFy7bTplgAnPCc8m5poB2wmD5tVfHkwK1Fl8XHw= Received: from AM0PR08MB3891.eurprd08.prod.outlook.com (20.178.82.147) by AM0PR08MB4226.eurprd08.prod.outlook.com (20.179.32.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.24; Tue, 15 Jan 2019 14:49:43 +0000 Received: from AM0PR08MB3891.eurprd08.prod.outlook.com ([fe80::39a3:457f:3d5e:84ff]) by AM0PR08MB3891.eurprd08.prod.outlook.com ([fe80::39a3:457f:3d5e:84ff%3]) with mapi id 15.20.1516.019; Tue, 15 Jan 2019 14:49:43 +0000 From: Ayan Halder To: Daniel Vetter CC: Liviu Dudau , Brian Starkey , "john.stultz@linaro.org" , "seanpaul@google.com" , "malidp@foss.arm.com" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , nd Subject: Re: [PATCH] [RFC] drm_hwcomposer: Add support for Arm Framebuffer Compression (AFBC) modifiers. Thread-Topic: [PATCH] [RFC] drm_hwcomposer: Add support for Arm Framebuffer Compression (AFBC) modifiers. Thread-Index: AQHUrB3LrXJMP7k9bUyTQbg+n7XNXqWwPRCAgAAFLoCAAAPpgIAADZ8AgAAAoYCAABZ2gA== Date: Tue, 15 Jan 2019 14:49:43 +0000 Message-ID: <20190115144942.GA16738@arm.com> References: <1547479696-14376-1-git-send-email-ayan.halder@arm.com> <20190115120547.GL10517@phenom.ffwll.local> <20190115122418.GS20661@e110455-lin.cambridge.arm.com> <20190115132703.GT20661@e110455-lin.cambridge.arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0085.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::25) To AM0PR08MB3891.eurprd08.prod.outlook.com (2603:10a6:208:109::19) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Ayan.Halder@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [217.140.106.50] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM0PR08MB4226;6:PJoGmj7W00dPs5LKEnNKG7AdBjV3zFPztc1F6M/kQLksYH5P4HB7D2o5UVIMacfE8jfILUK5pG3G2FUgNxu8qN9Zo5E5qImjEAUL9mwfpNk/GaV8MlISkwr8pmRZ073xGE4vTDwEl7NkVeQ2ntkFziEtYoaKxEMbqGt6hi/yt2bZdSjFtPRHvw7LIDMmH50SdOoGKoIPjl6lU1ADlevKendJTZls5DmeSeHH7Tn2iXhOnubhy+ctNNjOG8zyyzVVbYvwHTAfJDYFFDNDfGRRkAdlhy2jaRgREFFx9EFfZ7fDNa7a1kEzU9n3UhXMFKO+069IVFXPys5UHAriQCzwpybuwd9hBtMd2Fx2q6xdkd7Mk7HO2RRzGzeI3DrrUq1zreeEUybZzh8R5clKDW0znDcvVeaSxS79lEYrRb+BPVjJAxziw/lXCZrkgsUyipmF3dPmYd3qydsyjIK4GoiqdA==;5:Yjx1gw5soKzN3JKUjfhV+Q6l7vCWNt4AND6BanpE9tD4e/hG+Ptrp6yMmtCDeTGG0CPql7MUbUxQU9JGxtna2EG2GacjsyipL7JMQtndzlp2jVC5TLH9H8ziSuk1Q6dxAUCwkBHBEFNI9JJNi/4BhYA6KEKxR5uURf6TUO7UbGC0I6K4gDiabzEVlO0nDqiAc1HsDbJvzf0BHZU7zqeSfQ==;7:yP12a+4j5spbQ4jASsS6swqSdqVIZIB2dxofehMrBrBXx59U047I4bznO2IqxIilaw24R/j3v5nA3Svzd4faamtdq2s5wwlV5rIx6+iTaWtYtRsgcPDw+TBtr9U8iOog4a4SjZHQScAYiRIGjDO6sQ== x-ms-office365-filtering-correlation-id: 9a50bd0a-1771-4534-75e8-08d67af8af82 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM0PR08MB4226; x-ms-traffictypediagnostic: AM0PR08MB4226: nodisclaimer: True x-microsoft-antispam-prvs: x-forefront-prvs: 0918748D70 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(136003)(39860400002)(396003)(376002)(366004)(189003)(199004)(7736002)(478600001)(966005)(72206003)(71200400001)(71190400001)(587094005)(81156014)(52116002)(97736004)(26005)(316002)(54906003)(6486002)(105586002)(14454004)(8676002)(68736007)(1076003)(186003)(33656002)(6916009)(44832011)(66066001)(86362001)(19627235002)(256004)(305945005)(14444005)(8936002)(6512007)(2906002)(476003)(6306002)(53936002)(486006)(53386004)(81166006)(36756003)(3846002)(4326008)(93886005)(99286004)(6246003)(53546011)(6506007)(386003)(5660300001)(229853002)(446003)(102836004)(6436002)(76176011)(25786009)(2616005)(106356001)(11346002)(6116002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR08MB4226;H:AM0PR08MB3891.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: zqKk/invXyiVSFd7tWEtzyNAIdXnwNTGmSHcntq+zxHqP4tTrk9/rapC5hE5qlIZKSMc3awKDrTowLz93/ne8E3+/IRYAFz7JdtGXFaf6sfUo3Z4iHS/8w4uQ4i/EXDg6PYhYknQtMc6Kn6WsUyjkhY87AgC1VroGhNGwEy4pHt56ZVTKl5Mbp526l3hZUEK9AmfhQynCROcyCFhWM/qPnmpJ4EA9+wZPYg+zMPribDOZUyEqo7X6fVd3E9wGTKjQm5mEFq0tWpxP1xrHx/yynSu6dH0k8jD9iUUYsZqfGRiWIpkaydjVB9RAP3eOJPZgkhbAZn1sP1MedxVyQkhfWf16UyR68gl+UZq6ghV3JBZmL06CgaqxePRcgE/rlx9iVFnXUHWCIVxsxCZkcLchDGsJpCSEpKLesSN2PvbEO4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <53C4E8592B91D9498EC904259EBA28D3@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a50bd0a-1771-4534-75e8-08d67af8af82 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2019 14:49:43.4224 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4226 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 15, 2019 at 02:29:19PM +0100, Daniel Vetter wrote: > On Tue, Jan 15, 2019 at 2:27 PM Liviu Dudau wrote: > > > > On Tue, Jan 15, 2019 at 01:38:19PM +0100, Daniel Vetter wrote: > > > On Tue, Jan 15, 2019 at 1:24 PM Liviu Dudau wro= te: > > > > > > > > On Tue, Jan 15, 2019 at 01:05:47PM +0100, Daniel Vetter wrote: > > > > > On Mon, Jan 14, 2019 at 03:28:27PM +0000, Ayan Halder wrote: > > > > > > One needs to translate the Gralloc buffer flags for AFBC (eg > > > > > > MALI_GRALLOC_INTFMT_AFBC_BASIC) to the corresponding linux kern= el drm modifiers. > > > > > > This gets passed to libdrm via drmModeAddFB2WithModifiers. > > > > > > > > > > > > Signed-off-by: Ayan Kumar Halder > > > > > > > > > > > > /-- Note for reviewer > > > > > > I was able to get this working for Android P on Juno with Mali = DP650 and Mali > > > > > > T860 gpu(with some additional hacks). I have not yet validated = this hikey960. > > > > > > > > > > > > I have used the following components:- > > > > > > 1. Gralloc (from https://android.googlesource.com/device/linaro= /hikey/+/master/gralloc960) > > > > > > - Built with MALI_MMSS=3D1 > > > > > > 2. Libdrm (from git://anongit.freedesktop.org/mesa/drm) > > > > > > - You would need drm_fourcc.h and gralloc_handle.h > > > > > > --/ > > > > > > > > > > I thought drm_hwcomposer has switched over to gitlab merge reques= ts? > > > > > README at least says so: > > > > > > > > > > https://gitlab.freedesktop.org/drm-hwcomposer/drm-hwcomposer > > > > > > > > So are we to send pull requests for RFCs as well? > > > > > > Hm, not sure you should stuff RFC material into your linux-next > > > branches. I thought that's only for patches which by all intents are > > > ready for the next merge window, i.e. reviewed&tested and all that. > > > Not for in-flight stuff still under discussion. > > > > I think you're confusing the documentation patch with the drm_hwcompose= r one (this one). >=20 > Indeed. And yes everything even RFC. Gitlab even has some special > support for work in progress, just start your pull request summary > with WIP. > -Daniel > Thanks, I have created a merge request now. I wasnot sure initially how the review process worked for gitlab projects.=20 > > > > Best regards, > > Liviu > > > > > -Daniel > > > > > > > > > > Best regards, > > > > Liviu > > > > > > > > > > > > > > Cheers, Daniel > > > > > > > > > > > --- > > > > > > platformdrmgeneric.cpp | 42 ++++++++++++++++++++++++++++++++++= ++++++++ > > > > > > platformdrmgeneric.h | 2 ++ > > > > > > platformhisi.cpp | 14 ++++++++++++-- > > > > > > 3 files changed, 56 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/platformdrmgeneric.cpp b/platformdrmgeneric.cpp > > > > > > index 503c04a..a520224 100644 > > > > > > --- a/platformdrmgeneric.cpp > > > > > > +++ b/platformdrmgeneric.cpp > > > > > > @@ -18,6 +18,7 @@ > > > > > > > > > > > > #include "platformdrmgeneric.h" > > > > > > #include "drmdevice.h" > > > > > > +#include "mali_gralloc_formats.h" > > > > > > #include "platform.h" > > > > > > > > > > > > #include > > > > > > @@ -83,6 +84,31 @@ uint32_t DrmGenericImporter::ConvertHalForma= tToDrm(uint32_t hal_format) { > > > > > > } > > > > > > } > > > > > > > > > > > > +uint64_t DrmGenericImporter::ConvertGrallocFormatToDrmModifier= s(uint64_t flags, > > > > > > + = bool is_rgb) { > > > > > > + uint64_t features =3D 0; > > > > > > + > > > > > > + if (flags & MALI_GRALLOC_INTFMT_AFBC_BASIC) > > > > > > + features |=3D AFBC_FORMAT_MOD_BLOCK_SIZE_16x16; > > > > > > + > > > > > > + if (is_rgb) > > > > > > + features |=3D AFBC_FORMAT_MOD_YTR; > > > > > > + > > > > > > + if (flags & MALI_GRALLOC_INTFMT_AFBC_SPLITBLK) > > > > > > + features |=3D (AFBC_FORMAT_MOD_SPLIT | AFBC_FORMAT_MOD_SPA= RSE); > > > > > > + > > > > > > + if (flags & MALI_GRALLOC_INTFMT_AFBC_WIDEBLK) > > > > > > + features |=3D AFBC_FORMAT_MOD_BLOCK_SIZE_32x8; > > > > > > + > > > > > > + if (flags & MALI_GRALLOC_INTFMT_AFBC_TILED_HEADERS) > > > > > > + features |=3D AFBC_FORMAT_MOD_TILED; > > > > > > + > > > > > > + if (features) > > > > > > + return DRM_FORMAT_MOD_ARM_AFBC(features); > > > > > > + else > > > > > > + return 0; > > > > > > +} > > > > > > + > > > > > > uint32_t DrmGenericImporter::DrmFormatToBitsPerPixel(uint32_t = drm_format) { > > > > > > switch (drm_format) { > > > > > > case DRM_FORMAT_ARGB8888: > > > > > > @@ -101,6 +127,22 @@ uint32_t DrmGenericImporter::DrmFormatToBi= tsPerPixel(uint32_t drm_format) { > > > > > > } > > > > > > } > > > > > > > > > > > > +bool DrmGenericImporter::IsDrmFormatRgb(uint32_t drm_format) { > > > > > > + switch (drm_format) { > > > > > > + case DRM_FORMAT_ARGB8888: > > > > > > + case DRM_FORMAT_XBGR8888: > > > > > > + case DRM_FORMAT_ABGR8888: > > > > > > + case DRM_FORMAT_BGR888: > > > > > > + case DRM_FORMAT_BGR565: > > > > > > + return true; > > > > > > + case DRM_FORMAT_YVU420: > > > > > > + return false; > > > > > > + default: > > > > > > + ALOGE("Unsupported format %u assuming rgb?", drm_format)= ; > > > > > > + return true; > > > > > > + } > > > > > > +} > > > > > > + > > > > > > int DrmGenericImporter::ImportBuffer(buffer_handle_t handle, h= wc_drm_bo_t *bo) { > > > > > > gralloc_handle_t *gr_handle =3D gralloc_handle(handle); > > > > > > if (!gr_handle) > > > > > > diff --git a/platformdrmgeneric.h b/platformdrmgeneric.h > > > > > > index 233ba55..43cb618 100644 > > > > > > --- a/platformdrmgeneric.h > > > > > > +++ b/platformdrmgeneric.h > > > > > > @@ -36,6 +36,8 @@ class DrmGenericImporter : public Importer { > > > > > > bool CanImportBuffer(buffer_handle_t handle) override; > > > > > > > > > > > > uint32_t ConvertHalFormatToDrm(uint32_t hal_format); > > > > > > + uint64_t ConvertGrallocFormatToDrmModifiers(uint64_t flags, = bool is_rgb); > > > > > > + bool IsDrmFormatRgb(uint32_t drm_format); > > > > > > uint32_t DrmFormatToBitsPerPixel(uint32_t drm_format); > > > > > > > > > > > > private: > > > > > > diff --git a/platformhisi.cpp b/platformhisi.cpp > > > > > > index 76fe1e7..1cb7e2c 100644 > > > > > > --- a/platformhisi.cpp > > > > > > +++ b/platformhisi.cpp > > > > > > @@ -71,6 +71,9 @@ int HisiImporter::Init() { > > > > > > } > > > > > > > > > > > > int HisiImporter::ImportBuffer(buffer_handle_t handle, hwc_drm= _bo_t *bo) { > > > > > > + bool is_rgb; > > > > > > + uint64_t modifiers[4] =3D {0}; > > > > > > + > > > > > > memset(bo, 0, sizeof(hwc_drm_bo_t)); > > > > > > > > > > > > private_handle_t const *hnd =3D reinterpret_cast( > > > > > > @@ -94,6 +97,10 @@ int HisiImporter::ImportBuffer(buffer_handle= _t handle, hwc_drm_bo_t *bo) { > > > > > > if (fmt < 0) > > > > > > return fmt; > > > > > > > > > > > > + is_rgb =3D IsDrmFormatRgb(fmt); > > > > > > + modifiers[0] =3D ConvertGrallocFormatToDrmModifiers(hnd->int= ernal_format, > > > > > > + is_rgb); > > > > > > + > > > > > > bo->width =3D hnd->width; > > > > > > bo->height =3D hnd->height; > > > > > > bo->hal_format =3D hnd->req_format; > > > > > > @@ -129,8 +136,11 @@ int HisiImporter::ImportBuffer(buffer_hand= le_t handle, hwc_drm_bo_t *bo) { > > > > > > break; > > > > > > } > > > > > > > > > > > > - ret =3D drmModeAddFB2(drm_->fd(), bo->width, bo->height, bo-= >format, > > > > > > - bo->gem_handles, bo->pitches, bo->offset= s, &bo->fb_id, 0); > > > > > > + ret =3D drmModeAddFB2WithModifiers(drm_->fd(), bo->width, bo= ->height, > > > > > > + bo->format, bo->gem_handles= , bo->pitches, > > > > > > + bo->offsets, modifiers, &bo= ->fb_id, > > > > > > + modifiers[0] ? DRM_MODE_FB_= MODIFIERS : 0); > > > > > > + > > > > > > if (ret) { > > > > > > ALOGE("could not create drm fb %d", ret); > > > > > > return ret; > > > > > > -- > > > > > > 2.7.4 > > > > > > > > > > > > _______________________________________________ > > > > > > dri-devel mailing list > > > > > > dri-devel@lists.freedesktop.org > > > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > > > > > > > -- > > > > > Daniel Vetter > > > > > Software Engineer, Intel Corporation > > > > > http://blog.ffwll.ch > > > > > > > > -- > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > | I would like to | > > > > | fix the world, | > > > > | but they're not | > > > > | giving me the | > > > > \ source code! / > > > > --------------- > > > > ??\_(???)_/?? > > > > _______________________________________________ > > > > dri-devel mailing list > > > > dri-devel@lists.freedesktop.org > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel > > > > > > > > > > > > -- > > > Daniel Vetter > > > Software Engineer, Intel Corporation > > > +41 (0) 79 365 57 48 - http://blog.ffwll.ch > > > > -- > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > | I would like to | > > | fix the world, | > > | but they're not | > > | giving me the | > > \ source code! / > > --------------- > > ??\_(???)_/?? >=20 >=20 >=20 > --=20 > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch