From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Tue, 15 Jan 2019 15:02:31 +0000 Subject: Re: [PATCH v2] Staging: fbtft: Switch to the gpio descriptor interface Message-Id: <20190115150231.GA3418@kroah.com> List-Id: References: <20190115044704.GA20989@nishad> In-Reply-To: <20190115044704.GA20989@nishad> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Nishad Kamdar Cc: devel@driverdev.osuosl.org, Leonardo =?iso-8859-1?Q?Br=E1s?= , linux-fbdev@vger.kernel.org, Jani Nikula , Daniel Vetter , Felix Siegel , YueHaibing , linux-kernel@vger.kernel.org, Mamta Shukla , Matthias Wolf , Renato Soma , dri-devel@lists.freedesktop.org, Tim Cofala , Radek =?iso-8859-1?Q?Dost=E1l?= , Lee Jones On Tue, Jan 15, 2019 at 10:17:09AM +0530, Nishad Kamdar wrote: > This switches the fbtft driver to use GPIO descriptors > rather than numerical gpios: > > Utilize the GPIO library's intrinsic handling of OF GPIOs > and polarity. If the line is flagged active low, gpiolib > will deal with this. > > Remove gpios from platform device structure. Neither assign > statically numbers to gpios in platform device nor allow > gpios to be parsed as module parameters. > > Signed-off-by: Nishad Kamdar > Changes in v2: > - Merge all patches in a single patch. This is because the > first patch changes par->gpio from an int to a pointer > so all the checks have to be updated in the same patch. > Otherwie it breaks 'git bisect'. The "v2" information goes below the --- line please. Also, I got 2 copies of this, both different, so I have no idea which to apply. Please fix up and resend a v3. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v2] Staging: fbtft: Switch to the gpio descriptor interface Date: Tue, 15 Jan 2019 16:02:31 +0100 Message-ID: <20190115150231.GA3418@kroah.com> References: <20190115044704.GA20989@nishad> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5BCDD6ED33 for ; Tue, 15 Jan 2019 15:02:34 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190115044704.GA20989@nishad> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nishad Kamdar Cc: devel@driverdev.osuosl.org, Leonardo =?iso-8859-1?Q?Br=E1s?= , linux-fbdev@vger.kernel.org, Jani Nikula , Daniel Vetter , Felix Siegel , YueHaibing , linux-kernel@vger.kernel.org, Mamta Shukla , Matthias Wolf , Renato Soma , dri-devel@lists.freedesktop.org, Tim Cofala , Radek =?iso-8859-1?Q?Dost=E1l?= , Lee Jones List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKYW4gMTUsIDIwMTkgYXQgMTA6MTc6MDlBTSArMDUzMCwgTmlzaGFkIEthbWRhciB3 cm90ZToKPiBUaGlzIHN3aXRjaGVzIHRoZSBmYnRmdCBkcml2ZXIgdG8gdXNlIEdQSU8gZGVzY3Jp cHRvcnMKPiByYXRoZXIgdGhhbiBudW1lcmljYWwgZ3Bpb3M6Cj4gCj4gVXRpbGl6ZSB0aGUgR1BJ TyBsaWJyYXJ5J3MgaW50cmluc2ljIGhhbmRsaW5nIG9mIE9GIEdQSU9zCj4gYW5kIHBvbGFyaXR5 LiBJZiB0aGUgbGluZSBpcyBmbGFnZ2VkIGFjdGl2ZSBsb3csIGdwaW9saWIKPiB3aWxsIGRlYWwg d2l0aCB0aGlzLgo+IAo+IFJlbW92ZSBncGlvcyBmcm9tIHBsYXRmb3JtIGRldmljZSBzdHJ1Y3R1 cmUuIE5laXRoZXIgYXNzaWduCj4gc3RhdGljYWxseSBudW1iZXJzIHRvIGdwaW9zIGluIHBsYXRm b3JtIGRldmljZSBub3IgYWxsb3cKPiBncGlvcyB0byBiZSBwYXJzZWQgYXMgbW9kdWxlIHBhcmFt ZXRlcnMuCj4gCj4gU2lnbmVkLW9mZi1ieTogTmlzaGFkIEthbWRhciA8bmlzaGFka2FtZGFyQGdt YWlsLmNvbT4KPiBDaGFuZ2VzIGluIHYyOgo+ICAtIE1lcmdlIGFsbCBwYXRjaGVzIGluIGEgc2lu Z2xlIHBhdGNoLiBUaGlzIGlzIGJlY2F1c2UgdGhlCj4gICAgZmlyc3QgcGF0Y2ggY2hhbmdlcyBw YXItPmdwaW8gZnJvbSBhbiBpbnQgdG8gYSBwb2ludGVyCj4gICAgc28gYWxsIHRoZSBjaGVja3Mg aGF2ZSB0byBiZSB1cGRhdGVkIGluIHRoZSBzYW1lIHBhdGNoLgo+ICAgIE90aGVyd2llIGl0IGJy ZWFrcyAnZ2l0IGJpc2VjdCcuCgpUaGUgInYyIiBpbmZvcm1hdGlvbiBnb2VzIGJlbG93IHRoZSAt LS0gbGluZSBwbGVhc2UuCgpBbHNvLCBJIGdvdCAyIGNvcGllcyBvZiB0aGlzLCBib3RoIGRpZmZl cmVudCwgc28gSSBoYXZlIG5vIGlkZWEgd2hpY2ggdG8KYXBwbHkuICBQbGVhc2UgZml4IHVwIGFu ZCByZXNlbmQgYSB2My4KCnRoYW5rcywKCmdyZWcgay1oCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 478AAC43387 for ; Tue, 15 Jan 2019 15:02:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18C1D20866 for ; Tue, 15 Jan 2019 15:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547564557; bh=wHmf28uW9OQOmNVh/i0FjaHWdDEu5/NUpQ+B0sdBq/4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=E3tE8IDj/+ymf0+hFKBh1iMYU87WeKjbZUlBIps6rT7fXuqKtA3PoXjuOlyoQUTrF 8rnYhbvM7NWEULq67Q0A+I2IiB5wK6SMdLdG1Vr8hqacOQHMNgnKsYxhqxUVFoMvtL 2BCrtgS9QZKh5eRqwLZU39gLBnM4QB3gQODAl3W0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730606AbfAOPCf (ORCPT ); Tue, 15 Jan 2019 10:02:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:35772 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728642AbfAOPCf (ORCPT ); Tue, 15 Jan 2019 10:02:35 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 87A6220656; Tue, 15 Jan 2019 15:02:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547564554; bh=wHmf28uW9OQOmNVh/i0FjaHWdDEu5/NUpQ+B0sdBq/4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IGPfbT9Xxdy/ZmIWFzBUm+hRgreJ+VRw3TUyLw8fHvH/BiPCVByA6VDzufPuU+XmR HSN313Ebd2WjxaYUsRNoJXxnLpH6WpBkD6D7WgxGCSDDEBIedkAiVdBk3puBLAWUu6 IpwEEcqPqyckBcO+KXZJUD8bRDhAvTc0dzjNEOPQ= Date: Tue, 15 Jan 2019 16:02:31 +0100 From: Greg Kroah-Hartman To: Nishad Kamdar Cc: devel@driverdev.osuosl.org, Leonardo =?iso-8859-1?Q?Br=E1s?= , linux-fbdev@vger.kernel.org, YueHaibing , Jani Nikula , Daniel Vetter , Felix Siegel , Matthias Wolf , linux-kernel@vger.kernel.org, Mamta Shukla , Radek =?iso-8859-1?Q?Dost=E1l?= , Renato Soma , dri-devel@lists.freedesktop.org, Tim Cofala , Lee Jones Subject: Re: [PATCH v2] Staging: fbtft: Switch to the gpio descriptor interface Message-ID: <20190115150231.GA3418@kroah.com> References: <20190115044704.GA20989@nishad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190115044704.GA20989@nishad> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 15, 2019 at 10:17:09AM +0530, Nishad Kamdar wrote: > This switches the fbtft driver to use GPIO descriptors > rather than numerical gpios: > > Utilize the GPIO library's intrinsic handling of OF GPIOs > and polarity. If the line is flagged active low, gpiolib > will deal with this. > > Remove gpios from platform device structure. Neither assign > statically numbers to gpios in platform device nor allow > gpios to be parsed as module parameters. > > Signed-off-by: Nishad Kamdar > Changes in v2: > - Merge all patches in a single patch. This is because the > first patch changes par->gpio from an int to a pointer > so all the checks have to be updated in the same patch. > Otherwie it breaks 'git bisect'. The "v2" information goes below the --- line please. Also, I got 2 copies of this, both different, so I have no idea which to apply. Please fix up and resend a v3. thanks, greg k-h