From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH v2 1/6] dt-bindings: phy-qcom: Add support for msm8998 usb Date: Tue, 15 Jan 2019 10:08:39 -0800 Message-ID: <20190115180839.GC28907@builder> References: <1547483771-5334-1-git-send-email-jhugo@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1547483771-5334-1-git-send-email-jhugo@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Jeffrey Hugo Cc: robh+dt@kernel.org, mark.rutland@arm.com, andy.gross@linaro.org, david.brown@linaro.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, balbi@kernel.org, linux-usb@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org On Mon 14 Jan 08:36 PST 2019, Jeffrey Hugo wrote: > USB on msm8998 utilizes the QUSB2 and QMP phys, similar to sdm845. > > Signed-off-by: Jeffrey Hugo > --- > Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 5 +++++ > Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt > index 41a1074..6061b6f 100644 > --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt > +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt > @@ -9,6 +9,7 @@ Required properties: > "qcom,ipq8074-qmp-pcie-phy" for PCIe phy on IPQ8074 > "qcom,msm8996-qmp-pcie-phy" for 14nm PCIe phy on msm8996, > "qcom,msm8996-qmp-usb3-phy" for 14nm USB3 phy on msm8996, > + "qcom,msm8998-qmp-usb3-phy" for USB3 QMP V3 phy on msm8998, > "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845, > "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845, > "qcom,sdm845-qmp-ufs-phy" for UFS QMP phy on sdm845. > @@ -42,6 +43,8 @@ Required properties: > "aux", "cfg_ahb", "ref". > For "qcom,msm8996-qmp-usb3-phy" must contain: > "aux", "cfg_ahb", "ref". > + For "qcom,msm8998-qmp-usb3-phy" must contain: > + "aux", "cfg_ahb", "ref". > For "qcom,sdm845-qmp-usb3-phy" must contain: > "aux", "cfg_ahb", "ref", "com_aux". > For "qcom,sdm845-qmp-usb3-uni-phy" must contain: > @@ -60,6 +63,8 @@ Required properties: > For "qcom,msm8996-qmp-pcie-phy" must contain: > "phy", "common", "cfg". > For "qcom,msm8996-qmp-usb3-phy" must contain > + "phy", "common". Odd indentation. Apart from this, you have my Reviewed-by: Bjorn Andersson Regards, Bjorn > + For "qcom,msm8998-qmp-usb3-phy" must contain > "phy", "common". > For "qcom,sdm845-qmp-usb3-phy" must contain: > "phy", "common". > diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > index 03025d9..fe29f9e 100644 > --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt > @@ -6,6 +6,7 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets. > Required properties: > - compatible: compatible list, contains > "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996, > + "qcom,msm8998-qusb2-phy" for 10nm PHY on msm8998, > "qcom,sdm845-qusb2-phy" for 10nm PHY on sdm845. > > - reg: offset and length of the PHY register set. > -- > Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc. > Qualcomm Technologies, Inc. is a member of the > Code Aurora Forum, a Linux Foundation Collaborative Project. > From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,1/6] dt-bindings: phy-qcom: Add support for msm8998 usb From: Bjorn Andersson Message-Id: <20190115180839.GC28907@builder> Date: Tue, 15 Jan 2019 10:08:39 -0800 To: Jeffrey Hugo Cc: robh+dt@kernel.org, mark.rutland@arm.com, andy.gross@linaro.org, david.brown@linaro.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, kishon@ti.com, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, balbi@kernel.org, linux-usb@vger.kernel.org List-ID: T24gTW9uIDE0IEphbiAwODozNiBQU1QgMjAxOSwgSmVmZnJleSBIdWdvIHdyb3RlOgoKPiBVU0Ig b24gbXNtODk5OCB1dGlsaXplcyB0aGUgUVVTQjIgYW5kIFFNUCBwaHlzLCBzaW1pbGFyIHRvIHNk bTg0NS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKZWZmcmV5IEh1Z28gPGpodWdvQGNvZGVhdXJvcmEu b3JnPgo+IC0tLQo+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGh5L3Fjb20t cW1wLXBoeS50eHQgICB8IDUgKysrKysKPiAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL3BoeS9xY29tLXF1c2IyLXBoeS50eHQgfCAxICsKPiAgMiBmaWxlcyBjaGFuZ2VkLCA2IGlu c2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL3BoeS9xY29tLXFtcC1waHkudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL3BoeS9xY29tLXFtcC1waHkudHh0Cj4gaW5kZXggNDFhMTA3NC4uNjA2MWI2ZiAxMDA2 NDQKPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGh5L3Fjb20tcW1w LXBoeS50eHQKPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGh5L3Fj b20tcW1wLXBoeS50eHQKPiBAQCAtOSw2ICs5LDcgQEAgUmVxdWlyZWQgcHJvcGVydGllczoKPiAg CSAgICAgICAicWNvbSxpcHE4MDc0LXFtcC1wY2llLXBoeSIgZm9yIFBDSWUgcGh5IG9uIElQUTgw NzQKPiAgCSAgICAgICAicWNvbSxtc204OTk2LXFtcC1wY2llLXBoeSIgZm9yIDE0bm0gUENJZSBw aHkgb24gbXNtODk5NiwKPiAgCSAgICAgICAicWNvbSxtc204OTk2LXFtcC11c2IzLXBoeSIgZm9y IDE0bm0gVVNCMyBwaHkgb24gbXNtODk5NiwKPiArCSAgICAgICAicWNvbSxtc204OTk4LXFtcC11 c2IzLXBoeSIgZm9yIFVTQjMgUU1QIFYzIHBoeSBvbiBtc204OTk4LAo+ICAJICAgICAgICJxY29t LHNkbTg0NS1xbXAtdXNiMy1waHkiIGZvciBVU0IzIFFNUCBWMyBwaHkgb24gc2RtODQ1LAo+ICAJ ICAgICAgICJxY29tLHNkbTg0NS1xbXAtdXNiMy11bmktcGh5IiBmb3IgVVNCMyBRTVAgVjMgVU5J IHBoeSBvbiBzZG04NDUsCj4gIAkgICAgICAgInFjb20sc2RtODQ1LXFtcC11ZnMtcGh5IiBmb3Ig VUZTIFFNUCBwaHkgb24gc2RtODQ1Lgo+IEBAIC00Miw2ICs0Myw4IEBAIFJlcXVpcmVkIHByb3Bl cnRpZXM6Cj4gIAkJCSJhdXgiLCAiY2ZnX2FoYiIsICJyZWYiLgo+ICAJCUZvciAicWNvbSxtc204 OTk2LXFtcC11c2IzLXBoeSIgbXVzdCBjb250YWluOgo+ICAJCQkiYXV4IiwgImNmZ19haGIiLCAi cmVmIi4KPiArCQlGb3IgInFjb20sbXNtODk5OC1xbXAtdXNiMy1waHkiIG11c3QgY29udGFpbjoK PiArCQkJImF1eCIsICJjZmdfYWhiIiwgInJlZiIuCj4gIAkJRm9yICJxY29tLHNkbTg0NS1xbXAt dXNiMy1waHkiIG11c3QgY29udGFpbjoKPiAgCQkJImF1eCIsICJjZmdfYWhiIiwgInJlZiIsICJj b21fYXV4Ii4KPiAgCQlGb3IgInFjb20sc2RtODQ1LXFtcC11c2IzLXVuaS1waHkiIG11c3QgY29u dGFpbjoKPiBAQCAtNjAsNiArNjMsOCBAQCBSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ICAJCUZvciAi cWNvbSxtc204OTk2LXFtcC1wY2llLXBoeSIgbXVzdCBjb250YWluOgo+ICAJCQkicGh5IiwgImNv bW1vbiIsICJjZmciLgo+ICAJCUZvciAicWNvbSxtc204OTk2LXFtcC11c2IzLXBoeSIgbXVzdCBj b250YWluCj4gKwkJICJwaHkiLCAiY29tbW9uIi4KCk9kZCBpbmRlbnRhdGlvbi4KCgpBcGFydCBm cm9tIHRoaXMsIHlvdSBoYXZlIG15CgpSZXZpZXdlZC1ieTogQmpvcm4gQW5kZXJzc29uIDxiam9y bi5hbmRlcnNzb25AbGluYXJvLm9yZz4KClJlZ2FyZHMsCkJqb3JuCgo+ICsJCUZvciAicWNvbSxt c204OTk4LXFtcC11c2IzLXBoeSIgbXVzdCBjb250YWluCj4gIAkJCSJwaHkiLCAiY29tbW9uIi4K PiAgCQlGb3IgInFjb20sc2RtODQ1LXFtcC11c2IzLXBoeSIgbXVzdCBjb250YWluOgo+ICAJCQki cGh5IiwgImNvbW1vbiIuCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9waHkvcWNvbS1xdXNiMi1waHkudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL3BoeS9xY29tLXF1c2IyLXBoeS50eHQKPiBpbmRleCAwMzAyNWQ5Li5mZTI5Zjll IDEwMDY0NAo+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9waHkvcWNv bS1xdXNiMi1waHkudHh0Cj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L3BoeS9xY29tLXF1c2IyLXBoeS50eHQKPiBAQCAtNiw2ICs2LDcgQEAgUVVTQjIgY29udHJvbGxl ciBzdXBwb3J0cyBMUy9GUy9IUyB1c2IgY29ubmVjdGl2aXR5IG9uIFF1YWxjb21tIGNoaXBzZXRz Lgo+ICBSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+ICAgLSBjb21wYXRpYmxlOiBjb21wYXRpYmxlIGxp c3QsIGNvbnRhaW5zCj4gIAkgICAgICAgInFjb20sbXNtODk5Ni1xdXNiMi1waHkiIGZvciAxNG5t IFBIWSBvbiBtc204OTk2LAo+ICsJICAgICAgICJxY29tLG1zbTg5OTgtcXVzYjItcGh5IiBmb3Ig MTBubSBQSFkgb24gbXNtODk5OCwKPiAgCSAgICAgICAicWNvbSxzZG04NDUtcXVzYjItcGh5IiBm b3IgMTBubSBQSFkgb24gc2RtODQ1Lgo+ICAKPiAgIC0gcmVnOiBvZmZzZXQgYW5kIGxlbmd0aCBv ZiB0aGUgUEhZIHJlZ2lzdGVyIHNldC4KPiAtLSAKPiBRdWFsY29tbSBEYXRhY2VudGVyIFRlY2hu b2xvZ2llcyBhcyBhbiBhZmZpbGlhdGUgb2YgUXVhbGNvbW0gVGVjaG5vbG9naWVzLCBJbmMuCj4g UXVhbGNvbW0gVGVjaG5vbG9naWVzLCBJbmMuIGlzIGEgbWVtYmVyIG9mIHRoZQo+IENvZGUgQXVy b3JhIEZvcnVtLCBhIExpbnV4IEZvdW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9qZWN0Lgo+Cg==