From: Shawn Guo <shawnguo@kernel.org>
To: "Guido Günther" <agx@sigxcpu.org>, "Stephen Boyd" <sboyd@kernel.org>
Cc: Lucas Stach <l.stach@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Abel Vesa <abel.vesa@nxp.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: imx8mq: Number clocks consecutively
Date: Wed, 16 Jan 2019 11:33:58 +0800 [thread overview]
Message-ID: <20190116033356.GG15808@dragon> (raw)
In-Reply-To: <20190115173012.GA3172@bogon.m.sigxcpu.org>
On Tue, Jan 15, 2019 at 06:30:12PM +0100, Guido G�nther wrote:
> Hi Lucas,
> On Tue, Jan 15, 2019 at 05:53:51PM +0100, Lucas Stach wrote:
> > Am Dienstag, den 15.01.2019, 17:35 +0100 schrieb Guido G�nther:
> > > Signed-off-by: Guido G�nther <agx@sigxcpu.org>
> >
> > This is a breaking change in terms of devicetree stability. So either
> > we rush this into 5.0-rcX, before the current definition spreads around
> > or we need to drop this change. I'll leave this for Shawn (CCed) to
> > decide.
>
> Note that 232 is currently used for both IMX8MQ_CLK_HDMI_ROOT and
> IMX8MQ_SYS1_PLL_OUT so we need to fix that one up - or need to come up
> with a new name and have that duplicate assignment in there forever. So
> fixing this for 5.0 would be cool.
I would like to fix it for 5.0.
@Guido,
Please write up a proper commit log as suggested by Abel, add a Fixes
tag and resend (with me copied).
Shawn
prev parent reply other threads:[~2019-01-16 3:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 16:35 [PATCH] dt-bindings: imx8mq: Number clocks consecutively Guido Günther
2019-01-15 16:49 ` Abel Vesa
2019-01-15 16:53 ` Lucas Stach
2019-01-15 17:30 ` Guido Günther
2019-01-16 3:33 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116033356.GG15808@dragon \
--to=shawnguo@kernel.org \
--cc=abel.vesa@nxp.com \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=l.stach@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.