From: Lee Jones <lee.jones@linaro.org>
To: Pi-Hsun Shih <pihsun@chromium.org>
Cc: Nicolas Boichat <drinkcat@chromium.org>,
Enric Balletbo Serra <eballetbo@gmail.com>,
Guenter Roeck <groeck@chromium.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC v2 6/6] cros_ec: differentiate SCP from EC by feature bit.
Date: Wed, 16 Jan 2019 08:27:58 +0000 [thread overview]
Message-ID: <20190116082758.GB23399@dell> (raw)
In-Reply-To: <20190108052606.59426-7-pihsun@chromium.org>
On Tue, 08 Jan 2019, Pi-Hsun Shih wrote:
> Since a SCP and EC would both exist on a system, and use the cros_ec_dev
> driver, we need to differentiate between them for the userspace, or they
> would both be registered at /dev/cros_ec, causing a conflict.
>
> Cc: Enric Balletbo Serra <eballetbo@gmail.com>
> Cc: Guenter Roeck <groeck@chromium.org>
> Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
> ---
> Changes from v1:
> - New patch extracted from Patch 5.
> ---
> drivers/mfd/cros_ec_dev.c | 9 +++++++++
> include/linux/mfd/cros_ec.h | 1 +
> include/linux/mfd/cros_ec_commands.h | 2 ++
> 3 files changed, 12 insertions(+)
The (other) Chromium guys are usually pretty active and are more
familiar with this hardware and group of (MFD/Platform) drivers than I
am. Thus I'm waiting for one of them to provide their thoughts before
applying this.
Just make sure you Cc:ed enough of them!
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2019-01-16 8:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 5:26 [RFC v2 0/6] Add support for mt8183 SCP Pi-Hsun Shih
2019-01-08 5:26 ` Pi-Hsun Shih
2019-01-08 5:26 ` [RFC v2 1/6] dt-bindings: Add a binding for Mediatek SCP Pi-Hsun Shih
2019-01-08 5:26 ` Pi-Hsun Shih
2019-01-08 5:26 ` Pi-Hsun Shih
2019-01-15 20:34 ` Rob Herring
2019-01-15 20:34 ` Rob Herring
2019-01-16 4:00 ` Peter Shih
2019-01-16 4:00 ` Peter Shih
2019-01-16 4:00 ` Peter Shih
2019-01-08 5:26 ` [RFC v2 2/6] remoteproc/mediatek: add SCP support for mt8183 Pi-Hsun Shih
2019-01-08 5:26 ` Pi-Hsun Shih
2019-01-08 5:26 ` Pi-Hsun Shih
2019-01-08 5:26 ` [RFC v2 3/6] remoteproc: move IPI interface into separate file Pi-Hsun Shih
2019-01-08 5:26 ` Pi-Hsun Shih
2019-01-08 5:26 ` Pi-Hsun Shih
2019-01-18 21:04 ` Nicolas Boichat
2019-01-18 21:04 ` Nicolas Boichat
2019-01-21 7:03 ` Peter Shih
2019-01-21 7:03 ` Peter Shih
2019-01-21 7:03 ` Peter Shih
2019-01-08 5:26 ` [RFC v2 4/6] rpmsg: add rpmsg support for mt8183 SCP Pi-Hsun Shih
2019-01-08 5:26 ` Pi-Hsun Shih
2019-01-08 5:26 ` Pi-Hsun Shih
2019-01-08 5:26 ` [RFC v2 5/6] mfd: add EC host command support using rpmsg Pi-Hsun Shih
2019-01-08 5:26 ` [RFC v2 6/6] cros_ec: differentiate SCP from EC by feature bit Pi-Hsun Shih
2019-01-16 8:27 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116082758.GB23399@dell \
--to=lee.jones@linaro.org \
--cc=drinkcat@chromium.org \
--cc=eballetbo@gmail.com \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pihsun@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.