diff for duplicates of <20190116104553.GE4482@kadam> diff --git a/a/1.txt b/N1/1.txt index 351cd0b..595b7fc 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,11 +1,11 @@ -On Wed, Jan 16, 2019@04:59:54PM +0800, Gao Xiang wrote: +On Wed, Jan 16, 2019 at 04:59:54PM +0800, Gao Xiang wrote: > It is more suitable to update in erofs_workgroup_get since > it's actually the one matched with erofs_workgroup_put. > This patch is fine. No need to resend. -Reviewed-by: Dan Carpenter <dan.carpenter at oracle.com> +Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com> But for future reference, I found the commit message a bit confusing. Ideally, I would understand basically what the commit does and why diff --git a/a/content_digest b/N1/content_digest index a91b6c8..d28972e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,18 +1,28 @@ "ref\020190116085956.21004-1-gaoxiang25@huawei.com\0" "ref\020190116085956.21004-3-gaoxiang25@huawei.com\0" - "From\0dan.carpenter@oracle.com (Dan Carpenter)\0" - "Subject\0[PATCH 3/5] staging: erofs: decrease the shrink count in erofs_workgroup_get\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" + "Subject\0Re: [PATCH 3/5] staging: erofs: decrease the shrink count in erofs_workgroup_get\0" "Date\0Wed, 16 Jan 2019 13:45:53 +0300\0" + "To\0Gao Xiang <gaoxiang25@huawei.com>\0" + "Cc\0Chao Yu <yuchao0@huawei.com>" + Greg Kroah-Hartman <gregkh@linuxfoundation.org> + devel@driverdev.osuosl.org + linux-erofs@lists.ozlabs.org + Chao Yu <chao@kernel.org> + LKML <linux-kernel@vger.kernel.org> + weidu.du@huawei.com + Fang Wei <fangwei1@huawei.com> + " Miao Xie <miaoxie@huawei.com>\0" "\00:1\0" "b\0" - "On Wed, Jan 16, 2019@04:59:54PM +0800, Gao Xiang wrote:\n" + "On Wed, Jan 16, 2019 at 04:59:54PM +0800, Gao Xiang wrote:\n" "> It is more suitable to update in erofs_workgroup_get since\n" "> it's actually the one matched with erofs_workgroup_put.\n" "> \n" "\n" "This patch is fine. No need to resend.\n" "\n" - "Reviewed-by: Dan Carpenter <dan.carpenter at oracle.com>\n" + "Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>\n" "\n" "But for future reference, I found the commit message a bit confusing.\n" "Ideally, I would understand basically what the commit does and why\n" @@ -40,4 +50,4 @@ "regards,\n" dan carpenter -cad44e4544ceb7a6e63504a68d9b7705c5fa4346cbb089b71f8a0519303546a4 +a803f2a94386983f36abac2a3e502dab1f2fb320becfc5ba3237fd4c47c72b07
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.