All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jan-Marek Glogowski <glogow@fbihome.de>
Cc: linux-usb@vger.kernel.org
Subject: [v2] usb: warm-reset ports on hub resume, if requested
Date: Wed, 16 Jan 2019 17:43:15 +0100	[thread overview]
Message-ID: <20190116164315.GA8729@kroah.com> (raw)

On Wed, Jan 16, 2019 at 05:06:33PM +0100, Jan-Marek Glogowski wrote:
> On plug-in of my USB-C device, its USB_SS_PORT_LS_SS_INACTIVE
> link state bit is set. Greping all the kernel for this bit shows
> that the port status requests a warm-reset this way.
> 
> This just happens, if its the only device on that hub and the
> hub resumes, so we don't call port_event, which would otherwise
> warm-reset ports. The device works ok without this patch, if
> there is already any other device connected to the hub.
> 
> Signed-off-by: Jan-Marek Glogowski <glogow@fbihome.de>
> ---
>  drivers/usb/core/hub.c | 21 +++++++++++++++------
>  1 file changed, 15 insertions(+), 6 deletions(-)

What changed from v1?  Always put that below the --- line, as the
documentation asks you to do.

v3 please?

thanks,

greg k-h

             reply	other threads:[~2019-01-16 16:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16 16:43 Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-01-16 16:06 [v2] usb: warm-reset ports on hub resume, if requested Jan-Marek Glogowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190116164315.GA8729@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=glogow@fbihome.de \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.