From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 344F7C43387 for ; Wed, 16 Jan 2019 22:00:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF487206C2 for ; Wed, 16 Jan 2019 22:00:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="i2Kb5vEf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732119AbfAPWAe (ORCPT ); Wed, 16 Jan 2019 17:00:34 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:45864 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731410AbfAPWAe (ORCPT ); Wed, 16 Jan 2019 17:00:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=HGyhHBKzwUFe+D03LvTPuprZGaa1MjLa13Jir/lLLig=; b=i2Kb5vEf+zooYiq3NbT31ea5WGIxYpxFJRd0VzcLBQIRYFvS/4mlXJFqPM7nI7cZntbTxdZcn3pqrBZFLa5yIbe9HHsLUXSAXK/w5Vab2YoV1a3HPFu2JIldOlTX645UhQJ0atNpm9xVFumU4VZTpRQN4HlP3CCuvnniqiMN5rM=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1gjtEe-0002Ir-HU; Wed, 16 Jan 2019 23:00:32 +0100 Date: Wed, 16 Jan 2019 23:00:32 +0100 From: Andrew Lunn To: Heiner Kallweit Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH v2 net-next 3/3] net: phy: remove phy_stop_interrupts Message-ID: <20190116220032.GM29244@lunn.ch> References: <36e18752-488a-8fa7-ce0a-376446455345@gmail.com> <33d1cd5f-6036-f37d-9e93-10bf23448e66@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <33d1cd5f-6036-f37d-9e93-10bf23448e66@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 16, 2019 at 09:26:44PM +0100, Heiner Kallweit wrote: > Interrupts have been disabled in phy_stop() already. So we can remove > phy_stop_interrupts() and free the interrupt in phy_disconnect() > directly. > > Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn Andrew