From: Pavel Machek <pavel@ucw.cz>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: Rafael Wysocki <rjw@rjwysocki.net>, arm-soc <arm@kernel.org>,
Mans Rullgard <mans@mansr.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Paolo Pisati <p.pisati@gmail.com>
Subject: Re: [PATCH v2] ARM: tango: Improve ARCH_MULTIPLATFORM compatibility
Date: Wed, 16 Jan 2019 23:05:25 +0100 [thread overview]
Message-ID: <20190116220525.GA28781@amd> (raw)
In-Reply-To: <48e3596f-4c76-8481-5cd4-5e8e79d31a09@free.fr>
[-- Attachment #1.1: Type: text/plain, Size: 1287 bytes --]
On Wed 2019-01-16 16:49:58, Marc Gonzalez wrote:
> Calling platform-specific code unconditionally blows up when running
> an ARCH_MULTIPLATFORM kernel on a different platform. Don't do it.
>
> Reported-by: Paolo Pisati <p.pisati@gmail.com>
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
Acked-by: Pavel Machek <pavel@ucw.cz>
> @@ -0,0 +1,7 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> +#ifdef CONFIG_SUSPEND
> +void __init tango_pm_init(void);
> +#else
> +#define tango_pm_init NULL
> +#endif
> diff --git a/arch/arm/mach-tango/setup.c b/arch/arm/mach-tango/setup.c
> index 677dd7b5efd9..824f90737b04 100644
> --- a/arch/arm/mach-tango/setup.c
> +++ b/arch/arm/mach-tango/setup.c
> @@ -2,6 +2,7 @@
> #include <asm/mach/arch.h>
> #include <asm/hardware/cache-l2x0.h>
> #include "smc.h"
> +#include "pm.h"
>
> static void tango_l2c_write(unsigned long val, unsigned int reg)
> {
> @@ -15,4 +16,5 @@ DT_MACHINE_START(TANGO_DT, "Sigma Tango DT")
> .dt_compat = tango_dt_compat,
> .l2c_aux_mask = ~0,
> .l2c_write_sec = tango_l2c_write,
> + .init_late = tango_pm_init,
> MACHINE_END
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-16 22:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 15:49 [PATCH v2] ARM: tango: Improve ARCH_MULTIPLATFORM compatibility Marc Gonzalez
2019-01-16 22:05 ` Pavel Machek [this message]
2019-01-30 10:47 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116220525.GA28781@amd \
--to=pavel@ucw.cz \
--cc=arm@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mans@mansr.com \
--cc=marc.w.gonzalez@free.fr \
--cc=p.pisati@gmail.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.