From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jia Zhang <zhang.jia@linux.alibaba.com>
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, tweek@google.com,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] tpm/eventlog/tpm1: Simplify walking over *pos measurements
Date: Thu, 17 Jan 2019 00:09:52 +0200 [thread overview]
Message-ID: <20190116220952.GH25803@linux.intel.com> (raw)
In-Reply-To: <1547197173-52826-2-git-send-email-zhang.jia@linux.alibaba.com>
Please use "tpm:" tag for commits, not "tpm/eventlog/tpm1".
On Fri, Jan 11, 2019 at 04:59:32PM +0800, Jia Zhang wrote:
> The responsibility of tpm1_bios_measurements_start() is to walk
> over the first *pos measurements, ensuring the skipped and
> to-be-read measurements are not out-of-boundary.
>
> Current logic is complicated a bit. Just employ a do-while loop
> with necessary sanity check, and then get the goal.
>
> Signed-off-by: Jia Zhang <zhang.jia@linux.alibaba.com>
What does this fix? Even if the current logic is "complicated", it is
still a pretty simple functiion.
Applying clean ups for fun has the side-effect of making backporting
more difficult. And swapping implementation randomly has the side-effect
of potentially introducing regressions. The current code might be messy
but it is still field tested.
I'm sorry but I have to reject this patch.
/Jarkko
next prev parent reply other threads:[~2019-01-16 22:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 8:59 [PATCH v2 0/2] tpm/eventlog/tpm1: Small fixes Jia Zhang
2019-01-11 8:59 ` [PATCH 1/2] tpm/eventlog/tpm1: Simplify walking over *pos measurements Jia Zhang
2019-01-16 22:09 ` Jarkko Sakkinen [this message]
2019-01-17 1:32 ` Jia Zhang
2019-01-18 15:18 ` Jarkko Sakkinen
2019-01-19 7:48 ` Jia Zhang
2019-01-11 8:59 ` [PATCH 2/2] tpm/eventlog/tpm1: Fix off-by-1 when reading binary_bios_measurements Jia Zhang
2019-01-16 22:17 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2019-01-06 7:23 [PATCH 1/2] tpm/eventlog/tpm1: Simplify walking over *pos measurements Jia Zhang
2019-01-10 17:32 ` Jarkko Sakkinen
2019-01-11 8:29 ` Jia Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116220952.GH25803@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tweek@google.com \
--cc=zhang.jia@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.