From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/9] cmd: add efitool command
Date: Thu, 17 Jan 2019 13:27:08 +0900 [thread overview]
Message-ID: <20190117042706.GQ20286@linaro.org> (raw)
In-Reply-To: <da51693e-4f76-db2c-9fdd-d3fe19a1b164@gmx.de>
On Tue, Jan 15, 2019 at 04:31:35AM +0100, Heinrich Schuchardt wrote:
> On 1/15/19 3:55 AM, AKASHI Takahiro wrote:
> > Currently, there is no easy way to add or modify UEFI variables.
> > In particular, bootmgr supports BootOrder/BootXXXX variables, it is
> > quite hard to define them as u-boot variables because they are represented
> > in a complicated and encoded format.
> >
> > The new command, efitool, helps address these issues and give us
> > more friendly interfaces:
> > * efitool boot add: add BootXXXX variable
> > * efitool boot rm: remove BootXXXX variable
> > * efitool boot dump: display all BootXXXX variables
> > * efitool boot order: set/display a boot order (BootOrder)
> > * efitool setvar: set an UEFI variable (with limited functionality)
> > * efitool dumpvar: display all UEFI variables
> >
> > As the name suggests, this command basically provides a subset fo UEFI
> > shell commands with simplified functionality.
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
>
> Hello Takahiro,
>
> thanks a lot for your patch series. The additional command is really useful.
>
> Unfortunately the implementation of sub-commands does not follow the
> coding style of other sub-commands. Could you please have a look at the
> current doc/README.commands
>
> http://git.denx.de/?p=u-boot.git;a=blob;f=doc/README.commands
OK.
> I think it should be easy to convert your code to follow the
> implementation style suggested there and used all over U-Boot.
>
> Sorry that I did not put this into an earlier comment. I only learnt
> about this recently by a review from Simon and then updated the README.
>
> Please, add the new file in MAINTAINERS to the EFI PAYLOAD section.
Sure
Thanks,
-Takahiro Akashi
> Best regards
>
> Heinrich
next prev parent reply other threads:[~2019-01-17 4:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 2:55 [U-Boot] [PATCH v4 0/9] cmd: add efitool for efi environment AKASHI Takahiro
2019-01-15 2:55 ` [U-Boot] [PATCH v4 1/9] cmd: add efitool command AKASHI Takahiro
2019-01-15 3:31 ` Heinrich Schuchardt
2019-01-17 4:27 ` AKASHI Takahiro [this message]
2019-01-15 2:55 ` [U-Boot] [PATCH v4 2/9] cmd: efitool: add devices command AKASHI Takahiro
2019-01-15 5:09 ` Heinrich Schuchardt
2019-01-17 4:48 ` AKASHI Takahiro
2019-01-15 2:55 ` [U-Boot] [PATCH v4 3/9] efi_driver: add name to driver binding protocol AKASHI Takahiro
2019-01-15 3:41 ` Heinrich Schuchardt
2019-01-17 5:33 ` AKASHI Takahiro
2019-01-17 6:58 ` Heinrich Schuchardt
2019-01-21 7:47 ` AKASHI Takahiro
2019-01-15 2:55 ` [U-Boot] [PATCH v4 4/9] cmd: efitool: add drivers command AKASHI Takahiro
2019-01-15 3:39 ` Heinrich Schuchardt
2019-01-15 2:55 ` [U-Boot] [PATCH v4 5/9] cmd: efitool: add dh command AKASHI Takahiro
2019-01-15 4:55 ` Heinrich Schuchardt
2019-01-17 6:01 ` AKASHI Takahiro
2019-01-15 2:55 ` [U-Boot] [PATCH v4 6/9] cmd: efitool: add images command AKASHI Takahiro
2019-01-15 4:58 ` Heinrich Schuchardt
2019-01-17 6:02 ` AKASHI Takahiro
2019-01-15 2:55 ` [U-Boot] [PATCH v4 7/9] cmd: efitool: add memmap command AKASHI Takahiro
2019-01-15 4:26 ` Heinrich Schuchardt
2019-01-17 7:03 ` AKASHI Takahiro
2019-01-15 2:55 ` [U-Boot] [PATCH v4 8/9] cmd: efitool: export uefi variable helper functions AKASHI Takahiro
2019-01-15 5:28 ` Heinrich Schuchardt
2019-01-17 7:30 ` AKASHI Takahiro
2019-01-15 2:55 ` [U-Boot] [PATCH v4 9/9] cmd: env: add "-e" option for handling UEFI variables AKASHI Takahiro
2019-01-15 3:47 ` Heinrich Schuchardt
2019-01-15 13:23 ` Alexander Graf
2019-01-15 13:26 ` Alexander Graf
2019-01-15 9:16 ` [U-Boot] [PATCH v4 0/9] cmd: add efitool for efi environment Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117042706.GQ20286@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.