All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tristram.Ha@microchip.com
Cc: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
	Marek Vasut <marex@denx.de>, Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Pavel Machek <pavel@ucw.cz>,
	vivien.didelot@savoirfairelinux.com,
	UNGLinuxDriver@microchip.com, netdev@vger.kernel.org
Subject: Re: [PATCH RFC v1] net: dsa: microchip: add KSZ9477 I2C driver
Date: Thu, 17 Jan 2019 11:38:04 +0300	[thread overview]
Message-ID: <20190117080949.GN4504@kadam> (raw)
In-Reply-To: <1547695462-31618-2-git-send-email-Tristram.Ha@microchip.com>

No need to send this as an RFC patch.  Adding a new driver is
normal and uncontroversial.

On Wed, Jan 16, 2019 at 07:24:22PM -0800, Tristram.Ha@microchip.com wrote:
> +
> +	i2c_set_clientdata(i2c, dev);
                                ^^^
> +
> +	return 0;
> +}
> +
> +static int ksz9477_i2c_remove(struct i2c_client *i2c)
> +{
> +	struct ksz_device *dev = i2c_get_clientdata(i2c);
> +
> +	if (dev)
            ^^^
No need.

> +		ksz_switch_remove(dev);
> +
> +	return 0;
> +}
> +

regards,
dan carpenter

  reply	other threads:[~2019-01-17  8:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17  3:24 [PATCH RFC v1] net: dsa: microchip: add KSZ9477 I2C driver Tristram.Ha
2019-01-17  3:24 ` Tristram.Ha
2019-01-17  8:38   ` Dan Carpenter [this message]
2019-01-17  9:36   ` Sergio Paracuellos
2019-01-17  9:49     ` Sergio Paracuellos
2019-01-18  6:22   ` Marek Vasut
2019-01-18 20:25     ` Tristram.Ha
2019-01-19  6:22       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190117080949.GN4504@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=Tristram.Ha@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=marex@denx.de \
    --cc=netdev@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sergio.paracuellos@gmail.com \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.