From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, jasowang@redhat.com,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] virtio_net: bulk free tx skbs
Date: Thu, 17 Jan 2019 08:34:56 -0500 [thread overview]
Message-ID: <20190117083429-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20190116.153158.1210819126964530944.davem@davemloft.net>
On Wed, Jan 16, 2019 at 03:31:58PM -0800, David Miller wrote:
> From: "Michael S. Tsirkin" <mst@redhat.com>
> Date: Mon, 14 Jan 2019 20:34:26 -0500
>
> > Use napi_consume_skb() to get bulk free. Note that napi_consume_skb is
> > safe to call in a non-napi context as long as the napi_budget flag is
> > correct.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >
> > My perf testing setup is down but it works fine on my devel box and
> > should be fairly uncontroversial.
>
> It would be uncontroversial if it compiled.
>
> drivers/net/virtio_net.c: In function ‘free_old_xmit_skbs’:
> drivers/net/virtio_net.c:1346:25: error: ‘use_napi’ undeclared (first use in this function); did you mean ‘used_math’?
> napi_consume_skb(skb, use_napi);
> ^~~~~~~~
> used_math
> drivers/net/virtio_net.c:1346:25: note: each undeclared identifier is reported only once for each function it appears in
Yes my bad it was on top of other patches.
I'm rebasing and will repost.
--
MST
next prev parent reply other threads:[~2019-01-17 13:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 1:34 [PATCH net-next] virtio_net: bulk free tx skbs Michael S. Tsirkin
2019-01-16 23:31 ` David Miller
2019-01-16 23:31 ` David Miller
2019-01-17 13:34 ` Michael S. Tsirkin
2019-01-17 13:34 ` Michael S. Tsirkin [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-01-15 1:34 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117083429-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.