All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: Benedict Wong <benedictwong@google.com>
Cc: <netdev@vger.kernel.org>, <tobias@strongswan.org>,
	<eyal.birger@gmail.com>, <lorenzo@google.com>,
	<nharold@google.com>, <maze@google.com>
Subject: Re: [PATCH ipsec, resend 1/1] xfrm: Make set-mark default behavior backward compatible
Date: Thu, 17 Jan 2019 12:30:35 +0100	[thread overview]
Message-ID: <20190117113035.GO3581@gauss3.secunet.de> (raw)
In-Reply-To: <20190114192438.198153-2-benedictwong@google.com>

On Mon, Jan 14, 2019 at 11:24:38AM -0800, Benedict Wong wrote:
> Fixes 9b42c1f179a6, which changed the default route lookup behavior for
> tunnel mode SAs in the outbound direction to use the skb mark, whereas
> previously mark=0 was used if the output mark was unspecified. In
> mark-based routing schemes such as Android’s, this change in default
> behavior causes routing loops or lookup failures.
> 
> This patch restores the default behavior of using a 0 mark while still
> incorporating the skb mark if the SET_MARK (and SET_MARK_MASK) is
> specified.
> 
> Tested with additions to Android's kernel unit test suite:
> https://android-review.googlesource.com/c/kernel/tests/+/860150
> 
> Fixes: 9b42c1f179a6 ("xfrm: Extend the output_mark to support input direction and masking")
> Signed-off-by: Benedict Wong <benedictwong@google.com>

Applied, thanks a lot Benedict!

  parent reply	other threads:[~2019-01-17 11:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14 19:24 [PATCH ipsec, resend 0/1] xfrm: set-mark default behavior changes Benedict Wong
2019-01-14 19:24 ` [PATCH ipsec, resend 1/1] xfrm: Make set-mark default behavior backward compatible Benedict Wong
2019-01-15  5:11   ` Eyal Birger
2019-01-15 19:05     ` Benedict Wong
2019-01-17 11:30   ` Steffen Klassert [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-01-11 20:14 [PATCH ipsec, resend 0/1] xfrm: set-mark default behavior changes Benedict Wong
2019-01-11 20:14 ` [PATCH ipsec, resend 1/1] xfrm: Make set-mark default behavior backward compatible Benedict Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190117113035.GO3581@gauss3.secunet.de \
    --to=steffen.klassert@secunet.com \
    --cc=benedictwong@google.com \
    --cc=eyal.birger@gmail.com \
    --cc=lorenzo@google.com \
    --cc=maze@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=nharold@google.com \
    --cc=tobias@strongswan.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.