From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Maciej Fijalkowski <maciejromanfijalkowski@gmail.com>
Cc: daniel@iogearbox.net, ast@kernel.org, netdev@vger.kernel.org,
jakub.kicinski@netronome.com, brouer@redhat.com
Subject: Re: [PATCH bpf-next 2/6] samples: bpf: Convert XDP samples to libbpf usage
Date: Thu, 17 Jan 2019 12:19:24 +0100 [thread overview]
Message-ID: <20190117121924.033d3106@redhat.com> (raw)
In-Reply-To: <20190117010115.18234-3-maciejromanfijalkowski@gmail.com>
On Thu, 17 Jan 2019 02:01:11 +0100
Maciej Fijalkowski <maciejromanfijalkowski@gmail.com> wrote:
> xdp_redirect_cpu is omitted because of read_trace_pipe() usage, which
> doesn't seem to be handled in libbpf ATM.
The sample xdp_redirect_cpu, doesn't need to use read_trace_pipe().
I'll send a patch to remove it (that you can include in your patchset).
It must be a left-over when I was developing this... as it doesn't do
any bpf_trace_printk calls.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-01-17 11:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 1:01 [PATCH bpf-next 0/6] xdp: Avoid unloading xdp prog not attached by sample Maciej Fijalkowski
2019-01-17 1:01 ` [PATCH bpf-next 1/6] libbpf: Add a helper for retrieving a map fd for a given name Maciej Fijalkowski
2019-01-17 1:01 ` [PATCH bpf-next 2/6] samples: bpf: Convert XDP samples to libbpf usage Maciej Fijalkowski
2019-01-17 11:19 ` Jesper Dangaard Brouer [this message]
2019-01-17 11:26 ` [RFC bpf-next PATCH] samples/bpf: xdp_redirect_cpu have not need for read_trace_pipe Jesper Dangaard Brouer
2019-01-21 8:39 ` Maciej Fijałkowski
2019-01-25 8:22 ` [PATCH bpf-next 2/6] samples: bpf: Convert XDP samples to libbpf usage Jesper Dangaard Brouer
2019-01-17 1:01 ` [PATCH bpf-next 3/6] samples: bpf: Extend RLIMIT_MEMLOCK for xdp_{sample_pkts, router_ipv4} Maciej Fijalkowski
2019-01-17 1:01 ` [PATCH bpf-next 4/6] samples: bpf: Add a "force" flag to XDP samples Maciej Fijalkowski
2019-01-17 1:01 ` [PATCH bpf-next 5/6] libbpf: Add a support for getting xdp prog id on ifindex Maciej Fijalkowski
2019-01-17 1:01 ` [PATCH bpf-next 6/6] samples: bpf: Check the prog id before exiting Maciej Fijalkowski
2019-01-17 11:36 ` Jesper Dangaard Brouer
2019-01-21 8:46 ` Maciej Fijałkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117121924.033d3106@redhat.com \
--to=brouer@redhat.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=maciejromanfijalkowski@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.