From: Pavel Machek <pavel@denx.de>
To: Marek Vasut <marex@denx.de>
Cc: Tristram.Ha@microchip.com,
Sergio Paracuellos <sergio.paracuellos@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
vivien.didelot@savoirfairelinux.com,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org
Subject: Re: [PATCH RFC 1/4] net: dsa: microchip: convert KSZ9477 SPI driver to use regmap
Date: Fri, 18 Jan 2019 11:50:59 +0100 [thread overview]
Message-ID: <20190118105059.GA6100@amd> (raw)
In-Reply-To: <62dc3a53-1c2e-aadf-f5b2-2f4ad75a201a@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1444 bytes --]
On Fri 2019-01-18 07:29:35, Marek Vasut wrote:
> On 1/17/19 4:22 AM, Tristram.Ha@microchip.com wrote:
> > From: Tristram Ha <Tristram.Ha@microchip.com>
> >
> > Convert KSZ9477 SPI driver to use regmap mechanism so that an I2C driver
> > can be easily added.
> >
> > KSZ9477 SPI driver uses a 32-bit SPI command containing a 24-bit address
> > to access registers in 8-bit. The address is automatically increased to
> > next register. In theory all registers can be read in one transfer as
> > long as the buffer is enough. Therefore the regmap_raw_read and
> > regmap_raw_write functions are used for basic 8-bit access. Two more
> > regmap configurations are used for 16-bit and 32-bit accesses just that
> > regmap_update_bits can be used.
> >
> > All variables and functions associated with SPI access are removed.
> >
> > Signed-off-by: Tristram Ha <Tristram.Ha@microchip.com>
>
> These extremely patches look similar to what I posted here before:
>
> https://patchwork.ozlabs.org/cover/1017222/
>
> But the authorship has changed. Why ?
There seems to be explanation in 0/4.
Tristram: if you started from Marek's patches as you describe in 0/4,
you should mark respective patches as From: and Signed-off-by:
Marek...
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-01-18 10:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 3:22 [PATCH RFC 0/4] Convert KSZ9477 SPI driver to use regmap Tristram.Ha
2019-01-17 3:22 ` [PATCH RFC 1/4] net: dsa: microchip: convert " Tristram.Ha
2019-01-18 6:29 ` Marek Vasut
2019-01-18 10:50 ` Pavel Machek [this message]
2019-01-18 20:32 ` Tristram.Ha
2019-01-19 6:23 ` Marek Vasut
2019-01-19 13:22 ` Pavel Machek
2019-01-17 3:22 ` [PATCH RFC 2/4] net: dsa: microchip: Use regmap_update_bits Tristram.Ha
2019-01-17 3:22 ` [PATCH RFC 3/4] net: dsa: microchip: remove ksz9477_get_port_addr Tristram.Ha
2019-01-17 3:22 ` [PATCH RFC 4/4] net: dsa: microchip: remove ksz_spi.h Tristram.Ha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118105059.GA6100@amd \
--to=pavel@denx.de \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=dan.carpenter@oracle.com \
--cc=f.fainelli@gmail.com \
--cc=marex@denx.de \
--cc=netdev@vger.kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.