From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 399BAC43387 for ; Fri, 18 Jan 2019 16:10:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09D6B20896 for ; Fri, 18 Jan 2019 16:10:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547827852; bh=I8E0Ne12PNwQeyik7qbbRS4EMN/u+upinBAhgUX1sbs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=hXeItqp7OyKrpcROnzGQ3NP2pikHvKGhNMrymaCcqNkCeGJ1w7+2uD+7195KY2hRM qtTjdsEaaV6Bflh6ANYdQp/+VZnYUu+ZONPaD74LhuOEPeqbLoO3XQKZdaDfJyKb7C pDB/XFetJdZ068Wzma/IBsCaiQvYkisHfFsibBrc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728097AbfARQKv (ORCPT ); Fri, 18 Jan 2019 11:10:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:54426 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727020AbfARQKv (ORCPT ); Fri, 18 Jan 2019 11:10:51 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 50E3B20850; Fri, 18 Jan 2019 16:10:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547827850; bh=I8E0Ne12PNwQeyik7qbbRS4EMN/u+upinBAhgUX1sbs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=z0Gvfca3YMVPnMg0yfysTSfoIHKA+kXSfYa6BNwFjRcTr9yRePo+AZEzb+F6oppjg cpwQK+R0KbeyfRqr8oaxCnyeBGHEHyPoubKdeObzFG3AHC1M4AIBBM62WXOLp9/Xar akrY3FFTPcAxDl4Cy/IfrN3UDLkFHVFUFnjkuwZc= Date: Fri, 18 Jan 2019 17:10:48 +0100 From: Greg Kroah-Hartman To: Guenter Roeck Cc: stable@vger.kernel.org, Kees Cook , Gwendal Grignou Subject: Re: [PATCH v4.9.y] proc: Remove empty line in /proc/self/status Message-ID: <20190118161048.GF11503@kroah.com> References: <1547665111-31650-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1547665111-31650-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jan 16, 2019 at 10:58:31AM -0800, Guenter Roeck wrote: > If CONFIG_SECCOMP=n, /proc/self/status includes an empty line. This causes > the iotop application to bail out with an error message. > > File "/usr/local/lib64/python2.7/site-packages/iotop/data.py", line 196, > in parse_proc_pid_status > key, value = line.split(':\t', 1) > ValueError: need more than 1 value to unpack > > The problem is seen in v4.9.y but not upstream because commit af884cd4a5ae6 > ("proc: report no_new_privs state") has not been backported to v4.9.y. > The backport of commit fae1fa0fc6cc ("proc: Provide details on speculation > flaw mitigations") tried to address the resulting differences but was > wrong, introducing the problem. > > Fixes: 51ef9af2a35b ("proc: Provide details on speculation flaw mitigations") > Cc: Kees Cook > Cc: Gwendal Grignou > Signed-off-by: Guenter Roeck > --- > This patch only applies to v4.9.y. v4.4.y also needs to be fixed (see > https://www.spinics.net/lists/stable/msg279131.html), but the fix > is slightly different. v4.14.y and later are not affected. Now queued up, thanks. greg k-h