From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v5,4/6] usb: gadget: add mechanism to specify an explicit status stage From: Paul Elder Message-Id: <20190118163106.GC7331@localhost.localdomain> Date: Fri, 18 Jan 2019 11:31:06 -0500 To: Alan Stern Cc: laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, b-liu@ti.com, rogerq@ti.com, balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gV2VkLCBKYW4gMTYsIDIwMTkgYXQgMTA6MDY6NTNBTSAtMDUwMCwgQWxhbiBTdGVybiB3cm90 ZToKPiBPbiBXZWQsIDE2IEphbiAyMDE5LCBQYXVsIEVsZGVyIHdyb3RlOgo+IAo+ID4gT24gTW9u LCBKYW4gMTQsIDIwMTkgYXQgMTA6MjQ6NDRBTSAtMDUwMCwgQWxhbiBTdGVybiB3cm90ZToKPiA+ ID4gT24gTW9uLCAxNCBKYW4gMjAxOSwgUGF1bCBFbGRlciB3cm90ZToKPiA+ID4gCj4gPiA+ID4g PiA+ID4gQ2FuIHlvdSBjaGVjayB5b3VyIHV2Ywo+ID4gPiA+ID4gPiA+IGNoYW5nZXMgdXNpbmcg ZHVtbXlfaGNkIHdpdGggdGhlIHBhdGNoIGJlbG93Pwo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4g SSdtIG5vdCBzdXJlIHdoYXQgdG8gbWFrZSBvZiB0aGUgdGVzdCByZXN1bHRzLiBJIGdldCB0aGUg c2FtZSByZXN1bHRzCj4gPiA+ID4gPiA+IHdpdGggb3Igd2l0aG91dCB0aGUgcGF0Y2guIFdoaWNo IEkgZ3Vlc3MgbWFrZXMgc2Vuc2UuLi4gaW4gZHVtbXlfcXVldWUsCj4gPiA+ID4gPiA+IHRoaXMg aXMgZ2V0dGluZyBoaXQgd2hlbiB0aGUgdXZjIGZ1bmN0aW9uIGRyaXZlciB0cmllcyB0byBjb21w bGV0ZSB0aGUKPiA+ID4gPiA+ID4gZGVsYXllZCBzdGF0dXM6Cj4gPiA+ID4gPiA+IAo+ID4gPiA+ ID4gPiAJcmVxID0gdXNiX3JlcXVlc3RfdG9fZHVtbXlfcmVxdWVzdChfcmVxKTsKPiA+ID4gPiA+ ID4gCWlmICghX3JlcSB8fCAhbGlzdF9lbXB0eSgmcmVxLT5xdWV1ZSkgfHwgIV9yZXEtPmNvbXBs ZXRlKQo+ID4gPiA+ID4gPiAJCXJldHVybiAtRUlOVkFMOwo+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ ID4gU28gdGhlIGRlbGF5ZWQvZXhwbGljaXQgc3RhdHVzIHN0YWdlIGlzIG5ldmVyIGNvbXBsZXRl ZCwgYWZhaWN0Lgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBJIHByZXN1bWUgeW91IGFyZSBoaXR0aW5n IHRoZSAhbGlzdF9lbXB0eSgmcmVxLT5xdWV1ZSkgdGVzdCwgeWVzPyAgVGhlIAo+ID4gPiA+ID4g b3RoZXIgdHdvIHRlc3RzIGFyZSB0cml2aWFsLgo+ID4gPiA+IAo+ID4gPiA+IFllcywgdGhhdCBp cyB3aGF0J3MgaGFwcGVuaW5nLgo+ID4gPiA+IAo+ID4gPiA+ID4gVHJpZ2dlcmluZyB0aGUgIWxp c3RfZW1wdHkoKSB0ZXN0IG1lYW5zIHRoZSByZXF1ZXN0IGhhcyBhbHJlYWR5IGJlZW4KPiA+ID4g PiA+IHN1Ym1pdHRlZCBhbmQgbm90IHlldCBjb21wbGV0ZWQuICBUaGlzIHByb2JhYmx5IGluZGlj YXRlcyB0aGVyZSBpcyBhCj4gPiA+ID4gPiBidWcgaW4gdGhlIHV2YyBmdW5jdGlvbiBkcml2ZXIg Y29kZS4KPiA+ID4gPiAKPiA+ID4gPiBUaGUgdXZjIGZ1bmN0aW9uIGRyaXZlciB3b3JrcyB3aXRo IG11c2IsIHRob3VnaCA6Lwo+ID4gPiA+IAo+ID4gPiA+IEkgY29tcGFyZWQgdGhlIHNlcXVlbmNl IG9mIGNhbGxzIHRvIHRoZSB1dmMgc2V0dXAsIGNvbXBsZXRpb24gaGFuZGxlciwKPiA+ID4gPiBh bmQgc3RhdHVzIHN0YWdlIHNlbmRpbmcsIGFuZCBmb3Igc29tZSByZWFzb24gZHVtbXlfaGNkLCBh ZnRlciBhbiBPVVQKPiA+ID4gPiBzZXR1cC1jb21wbGV0aW9uLXN0YXR1cyBzZXF1ZW5jZSwgY2Fs bHMgYSBjb21wbGV0aW9uLXN0YXR1cy1jb21wbGV0aW9uCj4gPiA+ID4gc2VxdWVuY2UsIGFuZCB0 aGVuIGdvZXMgb24gdGhlIHRoZSBuZXh0IHJlcXVlc3QuIG11c2Igc2ltcGx5IGdvZXMgb24gdG8K PiA+ID4gPiB0aGUgbmV4dCByZXF1ZXN0IGFmdGVyIHRoZSBzZXR1cC1jb21wbGV0aW9uLXN0YXR1 cyBzZXF1ZW5jZS4KPiA+ID4gCj4gPiA+IEkgZG9uJ3QgcXVpdGUgdW5kZXJzdGFuZC4gIFRoZXJl J3MgYSBjb250cm9sLU9VVCB0cmFuc2ZlciwgdGhlIHNldHVwLCAKPiA+ID4gZGF0YSwgYW5kIHN0 YXR1cyB0cmFuc2FjdGlvbnMgYWxsIGNvbXBsZXRlIG5vcm1hbGx5LCBhbmQgdGhlbiB3aGF0IAo+ ID4gPiBoYXBwZW5zPyAgV2hhdCBkbyB5b3UgbWVhbiBieSAiYSBjb21wbGV0aW9uLXN0YXR1cy1j b21wbGV0aW9uIAo+ID4gPiBzZXF1ZW5jZSI/ICBBIG1vcmUgZGV0YWlsZWQgZGVzY3JpcHRpb24g d291bGQgaGVscC4KPiA+ID4gCj4gPiAKPiA+IEkgbWVhbnQgdGhlIGZ1bmN0aW9ucyAocHJvY2Vk dXJlcykgaW4gdGhlIGZ1bmN0aW9uIGRyaXZlciwgc28gdGhlIHNldHVwCj4gPiBoYW5kbGVyICh1 dmNfZnVuY3Rpb25fc2V0dXApLCB0aGUgY29tcGxldGlvbiBoYW5kbGVyCj4gPiAodXZjX2Z1bmN0 aW9uX2VwMF9jb21wbGV0ZSksIGFuZCB0aGUgc3RhdHVzIHNlbmRlciAodXZjX3NlbmRfcmVzcG9u c2UpLAo+ID4gYWx0aG91Z2ggdGhlIGxhc3Qgb25lIGFjdHVhbGx5IHNlbmRzIHRoZSBkYXRhIHN0 YWdlIGZvciBjb250cm9sIElOLgo+ID4gU28gYWZ0ZXIgdGhlIHN0YXR1cyBpcyBzZW50IG9uIHRo ZSB1dmMgZ2FkZ2V0IGRyaXZlcidzIGVuZCwgaXRzCj4gPiBjb21wbGV0aW9uIGhhbmRsZXIgaXMg Y2FsbGVkIGFnYWluIHdpdGhvdXQgdGhlIHNldHVwIGhhbmRsZXIgYmVpbmcKPiA+IGNhbGxlZCBi ZWZvcmVoYW5kIGFuZCBJIGNhbnQgZmlndXJlIG91dCB3aHkuCj4gCj4gSXNuJ3QgdGhpcyB3aGF0 IHlvdSBzaG91bGQgZXhwZWN0PyAgRXZlcnkgdXNiX3JlcXVlc3QsIGlmIGl0IGlzIHF1ZXVlZAo+ IHN1Y2Nlc3NmdWxseSwgZXZlbnR1YWxseSBnZXRzIGEgY29tcGxldGlvbiBjYWxsYmFjay4gIFRo YXQgcHJvbWlzZSBpcwo+IG1hZGUgYnkgZXZlcnkgVURDIGRyaXZlcjsgaXQncyBwYXJ0IG9mIHRo ZSBnYWRnZXQgQVBJLiAgU28gZm9yIGEKPiBjb250cm9sIHRyYW5zZmVyIHdpdGggYSBkYXRhIHN0 YWdlLCB5b3UgZXhwZWN0IHRvIGhhdmU6Cj4gCj4gCVNldHVwIGhhbmRsZXIgY2FsbGVkCj4gCURh dGEtc3RhZ2UgcmVxdWVzdCBzdWJtaXR0ZWQKPiAJRGF0YS1zdGFnZSByZXF1ZXN0IGNvbXBsZXRp b24gY2FsbGJhY2sKPiAJU3RhdHVzLXN0YWdlIHJlcXVlc3Qgc3VibWl0dGVkCj4gCVN0YXR1cy1z dGFnZSByZXF1ZXN0IGNvbXBsZXRpb24gY2FsbGJhY2sKPiAKPiBUaHVzLCB0d28gY29tcGxldGlv biBjYWxsYmFja3MgYnV0IG9ubHkgb25lIHNldHVwIGNhbGxiYWNrLgoKb21nIGhvdyBkaWQgSSBu b3Qgbm90aWNlIHRoaXMgOi8KCkkgZ3Vlc3MgSSBoYXZlIHRvIGZpeCB0aGUgdXZjIGZ1bmN0aW9u IGRyaXZlciBzbyBpdCB3b3JrcyB3aXRoIHRoYXQuCm11c2IgZG9lc24ndCBjYWxsIHRoZSBzdGF0 dXMgc3RhZ2UgY29tcGxldGlvbiBjYWxsYmFjayB0aG91Z2g7IG5vdCB0aGF0Cml0IGRvZXMgYW55 dGhpbmcgc28gaXQgc2VlbXMgZmluZSB0byBtZSwgYnV0IGluZGVlZCB0aGUgZnVuY3Rpb24gZHJp dmVyCmhhcyB0byBiZSByZWFkeSBmb3IgaXQgaWYgaXQgaXMgY2FsbGVkLgoKPiA+ID4gPiBJIGNv bW1lbnRlZCBvdXQgdGhlIHBhcmFub2lhIGJsb2NrIGluIGR1bW15X3RpbWVyLCBhbmQgZHVtbXlf aGNkIHN0aWxsCj4gPiA+ID4gZG9lcyB0aGUgZXh0cmEgY29tcGxldGlvbiwgYnV0IGl0IGRvZXNu J3QgZXJyb3Igb3V0IGFueW1vcmUuIEkgZG91YnQKPiA+ID4gPiB0aGF0J3MgdGhlL2Egc29sdXRp b24gdGhvdWdoLCBlc3BlY2lhbGx5IHNpbmNlIEkgZ2V0Ogo+ID4gPiA+IAo+ID4gPiA+IFsgICAy Mi42MTY1NzddIHV2Y3ZpZGVvOiBGYWlsZWQgdG8gcXVlcnkgKDEyOSkgVVZDIHByb2JlIGNvbnRy b2wgOiAtNzUgKGV4cC4gMjYpLgo+ID4gPiA+IFsgICAyMi42MjQ0ODFdIHV2Y3ZpZGVvOiBGYWls ZWQgdG8gaW5pdGlhbGl6ZSB0aGUgZGV2aWNlICgtNSkuCj4gPiA+ID4gCj4gPiA+ID4gTm90IHN1 cmUgaWYgdGhhdCdzIGEgcmVzdWx0IG9mIGR1bW15X2hjZCBub3Qgc3VwcG9ydGluZyBpc29jaHJv bm91cwo+ID4gPiA+IHRyYW5zZmVycyBvciBub3QuCj4gPiA+ID4gCj4gPiA+ID4gSSdtIG5vdCBz dXJlIHdoZXJlIHRvIGNvbnRpbnVlIGludmVzdGlnYXRpbmcgOi8KPiA+ID4gCj4gPiA+IFBlcmhh cHMgcmVtb3ZpbmcgdGhlICIjaWYgMCIgcHJvdGVjdGluZyB0aGUgZGV2X2RiZyBsaW5lIGluIAo+ ID4gPiBkdW1teV9xdWV1ZSgpIHdvdWxkIHByb3ZpZGUgc29tZSBoZWxwZnVsIG91dHB1dC4KPiA+ IAo+ID4gSXQgZGlkLCBidXQgZGlkbid0IGdldCBtZSBtdWNoIGZhcnRoZXIgOi8KPiA+IAo+ID4g PiBBbm90aGVyIHRoaW5nIHRvIGNoZWNrIHdvdWxkIGJlIGlmIHRoZSAiaW1wbGVtZW50IGFuIGVt dWxhdGVkIAo+ID4gPiBzaW5nbGUtcmVxdWVzdCBGSUZPIiBpbiBkdW1teV9xdWV1ZSgpIGlzIGNh dXNpbmcgdHJvdWJsZS4gIFRoZXJlJ3Mgbm8gCj4gPiA+IGhhcm0gaW4gcmVwbGFjaW5nIHRoZSBs b25nICJpZiIgY29uZGl0aW9uIHdpdGggImlmICgwKSIuCj4gPiAKPiA+IFRoYXQgZGlkbid0IGNo YW5nZSBhbnl0aGluZy4KPiA+IAo+ID4gQWx0aG91Z2ggSSBkaWQgbm90aWNlIHRoYXQgdGhlIGR1 bW15X3F1ZXVlIHRoYXQgY2FsbHMgdGhlIGNvbXBsZXRpb24KPiA+IGhhbmRsZXIgd2l0aG91dCB0 aGUgcHJlY2VlZGluZyBzZXR1cCBoYW5kbGVyIHNheXMgdGhhdCBpdCdzIGluIHRoZQo+ID4gc3Rh dHVzIHN0YWdlIChlcC0+c3RhdHVzX3N0YWdlID09IDEpLgo+IAo+IFRoYXQgaXMgY29uc2lzdGVu dCB3aXRoIHRoZSBldmVudHMgb3V0bGluZWQgYWJvdmUuCgoKVGhhbmtzLAoKUGF1bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F027C43387 for ; Fri, 18 Jan 2019 16:31:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F238A20850 for ; Fri, 18 Jan 2019 16:31:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="U3bMpzTX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728341AbfARQbS (ORCPT ); Fri, 18 Jan 2019 11:31:18 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:53804 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727346AbfARQbS (ORCPT ); Fri, 18 Jan 2019 11:31:18 -0500 Received: from localhost.localdomain (unknown [96.44.9.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E642153E; Fri, 18 Jan 2019 17:31:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1547829075; bh=8hr+puCZKU3CkrjGCLHvQPZ4wsY5ygkfShhzYrcLtgQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U3bMpzTXF2MmTDhR/baQlxW7nGIo2hBsH4DFYjZ5dOBjLHZCnrq9vzD3TRDi44E7b q5VhRRI3eqcc84O7OUXtLQ4xoFVUsukzjOlPdHjx82u9qdIOgH2vifv5oSQOsX8aPa MNRLM45UrIycGtY/B+aHggs+RfHEdrAneQ5Wxpxs= Date: Fri, 18 Jan 2019 11:31:06 -0500 From: Paul Elder To: Alan Stern Cc: laurent.pinchart@ideasonboard.com, kieran.bingham@ideasonboard.com, b-liu@ti.com, rogerq@ti.com, balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 4/6] usb: gadget: add mechanism to specify an explicit status stage Message-ID: <20190118163106.GC7331@localhost.localdomain> References: <20190116050029.GA13084@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 16, 2019 at 10:06:53AM -0500, Alan Stern wrote: > On Wed, 16 Jan 2019, Paul Elder wrote: > > > On Mon, Jan 14, 2019 at 10:24:44AM -0500, Alan Stern wrote: > > > On Mon, 14 Jan 2019, Paul Elder wrote: > > > > > > > > > > Can you check your uvc > > > > > > > changes using dummy_hcd with the patch below? > > > > > > > > > > > > I'm not sure what to make of the test results. I get the same results > > > > > > with or without the patch. Which I guess makes sense... in dummy_queue, > > > > > > this is getting hit when the uvc function driver tries to complete the > > > > > > delayed status: > > > > > > > > > > > > req = usb_request_to_dummy_request(_req); > > > > > > if (!_req || !list_empty(&req->queue) || !_req->complete) > > > > > > return -EINVAL; > > > > > > > > > > > > So the delayed/explicit status stage is never completed, afaict. > > > > > > > > > > I presume you are hitting the !list_empty(&req->queue) test, yes? The > > > > > other two tests are trivial. > > > > > > > > Yes, that is what's happening. > > > > > > > > > Triggering the !list_empty() test means the request has already been > > > > > submitted and not yet completed. This probably indicates there is a > > > > > bug in the uvc function driver code. > > > > > > > > The uvc function driver works with musb, though :/ > > > > > > > > I compared the sequence of calls to the uvc setup, completion handler, > > > > and status stage sending, and for some reason dummy_hcd, after an OUT > > > > setup-completion-status sequence, calls a completion-status-completion > > > > sequence, and then goes on the the next request. musb simply goes on to > > > > the next request after the setup-completion-status sequence. > > > > > > I don't quite understand. There's a control-OUT transfer, the setup, > > > data, and status transactions all complete normally, and then what > > > happens? What do you mean by "a completion-status-completion > > > sequence"? A more detailed description would help. > > > > > > > I meant the functions (procedures) in the function driver, so the setup > > handler (uvc_function_setup), the completion handler > > (uvc_function_ep0_complete), and the status sender (uvc_send_response), > > although the last one actually sends the data stage for control IN. > > So after the status is sent on the uvc gadget driver's end, its > > completion handler is called again without the setup handler being > > called beforehand and I cant figure out why. > > Isn't this what you should expect? Every usb_request, if it is queued > successfully, eventually gets a completion callback. That promise is > made by every UDC driver; it's part of the gadget API. So for a > control transfer with a data stage, you expect to have: > > Setup handler called > Data-stage request submitted > Data-stage request completion callback > Status-stage request submitted > Status-stage request completion callback > > Thus, two completion callbacks but only one setup callback. omg how did I not notice this :/ I guess I have to fix the uvc function driver so it works with that. musb doesn't call the status stage completion callback though; not that it does anything so it seems fine to me, but indeed the function driver has to be ready for it if it is called. > > > > I commented out the paranoia block in dummy_timer, and dummy_hcd still > > > > does the extra completion, but it doesn't error out anymore. I doubt > > > > that's the/a solution though, especially since I get: > > > > > > > > [ 22.616577] uvcvideo: Failed to query (129) UVC probe control : -75 (exp. 26). > > > > [ 22.624481] uvcvideo: Failed to initialize the device (-5). > > > > > > > > Not sure if that's a result of dummy_hcd not supporting isochronous > > > > transfers or not. > > > > > > > > I'm not sure where to continue investigating :/ > > > > > > Perhaps removing the "#if 0" protecting the dev_dbg line in > > > dummy_queue() would provide some helpful output. > > > > It did, but didn't get me much farther :/ > > > > > Another thing to check would be if the "implement an emulated > > > single-request FIFO" in dummy_queue() is causing trouble. There's no > > > harm in replacing the long "if" condition with "if (0)". > > > > That didn't change anything. > > > > Although I did notice that the dummy_queue that calls the completion > > handler without the preceeding setup handler says that it's in the > > status stage (ep->status_stage == 1). > > That is consistent with the events outlined above. Thanks, Paul