From: "John W. Linville" <linville@tuxdriver.com>
To: "Maciej Żenczykowski" <zenczykowski@gmail.com>
Cc: "Maciej Żenczykowski" <maze@google.com>,
"Jeff Garzik" <jgarzik@pobox.com>,
"Ben Hutchings" <ben@decadent.org.uk>,
"David S . Miller" <davem@davemloft.net>,
"David Decotigny" <decot@google.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] ethtool: zero initialize coalesce struct
Date: Fri, 18 Jan 2019 13:40:02 -0500 [thread overview]
Message-ID: <20190118184002.GC30266@tuxdriver.com> (raw)
In-Reply-To: <20181215011923.246179-1-zenczykowski@gmail.com>
On Fri, Dec 14, 2018 at 05:19:23PM -0800, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@google.com>
>
> prior to fetching it from kernel.
>
> Otherwise we run the risk of very tail portion of it (dmac field)
> being left entirely uninitialized, and likely containing some sort
> of stale data.
>
> It seems to likely be some sort of time (a second's counter).
>
> Tested:
> 'ethtool -c eth1' with old kernel now reports 'dmac: 0' where
> previously it reported some sort of second counter.
>
> Signed-off-by: Maciej Żenczykowski <maze@google.com>
Queued for next release.
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2019-01-18 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-15 1:19 [PATCH] ethtool: zero initialize coalesce struct Maciej Żenczykowski
2018-12-15 2:26 ` Michal Kubecek
2018-12-15 2:30 ` Maciej Żenczykowski
2018-12-15 12:29 ` Ben Hutchings
2019-01-18 18:40 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190118184002.GC30266@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=jgarzik@pobox.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=zenczykowski@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.