From: Yangtao Li <tiny.windzz@gmail.com>
To: myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
cw00.choi@samsung.com, linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Yangtao Li <tiny.windzz@gmail.com>
Subject: [PATCH 3/3] PM / devfreq: fix mem leak in devfreq_add_device()
Date: Sat, 19 Jan 2019 11:04:54 -0500 [thread overview]
Message-ID: <20190119160454.23151-3-tiny.windzz@gmail.com> (raw)
In-Reply-To: <20190119160454.23151-1-tiny.windzz@gmail.com>
'devfreq' is malloced in devfreq_add_device() and should be freed in
the error handling cases, otherwise it will cause memory leak.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/devfreq/devfreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 923889229a0b..fe6c157cb7e0 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -651,7 +651,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
mutex_unlock(&devfreq->lock);
err = set_freq_table(devfreq);
if (err < 0)
- goto err_out;
+ goto err_dev;
mutex_lock(&devfreq->lock);
}
--
2.17.0
next prev parent reply other threads:[~2019-01-19 16:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190119183407epcas1p4958e4526d07c36605307c49b0c0e2e2c@epcas1p4.samsung.com>
2019-01-19 16:04 ` [PATCH 1/3] PM / devfreq: fix indentation in devfreq_add_device() Yangtao Li
2019-01-19 16:04 ` [PATCH 2/3] PM / devfreq: fix missing check of return value " Yangtao Li
2019-01-21 1:27 ` MyungJoo Ham
2019-01-19 16:04 ` Yangtao Li [this message]
2019-01-21 1:23 ` [PATCH 3/3] PM / devfreq: fix mem leak " MyungJoo Ham
2019-01-21 1:42 ` Chanwoo Choi
2019-01-21 1:58 ` [PATCH 1/3] PM / devfreq: fix indentation " Chanwoo Choi
2019-01-21 16:39 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190119160454.23151-3-tiny.windzz@gmail.com \
--to=tiny.windzz@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.