From: Jonathan Cameron <jic23@kernel.org>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: Sebastien Bourdelin <sebastien.bourdelin@gmail.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, mark.rutland@arm.com,
robh+dt@kernel.org, pmeerw@pmeerw.net, lars@metafoo.de,
knaack.h@gmx.de
Subject: Re: [PATCH v3 1/2] iio: chemical: bme680: Add device-tree support
Date: Sat, 19 Jan 2019 17:44:18 +0000 [thread overview]
Message-ID: <20190119174418.32cb9a3f@archlinux> (raw)
In-Reply-To: <20190115184713.GC10186@himanshu-Vostro-3559>
On Wed, 16 Jan 2019 00:17:13 +0530
Himanshu Jha <himanshujha199640@gmail.com> wrote:
> On Mon, Jan 14, 2019 at 03:19:13PM -0500, Sebastien Bourdelin wrote:
> > This commit allow the driver to work with device-tree.
> >
> > Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@gmail.com>
> > ---
>
> Acked-by: Himanshu Jha <himanshujha199640@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it and see if we missed anything.
Thanks,
Jonathan
>
> Thanks!
>
> > v2 -> v3:
> > - remove of_match_ptr: Suggested by Jonathan Cameron <jic23@kernel.org>
> > - minor style fixup
> > - rebase on master
> > v1 -> v2:
> > - add missing of.h header in bme680_spi.c
> > ---
> > drivers/iio/chemical/bme680_i2c.c | 7 +++++++
> > drivers/iio/chemical/bme680_spi.c | 8 ++++++++
> > 2 files changed, 15 insertions(+)
> >
> > diff --git a/drivers/iio/chemical/bme680_i2c.c b/drivers/iio/chemical/bme680_i2c.c
> > index 06d4be539d2e..b2f805b6b36a 100644
> > --- a/drivers/iio/chemical/bme680_i2c.c
> > +++ b/drivers/iio/chemical/bme680_i2c.c
> > @@ -70,10 +70,17 @@ static const struct acpi_device_id bme680_acpi_match[] = {
> > };
> > MODULE_DEVICE_TABLE(acpi, bme680_acpi_match);
> >
> > +static const struct of_device_id bme680_of_i2c_match[] = {
> > + { .compatible = "bosch,bme680", },
> > + {},
> > +};
> > +MODULE_DEVICE_TABLE(of, bme680_of_i2c_match);
> > +
> > static struct i2c_driver bme680_i2c_driver = {
> > .driver = {
> > .name = "bme680_i2c",
> > .acpi_match_table = ACPI_PTR(bme680_acpi_match),
> > + .of_match_table = bme680_of_i2c_match,
> > },
> > .probe = bme680_i2c_probe,
> > .id_table = bme680_i2c_id,
> > diff --git a/drivers/iio/chemical/bme680_spi.c b/drivers/iio/chemical/bme680_spi.c
> > index c9fb05e8d0b9..d0b7bdd3f066 100644
> > --- a/drivers/iio/chemical/bme680_spi.c
> > +++ b/drivers/iio/chemical/bme680_spi.c
> > @@ -6,6 +6,7 @@
> > */
> > #include <linux/acpi.h>
> > #include <linux/module.h>
> > +#include <linux/of.h>
> > #include <linux/regmap.h>
> > #include <linux/spi/spi.h>
> >
> > @@ -110,10 +111,17 @@ static const struct acpi_device_id bme680_acpi_match[] = {
> > };
> > MODULE_DEVICE_TABLE(acpi, bme680_acpi_match);
> >
> > +static const struct of_device_id bme680_of_spi_match[] = {
> > + { .compatible = "bosch,bme680", },
> > + {},
> > +};
> > +MODULE_DEVICE_TABLE(of, bme680_of_spi_match);
> > +
> > static struct spi_driver bme680_spi_driver = {
> > .driver = {
> > .name = "bme680_spi",
> > .acpi_match_table = ACPI_PTR(bme680_acpi_match),
> > + .of_match_table = bme680_of_spi_match,
> > },
> > .probe = bme680_spi_probe,
> > .id_table = bme680_spi_id,
> > --
> > 2.20.1
> >
>
prev parent reply other threads:[~2019-01-19 17:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 20:19 [PATCH v3 1/2] iio: chemical: bme680: Add device-tree support Sebastien Bourdelin
2019-01-14 20:19 ` [PATCH v3 2/2] dt-bindings: iio: chemical: Add bindings for bme680 Sebastien Bourdelin
2019-01-15 18:45 ` Himanshu Jha
2019-01-15 20:28 ` Rob Herring
2019-01-15 20:28 ` Rob Herring
2019-01-19 17:44 ` Jonathan Cameron
2019-01-15 18:47 ` [PATCH v3 1/2] iio: chemical: bme680: Add device-tree support Himanshu Jha
2019-01-19 17:44 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190119174418.32cb9a3f@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=himanshujha199640@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sebastien.bourdelin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.