From: Jiri Pirko <jiri@resnulli.us>
To: Eran Ben Elisha <eranbe@mellanox.com>
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
Ariel Almog <ariela@mellanox.com>, Aya Levin <ayal@mellanox.com>,
Moshe Shemesh <moshe@mellanox.com>
Subject: Re: [PATCH net-next v2 03/11] devlink: Add health report functionality
Date: Sun, 20 Jan 2019 12:27:57 +0100 [thread overview]
Message-ID: <20190120112757.GG2730@nanopsycho> (raw)
In-Reply-To: <1547762360-7075-4-git-send-email-eranbe@mellanox.com>
Thu, Jan 17, 2019 at 10:59:12PM CET, eranbe@mellanox.com wrote:
[...]
>+
>+TRACE_EVENT(devlink_health_recover_aborted,
>+ TP_PROTO(const struct devlink *devlink, const char *reporter_name,
>+ bool health_state, u64 time_since_last_recover),
>+
>+ TP_ARGS(devlink, reporter_name, health_state, time_since_last_recover),
>+
>+ TP_STRUCT__entry(
>+ __string(bus_name, devlink->dev->bus->name)
>+ __string(dev_name, dev_name(devlink->dev))
>+ __string(driver_name, devlink->dev->driver->name)
>+ __string(reporter_name, reporter_name)
>+ __field(bool, health_state)
>+ __field(u64, time_since_last_recover)
>+ ),
>+
>+ TP_fast_assign(
>+ __assign_str(bus_name, devlink->dev->bus->name);
>+ __assign_str(dev_name, dev_name(devlink->dev));
>+ __assign_str(driver_name, devlink->dev->driver->name);
>+ __assign_str(reporter_name, reporter_name);
>+ __entry->health_state = health_state;
>+ __entry->time_since_last_recover = time_since_last_recover;
>+ ),
>+
>+ TP_printk("bus_name=%s dev_name=%s driver_name=%s reporter_name=%s: health_state=%d time_since_last_recover = %llu recover aborted",
Drop spaces around "=".
Otherwise, this looks fine.
Acked-by: Jiri Pirko <jiri@mellanox.com>
next prev parent reply other threads:[~2019-01-20 11:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 21:59 [PATCH net-next v2 00/11] Devlink health reporting and recovery system Eran Ben Elisha
2019-01-17 21:59 ` [PATCH net-next v2 01/11] devlink: Add health buffer support Eran Ben Elisha
2019-01-20 10:03 ` Jiri Pirko
2019-01-20 11:06 ` Eran Ben Elisha
2019-01-20 11:08 ` Jiri Pirko
2019-01-20 18:45 ` David Miller
2019-01-21 11:07 ` Eran Ben Elisha
2019-01-21 12:08 ` Jiri Pirko
2019-01-20 11:20 ` Jiri Pirko
2019-01-17 21:59 ` [PATCH net-next v2 02/11] devlink: Add health reporter create/destroy functionality Eran Ben Elisha
2019-01-20 11:49 ` Jiri Pirko
2019-01-17 21:59 ` [PATCH net-next v2 03/11] devlink: Add health report functionality Eran Ben Elisha
2019-01-20 11:27 ` Jiri Pirko [this message]
2019-01-21 11:12 ` Eran Ben Elisha
2019-01-17 21:59 ` [PATCH net-next v2 04/11] devlink: Add health get command Eran Ben Elisha
2019-01-20 11:31 ` Jiri Pirko
2019-01-17 21:59 ` [PATCH net-next v2 05/11] devlink: Add health set command Eran Ben Elisha
2019-01-20 11:32 ` Jiri Pirko
2019-01-17 21:59 ` [PATCH net-next v2 06/11] devlink: Add health recover command Eran Ben Elisha
2019-01-20 11:33 ` Jiri Pirko
2019-01-17 21:59 ` [PATCH net-next v2 07/11] devlink: Add health diagnose command Eran Ben Elisha
2019-01-20 11:38 ` Jiri Pirko
2019-01-17 21:59 ` [PATCH net-next v2 08/11] devlink: Add health dump {get,clear} commands Eran Ben Elisha
2019-01-17 21:59 ` [PATCH net-next v2 09/11] net/mlx5e: Add TX reporter support Eran Ben Elisha
2019-01-20 11:06 ` Jiri Pirko
2019-01-21 11:32 ` Eran Ben Elisha
2019-01-21 12:11 ` Jiri Pirko
2019-01-21 13:06 ` Eran Ben Elisha
2019-01-21 13:45 ` Jiri Pirko
2019-01-17 21:59 ` [PATCH net-next v2 10/11] net/mlx5e: Add TX timeout support for mlx5e TX reporter Eran Ben Elisha
2019-01-17 21:59 ` [PATCH net-next v2 11/11] devlink: Add Documentation/networking/devlink-health.txt Eran Ben Elisha
2019-01-18 22:59 ` [PATCH net-next v2 00/11] Devlink health reporting and recovery system David Miller
2019-01-20 9:27 ` [PATCH iproute2-next v2] devlink: Add health command support Aya Levin
2019-01-23 3:37 ` David Ahern
2019-01-23 11:27 ` Aya Levin
2019-01-24 0:27 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190120112757.GG2730@nanopsycho \
--to=jiri@resnulli.us \
--cc=ariela@mellanox.com \
--cc=ayal@mellanox.com \
--cc=davem@davemloft.net \
--cc=eranbe@mellanox.com \
--cc=jiri@mellanox.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.