From: Boris Brezillon <bbrezillon@kernel.org>
To: "Bean Huo (beanhuo)" <beanhuo@micron.com>
Cc: "boris.brezillon@bootlin.com" <boris.brezillon@bootlin.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"richard@nod.at" <richard@nod.at>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>
Subject: Re: [RESEND PATCH V2 2/2] mtd: core: NAND filling block
Date: Sun, 20 Jan 2019 18:36:55 +0100 [thread overview]
Message-ID: <20190120183538.5bd14c84@bbrezillon> (raw)
In-Reply-To: <BYAPR08MB4533401FB969CA9A8D254F34DB9C0@BYAPR08MB4533.namprd08.prod.outlook.com>
On Fri, 18 Jan 2019 22:12:04 +0000
"Bean Huo (beanhuo)" <beanhuo@micron.com> wrote:
> +static int check_page_if_emtpy(struct nand_chip *chip, char *data)
> +{
> + struct mtd_info *mtd = nand_to_mtd(chip);
> + int ret, i;
> + void *databuf, *eccbuf;
> + int max_bitflips;
> + struct mtd_oob_region oobregion;
> +
> + mtd_ooblayout_ecc(mtd, 0, &oobregion);
> + eccbuf = chip->oob_poi + oobregion.offset;
> + databuf = data;
> + max_bitflips = 0;
> +
> + for (i = 0; i < chip->ecc.steps; i++) {
> + ret = nand_check_erased_ecc_chunk(data,
> + chip->ecc.size,
> + eccbuf,
> + chip->ecc.bytes,
> + NULL, 0,
> + chip->ecc.strength);
> + if (ret >= 0)
> + max_bitflips = max(ret, max_bitflips);
> + else
> + return false;
> +
> + databuf += chip->ecc.size;
> + eccbuf += chip->ecc.bytes;
> +
> + }
You should check the whole page and not only in-band-data+ECC bytes.
Plus, the "overwrite page" trigger is not dependent on the ECC
strength, but more something related to the NAND chip itself so using
ecc->strength as a threshold sounds like a bad idea to me.
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
prev parent reply other threads:[~2019-01-20 17:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 22:12 [RESEND PATCH V2 2/2] mtd: core: NAND filling block Bean Huo (beanhuo)
2019-01-18 22:39 ` Boris Brezillon
2019-01-20 17:31 ` Boris Brezillon
2019-01-21 12:28 ` [EXT] " Bean Huo (beanhuo)
2019-01-21 12:44 ` Boris Brezillon
2019-01-25 13:39 ` Bean Huo (beanhuo)
2019-01-25 14:10 ` Boris Brezillon
2019-01-18 23:01 ` Boris Brezillon
2019-01-21 10:04 ` [EXT] " Bean Huo (beanhuo)
2019-01-21 10:12 ` Boris Brezillon
2019-01-25 13:31 ` Bean Huo (beanhuo)
2019-01-25 14:15 ` Boris Brezillon
2019-01-20 15:59 ` Miquel Raynal
2019-01-24 15:47 ` [EXT] " Bean Huo (beanhuo)
2019-01-24 20:02 ` Miquel Raynal
2019-01-20 17:36 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190120183538.5bd14c84@bbrezillon \
--to=bbrezillon@kernel.org \
--cc=beanhuo@micron.com \
--cc=boris.brezillon@bootlin.com \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.