From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>
Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, namhyung@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf top: Fix wrong hottest instruction highlighted
Date: Sun, 20 Jan 2019 19:40:43 +0100 [thread overview]
Message-ID: <20190120184043.GD8591@krava> (raw)
In-Reply-To: <20190120160523.4391-1-hekuang@huawei.com>
On Mon, Jan 21, 2019 at 12:05:22AM +0800, He Kuang wrote:
> Annotation line's percentage is compared and inserted into rbtree, but the
> percent field of 'struct annotation_data' is an array, the comparison
> result between them is the address difference.
>
> This patch compares the right slot of percent array according to
> opts->percent_type and makes things right.
>
> The problem can be reproduced by pressing 'H' in perf top annotation view.
> It should highlight the instruction line which has the highest sampling
> percentage.
>
> Signed-off-by: He Kuang <hekuang@huawei.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2019-01-20 18:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-20 16:05 [PATCH] perf top: Fix wrong hottest instruction highlighted He Kuang
2019-01-20 18:40 ` Jiri Olsa [this message]
2019-01-21 14:10 ` Arnaldo Carvalho de Melo
2019-01-22 11:37 ` [tip:perf/urgent] " tip-bot for He Kuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190120184043.GD8591@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=hekuang@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.