From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH 07/11] drm/tinydrm/repaper: Use devm_drm_dev_*() Date: Sun, 20 Jan 2019 23:25:57 +0100 Message-ID: <20190120222557.GA26041@ravnborg.org> References: <20190120114318.49199-1-noralf@tronnes.org> <20190120114318.49199-8-noralf@tronnes.org> <20190120222236.GB24538@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk4.altibox.net (asavdk4.altibox.net [109.247.116.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 89BE76E0AE for ; Sun, 20 Jan 2019 22:26:00 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190120222236.GB24538@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: david@lechnology.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBKYW4gMjAsIDIwMTkgYXQgMTE6MjI6MzZQTSArMDEwMCwgU2FtIFJhdm5ib3JnIHdy b3RlOgo+IEhpIE5vcmFsZi4KPiAKPiBPbiBTdW4sIEphbiAyMCwgMjAxOSBhdCAxMjo0MzoxNFBN ICswMTAwLCBOb3JhbGYgVHLDuG5uZXMgd3JvdGU6Cj4gPiBVc2UgZGV2bV9kcm1fZGV2X2luaXQo KSwgZGV2bV9kcm1fZGV2X3JlZ2lzdGVyX3dpdGhfZmJkZXYoKSBhbmQgZHJvcAo+ID4gdXNpbmcg dGlueWRybV9kZXZpY2UuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE5vcmFsZiBUcsO4bm5lcyA8 bm9yYWxmQHRyb25uZXMub3JnPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL3Rpbnlkcm0v cmVwYXBlci5jIHwgNjMgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+ID4gIDEgZmls ZSBjaGFuZ2VkLCA0MCBpbnNlcnRpb25zKCspLCAyMyBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS90aW55ZHJtL3JlcGFwZXIuYyBiL2RyaXZlcnMvZ3B1 L2RybS90aW55ZHJtL3JlcGFwZXIuYwo+ID4gaW5kZXggMzE0MTI0MWNhOGYwLi40YzgyMDU1NjU2 NjggMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vdGlueWRybS9yZXBhcGVyLmMKPiA+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS90aW55ZHJtL3JlcGFwZXIuYwo+ID4gQEAgLTM0LDcgKzM0 LDcgQEAKPiA+ICAjaW5jbHVkZSA8ZHJtL2RybV9nZW1fZnJhbWVidWZmZXJfaGVscGVyLmg+Cj4g PiAgI2luY2x1ZGUgPGRybS9kcm1fcmVjdC5oPgo+ID4gICNpbmNsdWRlIDxkcm0vZHJtX3ZibGFu ay5oPgo+ID4gLSNpbmNsdWRlIDxkcm0vdGlueWRybS90aW55ZHJtLmg+Cj4gPiArI2luY2x1ZGUg PGRybS9kcm1fc2ltcGxlX2ttc19oZWxwZXIuaD4KPiA+ICAjaW5jbHVkZSA8ZHJtL3Rpbnlkcm0v dGlueWRybS1oZWxwZXJzLmg+Cj4gPiAgCj4gPiAgI2RlZmluZSBSRVBBUEVSX1JJRF9HMl9DT0df SUQJMHgxMgo+ID4gQEAgLTYwLDcgKzYwLDggQEAgZW51bSByZXBhcGVyX2VwZF9ib3JkZXJfYnl0 ZSB7Cj4gPiAgfTsKPiA+ICAKPiA+ICBzdHJ1Y3QgcmVwYXBlcl9lcGQgewo+ID4gLQlzdHJ1Y3Qg dGlueWRybV9kZXZpY2UgdGlueWRybTsKPiA+ICsJc3RydWN0IGRybV9kZXZpY2UgYmFzZTsKPiA+ ICsJc3RydWN0IGRybV9zaW1wbGVfZGlzcGxheV9waXBlIHBpcGU7Cj4gPiAgCXN0cnVjdCBzcGlf ZGV2aWNlICpzcGk7Cj4gPiAgCj4gPiAgCXN0cnVjdCBncGlvX2Rlc2MgKnBhbmVsX29uOwo+ID4g QEAgLTg5LDEwICs5MCw5IEBAIHN0cnVjdCByZXBhcGVyX2VwZCB7Cj4gPiAgCWJvb2wgcGFydGlh bDsKPiA+ICB9Owo+ID4gIAo+ID4gLXN0YXRpYyBpbmxpbmUgc3RydWN0IHJlcGFwZXJfZXBkICoK PiA+IC1lcGRfZnJvbV90aW55ZHJtKHN0cnVjdCB0aW55ZHJtX2RldmljZSAqdGRldikKPiA+ICtz dGF0aWMgaW5saW5lIHN0cnVjdCByZXBhcGVyX2VwZCAqZHJtX3RvX2VwZChzdHJ1Y3QgZHJtX2Rl dmljZSAqZHJtKQo+ID4gIHsKPiA+IC0JcmV0dXJuIGNvbnRhaW5lcl9vZih0ZGV2LCBzdHJ1Y3Qg cmVwYXBlcl9lcGQsIHRpbnlkcm0pOwo+ID4gKwlyZXR1cm4gY29udGFpbmVyX29mKGRybSwgc3Ry dWN0IHJlcGFwZXJfZXBkLCBiYXNlKTsKPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIGludCByZXBh cGVyX3NwaV90cmFuc2ZlcihzdHJ1Y3Qgc3BpX2RldmljZSAqc3BpLCB1OCBoZWFkZXIsCj4gPiBA QCAtNTMwLDggKzUzMCw3IEBAIHN0YXRpYyBpbnQgcmVwYXBlcl9mYl9kaXJ0eShzdHJ1Y3QgZHJt X2ZyYW1lYnVmZmVyICpmYikKPiA+ICB7Cj4gPiAgCXN0cnVjdCBkcm1fZ2VtX2NtYV9vYmplY3Qg KmNtYV9vYmogPSBkcm1fZmJfY21hX2dldF9nZW1fb2JqKGZiLCAwKTsKPiA+ICAJc3RydWN0IGRt YV9idWZfYXR0YWNobWVudCAqaW1wb3J0X2F0dGFjaCA9IGNtYV9vYmotPmJhc2UuaW1wb3J0X2F0 dGFjaDsKPiA+IC0Jc3RydWN0IHRpbnlkcm1fZGV2aWNlICp0ZGV2ID0gZmItPmRldi0+ZGV2X3By aXZhdGU7Cj4gPiAtCXN0cnVjdCByZXBhcGVyX2VwZCAqZXBkID0gZXBkX2Zyb21fdGlueWRybSh0 ZGV2KTsKPiA+ICsJc3RydWN0IHJlcGFwZXJfZXBkICplcGQgPSBkcm1fdG9fZXBkKGZiLT5kZXYp Owo+ID4gIAlzdHJ1Y3QgZHJtX3JlY3QgY2xpcDsKPiA+ICAJdTggKmJ1ZiA9IE5VTEw7Cj4gPiAg CWludCByZXQgPSAwOwo+ID4gQEAgLTY0Niw4ICs2NDUsNyBAQCBzdGF0aWMgdm9pZCByZXBhcGVy X3BpcGVfZW5hYmxlKHN0cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZSAqcGlwZSwKPiA+ICAJ CQkJc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ID4gIAkJCQlzdHJ1Y3QgZHJt X3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSkKPiA+ICB7Cj4gPiAtCXN0cnVjdCB0aW55ZHJtX2Rl dmljZSAqdGRldiA9IHBpcGVfdG9fdGlueWRybShwaXBlKTsKPiA+IC0Jc3RydWN0IHJlcGFwZXJf ZXBkICplcGQgPSBlcGRfZnJvbV90aW55ZHJtKHRkZXYpOwo+ID4gKwlzdHJ1Y3QgcmVwYXBlcl9l cGQgKmVwZCA9IGRybV90b19lcGQocGlwZS0+Y3J0Yy5kZXYpOwo+ID4gIAlzdHJ1Y3Qgc3BpX2Rl dmljZSAqc3BpID0gZXBkLT5zcGk7Cj4gPiAgCXN0cnVjdCBkZXZpY2UgKmRldiA9ICZzcGktPmRl djsKPiA+ICAJYm9vbCBkY19vayA9IGZhbHNlOwo+ID4gQEAgLTc4MSw4ICs3NzksNyBAQCBzdGF0 aWMgdm9pZCByZXBhcGVyX3BpcGVfZW5hYmxlKHN0cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlw ZSAqcGlwZSwKPiA+ICAKPiA+ICBzdGF0aWMgdm9pZCByZXBhcGVyX3BpcGVfZGlzYWJsZShzdHJ1 Y3QgZHJtX3NpbXBsZV9kaXNwbGF5X3BpcGUgKnBpcGUpCj4gPiAgewo+ID4gLQlzdHJ1Y3QgdGlu eWRybV9kZXZpY2UgKnRkZXYgPSBwaXBlX3RvX3Rpbnlkcm0ocGlwZSk7Cj4gPiAtCXN0cnVjdCBy ZXBhcGVyX2VwZCAqZXBkID0gZXBkX2Zyb21fdGlueWRybSh0ZGV2KTsKPiA+ICsJc3RydWN0IHJl cGFwZXJfZXBkICplcGQgPSBkcm1fdG9fZXBkKHBpcGUtPmNydGMuZGV2KTsKPiA+ICAJc3RydWN0 IHNwaV9kZXZpY2UgKnNwaSA9IGVwZC0+c3BpOwo+ID4gIAl1bnNpZ25lZCBpbnQgbGluZTsKPiA+ ICAKPiA+IEBAIC04NTYsNiArODUzLDIzIEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX3NpbXBs ZV9kaXNwbGF5X3BpcGVfZnVuY3MgcmVwYXBlcl9waXBlX2Z1bmNzID0gewo+ID4gIAkucHJlcGFy ZV9mYiA9IGRybV9nZW1fZmJfc2ltcGxlX2Rpc3BsYXlfcGlwZV9wcmVwYXJlX2ZiLAo+ID4gIH07 Cj4gPiAgCj4gPiArc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fbW9kZV9jb25maWdfZnVuY3MgcmVw YXBlcl9tb2RlX2NvbmZpZ19mdW5jcyA9IHsKPiA+ICsJLmZiX2NyZWF0ZSA9IGRybV9nZW1fZmJf Y3JlYXRlX3dpdGhfZGlydHksCj4gPiArCS5hdG9taWNfY2hlY2sgPSBkcm1fYXRvbWljX2hlbHBl cl9jaGVjaywKPiA+ICsJLmF0b21pY19jb21taXQgPSBkcm1fYXRvbWljX2hlbHBlcl9jb21taXQs Cj4gPiArfTsKPiA+ICsKPiA+ICtzdGF0aWMgdm9pZCByZXBhcGVyX3JlbGVhc2Uoc3RydWN0IGRy bV9kZXZpY2UgKmRybSkKPiA+ICt7Cj4gPiArCXN0cnVjdCByZXBhcGVyX2VwZCAqZXBkID0gZHJt X3RvX2VwZChkcm0pOwo+ID4gKwo+ID4gKwlEUk1fREVCVUdfRFJJVkVSKCJcbiIpOwo+ID4gKwo+ ID4gKwlkcm1fbW9kZV9jb25maWdfY2xlYW51cChkcm0pOwo+ID4gKwlkcm1fZGV2X2ZpbmkoZHJt KTsKPiA+ICsJa2ZyZWUoZXBkKTsKPiA+ICt9Cj4gPiArCj4gPiAgc3RhdGljIGNvbnN0IHVpbnQz Ml90IHJlcGFwZXJfZm9ybWF0c1tdID0gewo+ID4gIAlEUk1fRk9STUFUX1hSR0I4ODg4LAo+ID4g IH07Cj4gPiBAQCAtODk0LDYgKzkwOCw3IEBAIHN0YXRpYyBzdHJ1Y3QgZHJtX2RyaXZlciByZXBh cGVyX2RyaXZlciA9IHsKPiA+ICAJLmRyaXZlcl9mZWF0dXJlcwk9IERSSVZFUl9HRU0gfCBEUklW RVJfTU9ERVNFVCB8IERSSVZFUl9QUklNRSB8Cj4gPiAgCQkJCSAgRFJJVkVSX0FUT01JQywKPiA+ ICAJLmZvcHMJCQk9ICZyZXBhcGVyX2ZvcHMsCj4gPiArCS5yZWxlYXNlCQk9IHJlcGFwZXJfcmVs ZWFzZSwKPiA+ICAJRFJNX0dFTV9DTUFfVk1BUF9EUklWRVJfT1BTLAo+ID4gIAkubmFtZQkJCT0g InJlcGFwZXIiLAo+ID4gIAkuZGVzYwkJCT0gIlBlcnZhc2l2ZSBEaXNwbGF5cyBSZVBhcGVyIGUt aW5rIHBhbmVscyIsCj4gPiBAQCAtOTI3LDcgKzk0Miw2IEBAIHN0YXRpYyBpbnQgcmVwYXBlcl9w cm9iZShzdHJ1Y3Qgc3BpX2RldmljZSAqc3BpKQo+ID4gIAljb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNl X2lkICptYXRjaDsKPiA+ICAJc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcjsKPiA+ICAJ c3RydWN0IGRldmljZSAqZGV2ID0gJnNwaS0+ZGV2Owo+ID4gLQlzdHJ1Y3QgdGlueWRybV9kZXZp Y2UgKnRkZXY7Cj4gPiAgCWVudW0gcmVwYXBlcl9tb2RlbCBtb2RlbDsKPiA+ICAJY29uc3QgY2hh ciAqdGhlcm1hbF96b25lOwo+ID4gIAlzdHJ1Y3QgcmVwYXBlcl9lcGQgKmVwZDsKPiA+IEBAIC05 NTIsMTAgKzk2NiwyMCBAQCBzdGF0aWMgaW50IHJlcGFwZXJfcHJvYmUoc3RydWN0IHNwaV9kZXZp Y2UgKnNwaSkKPiA+ICAJCX0KPiA+ICAJfQo+ID4gIAo+ID4gLQllcGQgPSBkZXZtX2t6YWxsb2Mo ZGV2LCBzaXplb2YoKmVwZCksIEdGUF9LRVJORUwpOwo+ID4gKwllcGQgPSBremFsbG9jKHNpemVv ZigqZXBkKSwgR0ZQX0tFUk5FTCk7Cj4gPiAgCWlmICghZXBkKQo+ID4gIAkJcmV0dXJuIC1FTk9N RU07Cj4gPiAgCj4gPiArCWRybSA9ICZlcGQtPmJhc2U7Cj4gPiArCXJldCA9IGRldm1fZHJtX2Rl dl9pbml0KGRldiwgZHJtLCAmcmVwYXBlcl9kcml2ZXIpOwo+ID4gKwlpZiAocmV0KSB7Cj4gPiAr CQlrZnJlZShlcGQpOwo+ID4gKwkJcmV0dXJuIHJldDsKPiA+ICsJfQo+IEhlcmUgeW91IGdvIHRv IHRoZSB0cm91YmxlIGFuZCBmcmVlIGVwZCBvbiBlcnJvci4KPiAKPiA+ICsKPiA+ICsJZHJtX21v ZGVfY29uZmlnX2luaXQoZHJtKTsKPiA+ICsJZHJtLT5tb2RlX2NvbmZpZy5mdW5jcyA9ICZyZXBh cGVyX21vZGVfY29uZmlnX2Z1bmNzOwo+ID4gKwo+ID4gIAllcGQtPnNwaSA9IHNwaTsKPiA+ICAK PiA+ICAJZXBkLT5wYW5lbF9vbiA9IGRldm1fZ3Bpb2RfZ2V0KGRldiwgInBhbmVsLW9uIiwgR1BJ T0RfT1VUX0xPVyk7Cj4gPiBAQCAtMTA2NiwzMiArMTA5MCwyNSBAQCBzdGF0aWMgaW50IHJlcGFw ZXJfcHJvYmUoc3RydWN0IHNwaV9kZXZpY2UgKnNwaSkKPiA+ICAJaWYgKCFlcGQtPmN1cnJlbnRf ZnJhbWUpCj4gPiAgCQlyZXR1cm4gLUVOT01FTTsKPiA+ICAKPiA+IC0JdGRldiA9ICZlcGQtPnRp bnlkcm07Cj4gPiAtCj4gPiAtCXJldCA9IGRldm1fdGlueWRybV9pbml0KGRldiwgdGRldiwgJnJl cGFwZXJfZHJpdmVyKTsKPiA+IC0JaWYgKHJldCkKPiA+IC0JCXJldHVybiByZXQ7Cj4gPiAtCj4g PiAtCWRybSA9IHRkZXYtPmRybTsKPiA+ICAKPiA+ICAJY29ubmVjdG9yID0gZHJtX3NpbXBsZV9j b25uZWN0b3JfY3JlYXRlKGRybSwgRFJNX01PREVfQ09OTkVDVE9SX1ZJUlRVQUwsIG1vZGUsIDAp Owo+ID4gIAlpZiAoSVNfRVJSKGNvbm5lY3RvcikpCj4gPiAgCQlyZXR1cm4gUFRSX0VSUihjb25u ZWN0b3IpOwo+ID4gIAo+ID4gLQlyZXQgPSBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZV9pbml0KGRy bSwgJnRkZXYtPnBpcGUsICZyZXBhcGVyX3BpcGVfZnVuY3MsCj4gPiArCXJldCA9IGRybV9zaW1w bGVfZGlzcGxheV9waXBlX2luaXQoZHJtLCAmZXBkLT5waXBlLCAmcmVwYXBlcl9waXBlX2Z1bmNz LAo+ID4gIAkJCQkJICAgcmVwYXBlcl9mb3JtYXRzLCBBUlJBWV9TSVpFKHJlcGFwZXJfZm9ybWF0 cyksCj4gPiAgCQkJCQkgICBOVUxMLCBjb25uZWN0b3IpOwo+ID4gIAlpZiAocmV0KQo+ID4gIAkJ cmV0dXJuIHJldDsKPiBCdXQgbGF0ZXIgaW4gdGhlIHNhbWUgZnVuY3Rpb24gZXBkIGlzIG5vdCBm cmVlZC4KPiBMb29rcyBsaWtlIGEgbGVhaz8KPiBOb3RoaW5nIG5ldyBpZiB0aGlzIGlzIGNvcnJl Y3QgYnV0IGp1c3Qgc3BvdHRlZCBpdC4KClRoZSBwYXJ0IHdpdGggIm5vdGhpbmcgbmV3IiBJIHRh a2UgYmFjay4gVGhpcyBjb2RlIGNvbnZlcnRzCmRldm1fa3phbGxvYygpIHRvIHRoZSB1bm1hbmFn ZWQgdmFyaWFudC4KU28gdGhlIGxlYWsgaXMgbmV3IC0gYW5kIGFsc28gcHJlc2VudCBpbgpkcml2 ZXJzIGluIG5leHQgcGF0Y2ggKGlmIHRoZXJlIGlzIGEgbGVhaykuCgpXaHkgaXMgdGhlIGNvbnZl cnNpb24gdG8gYW4gdW5tYW5hZ2VkIHZhcmlhbnQgb2Yga3phbGxvYygpIHJlcXVpcmVkPwoKCVNh bQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK