From: Vinod Koul <vkoul@kernel.org>
To: David S Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Niklas Cassel <niklas.cassel@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vkoul@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH v3 5/5] net: dsa: qca8k: disable delay for RGMII mode
Date: Mon, 21 Jan 2019 14:43:18 +0530 [thread overview]
Message-ID: <20190121091318.20079-6-vkoul@kernel.org> (raw)
In-Reply-To: <20190121091318.20079-1-vkoul@kernel.org>
In RGMII mode we should not have any delay in port MAC, so disable
the delay.
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/net/dsa/qca8k.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 7e97e620bd44..a4b6cda38016 100644
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -420,7 +420,7 @@ qca8k_mib_init(struct qca8k_priv *priv)
static int
qca8k_set_pad_ctrl(struct qca8k_priv *priv, int port, int mode)
{
- u32 reg;
+ u32 reg, val;
switch (port) {
case 0:
@@ -439,17 +439,9 @@ qca8k_set_pad_ctrl(struct qca8k_priv *priv, int port, int mode)
*/
switch (mode) {
case PHY_INTERFACE_MODE_RGMII:
- qca8k_write(priv, reg,
- QCA8K_PORT_PAD_RGMII_EN |
- QCA8K_PORT_PAD_RGMII_TX_DELAY(3) |
- QCA8K_PORT_PAD_RGMII_RX_DELAY(3));
-
- /* According to the datasheet, RGMII delay is enabled through
- * PORT5_PAD_CTRL for all ports, rather than individual port
- * registers
- */
- qca8k_write(priv, QCA8K_REG_PORT5_PAD_CTRL,
- QCA8K_PORT_PAD_RGMII_RX_DELAY_EN);
+ /* RGMII mode means no delay so don't enable the delay */
+ val = QCA8K_PORT_PAD_RGMII_EN;
+ qca8k_write(priv, reg, val);
break;
case PHY_INTERFACE_MODE_SGMII:
qca8k_write(priv, reg, QCA8K_PORT_PAD_SGMII_EN);
--
2.20.1
next prev parent reply other threads:[~2019-01-21 9:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 9:13 [PATCH v3 0/5] net: Add support for Qualcomm ethqos Vinod Koul
2019-01-21 9:13 ` [PATCH v3 1/5] dt-bindings: net: Add Qualcomm ethqos binding Vinod Koul
2019-01-21 15:31 ` Rob Herring
2019-01-21 15:31 ` Rob Herring
2019-01-21 9:13 ` [PATCH v3 2/5] net: stmmac: Add driver for Qualcomm ethqos Vinod Koul
2019-01-21 9:13 ` [PATCH v3 3/5] MAINTAINER: Add entry for Qualcomm ETHQOS ethernet driver Vinod Koul
2019-01-21 9:13 ` [PATCH v3 4/5] net: phy: at803x: Disable phy delay for RGMII mode Vinod Koul
2019-02-12 10:55 ` [v3,4/5] " Peter Ujfalusi
2019-02-12 10:55 ` Peter Ujfalusi
2019-02-12 11:31 ` Vinod Koul
2019-02-12 12:09 ` Peter Ujfalusi
2019-02-12 12:09 ` Peter Ujfalusi
2019-02-12 12:17 ` Vinod Koul
2019-02-12 13:34 ` Marc Gonzalez
2019-01-21 9:13 ` Vinod Koul [this message]
2019-01-23 3:38 ` [PATCH v3 0/5] net: Add support for Qualcomm ethqos David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190121091318.20079-6-vkoul@kernel.org \
--to=vkoul@kernel.org \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.