From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 03/11] drm/simple-kms-helper: Add drm_simple_connector_create() Date: Mon, 21 Jan 2019 10:22:01 +0100 Message-ID: <20190121092201.GM3271@phenom.ffwll.local> References: <20190120114318.49199-1-noralf@tronnes.org> <20190120114318.49199-4-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB7996E756 for ; Mon, 21 Jan 2019 09:22:05 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id o10so15944508edt.13 for ; Mon, 21 Jan 2019 01:22:05 -0800 (PST) Content-Disposition: inline In-Reply-To: <20190120114318.49199-4-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: david@lechnology.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBKYW4gMjAsIDIwMTkgYXQgMTI6NDM6MTBQTSArMDEwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IFRoaXMgYWRkcyBhIGZ1bmN0aW9uIHRoYXQgY3JlYXRlcyBhIHNpbXBsZSBjb25u ZWN0b3IgdGhhdCBoYXMgb25seSBvbmUKPiBzdGF0aWMgbW9kZS4gQWRkaXRpb25hbGx5IGFkZCBh IGhlbHBlciB0byBzZXQgJmRybV9tb2RlX2NvbmZpZyB3aWR0aAo+IGFuZCBoZWlnaHQgZnJvbSB0 aGUgc3RhdGljIG1vZGUuCj4gCj4gU2lnbmVkLW9mZi1ieTogTm9yYWxmIFRyw7hubmVzIDxub3Jh bGZAdHJvbm5lcy5vcmc+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fc2ltcGxlX2ttc19o ZWxwZXIuYyB8IDEyMiArKysrKysrKysrKysrKysrKysrKysrKysKPiAgaW5jbHVkZS9kcm0vZHJt X3NpbXBsZV9rbXNfaGVscGVyLmggICAgIHwgICA2ICsrCj4gIDIgZmlsZXMgY2hhbmdlZCwgMTI4 IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9zaW1w bGVfa21zX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5j Cj4gaW5kZXggOTE3ODEyNDQ4ZDFiLi5jYTI5OTc1YWZlZmUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2RybV9zaW1wbGVfa21zX2hlbHBlci5jCj4gQEAgLTExLDYgKzExLDggQEAKPiAgI2luY2x1ZGUg PGRybS9kcm1fYXRvbWljLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJtX2F0b21pY19oZWxwZXIuaD4K PiAgI2luY2x1ZGUgPGRybS9kcm1fY3J0Y19oZWxwZXIuaD4KPiArI2luY2x1ZGUgPGRybS9kcm1f ZGV2aWNlLmg+Cj4gKyNpbmNsdWRlIDxkcm0vZHJtX21vZGVzLmg+Cj4gICNpbmNsdWRlIDxkcm0v ZHJtX3BsYW5lX2hlbHBlci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9zaW1wbGVfa21zX2hlbHBl ci5oPgo+ICAjaW5jbHVkZSA8bGludXgvc2xhYi5oPgo+IEBAIC0yOTksNCArMzAxLDEyNCBAQCBp bnQgZHJtX3NpbXBsZV9kaXNwbGF5X3BpcGVfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ ICB9Cj4gIEVYUE9SVF9TWU1CT0woZHJtX3NpbXBsZV9kaXNwbGF5X3BpcGVfaW5pdCk7Cj4gIAo+ ICtzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9jb25uZWN0b3JfaGVscGVyX2Z1bmNzIGRybV9zaW1w bGVfY29ubmVjdG9yX2hmdW5jcyA9IHsKPiArCS8qIGR1bW15IGZvciB0aGUgYXRvbWljIGhlbHBl ciAqLwo+ICt9Owo+ICsKPiArc3RhdGljIGludCBkcm1fc2ltcGxlX2Nvbm5lY3Rvcl9maWxsX21v ZGVzKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gKwkJCQkJICAgdWludDMyX3Qg bWF4WCwgdWludDMyX3QgbWF4WSkKPiArewo+ICsJcmV0dXJuIDE7Cj4gK30KPiArCj4gK3N0YXRp YyB2b2lkIGRybV9zaW1wbGVfY29ubmVjdG9yX2Rlc3Ryb3koc3RydWN0IGRybV9jb25uZWN0b3Ig KmNvbm5lY3RvcikKPiArewo+ICsJZHJtX2Nvbm5lY3Rvcl9jbGVhbnVwKGNvbm5lY3Rvcik7Cj4g KwlrZnJlZShjb25uZWN0b3IpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9j b25uZWN0b3JfZnVuY3MgZHJtX3NpbXBsZV9jb25uZWN0b3JfZnVuY3MgPSB7Cj4gKwkucmVzZXQg PSBkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0b3JfcmVzZXQsCj4gKwkuZmlsbF9tb2RlcyA9IGRy bV9zaW1wbGVfY29ubmVjdG9yX2ZpbGxfbW9kZXMsCj4gKwkuZGVzdHJveSA9IGRybV9zaW1wbGVf Y29ubmVjdG9yX2Rlc3Ryb3ksCj4gKwkuYXRvbWljX2R1cGxpY2F0ZV9zdGF0ZSA9IGRybV9hdG9t aWNfaGVscGVyX2Nvbm5lY3Rvcl9kdXBsaWNhdGVfc3RhdGUsCj4gKwkuYXRvbWljX2Rlc3Ryb3lf c3RhdGUgPSBkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0b3JfZGVzdHJveV9zdGF0ZSwKPiArfTsK PiArCj4gKy8qKgo+ICsgKiBkcm1fc2ltcGxlX2Nvbm5lY3Rvcl9jcmVhdGUgLSBDcmVhdGUgYSBj b25uZWN0b3Igd2l0aCBvbmUgc3RhdGljIG1vZGUKPiArICogQGRldjogRFJNIGRldmljZQo+ICsg KiBAY29ubmVjdG9yX3R5cGU6IENvbm5lY3RvciB0eXBlCj4gKyAqIEBtb2RlOiBTdXBwb3J0ZWQg ZGlzcGxheSBtb2RlCj4gKyAqIEByb3RhdGlvbjogSW5pdGlhbCBAbW9kZSByb3RhdGlvbiBpbiBk ZWdyZWVzCgpXZSBoYXZlIHJvdGF0aW9uIHByb3BlcnRpZXMgZm9yIHRoaXMsIHBscyBkb24ndCB1 c2UgZGVncmVzcyBoZXJlLgoKQWxzbyB3b3VsZCBiZSBnb29kIHRvIHdpcmUgdGhpcyB1cCB3aXRo IHRoZSByb3RhdGlvbiBwcm9wZXJ0eSBIYW5zIGFkZGVkCnJlY2VudGx5LCBmb3IgcHJlLXJvdGF0 ZWQgc2NyZWVucyAoc2VlIHRoZSBrZXJuZWxkb2MgZm9yICJwYW5lbApvcmllbnRhdGlvbiIgYW5k IGRybV9jb25uZWN0b3JfaW5pdF9wYW5lbF9vcmllbnRhdGlvbl9wcm9wZXJ0eSgpKS4gU28gdGhh dAp1c2Vyc3BhY2Uga25vd3MgaG93IHRvIHJvdGF0ZSBpdHMgcmVuZGVyaW5nIHRvIG1ha2UgZXZl cnl0aGluZyBsb29rCmNvcnJlY3QgaW4gdGhlIGVuZCBhZ2Fpbi4KCgo+ICsgKgo+ICsgKiBUaGlz IGZ1bmN0aW9uIGNyZWF0ZXMgYSAmZHJtX2Nvbm5lY3RvciB0aGF0IGhhcyBvbmUgZml4ZWQgJmRy bV9kaXNwbGF5X21vZGUKPiArICogd2hpY2ggd2lsbCBiZSByb3RhdGVkIGFjY29yZGluZyB0byBA cm90YXRpb24uCgpGcm9tIGEgZnVuY3Rpb25hbGl0eSBwb3YgdGhpcyBpcyB2ZXJ5IGNsb3NlIHRv IGEgcGFuZWwgd3JhcHBlZCBpbnRvIGEKYnJpZGdlLiBJIHRoaW5rIGl0IHdvdWxkIGJlIGdvb2Qg dG8gZGlmZmVyZW50aWF0ZSBhIGJpdCBiZXR3ZWVuIHRoZXNlIHR3bwpjYXNlcyBtb3JlLiBBZnRl ciBhbGwgdGhlcmUgd2FzIGEgcmVhbGx5IGxvbmcgZGlzY3Vzc2lvbiBhYm91dCBob3cgdGhlCnBh bmVsIHN0dWZmIGRvZXMgb3IgZG9lcyBub3QgZXhhY3RseSBmaXQgZm9yIHRpbnlkcm0sIHdvdWxk IGJlIGdvb2QgdG8Kc3VtbWFyaXplIHRoaXMgaGVyZSBhbmQgYXQgbGVhc3QgcG9pbnQgYXQgZHJt X3BhbmVsX2JyaWRnZV9hZGQoKS4KCkFsc28gd291bGQgYmUgZ29vZCB0byBleHBsYWluIGluIHRo ZSBvdmVydmlldyBET0MgY29tbWVudCB0aGF0IHRoaXMgaXMgYQpmdWxseSBpbmRlcGVuZGVudCBw YXJ0IG9mIHRoZSBzaW1wbGUgaGVscGVycywgYW5kIGRyaXZlcnMgY2FuIHVzZSBvbmUgb3IKdGhl IG90aGVyLgotRGFuaWVsCgo+ICsgKgo+ICsgKiBSZXR1cm5zOgo+ICsgKiBQb2ludGVyIHRvIGNv bm5lY3RvciBvbiBzdWNjZXNzLCBvciBFUlJfUFRSIG9uIGZhaWx1cmUuCj4gKyAqLwo+ICtzdHJ1 Y3QgZHJtX2Nvbm5lY3RvciAqCj4gK2RybV9zaW1wbGVfY29ubmVjdG9yX2NyZWF0ZShzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LCBpbnQgY29ubmVjdG9yX3R5cGUsCj4gKwkJCSAgICBjb25zdCBzdHJ1 Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSwKPiArCQkJICAgIHVuc2lnbmVkIGludCByb3RhdGlv bikKPiArewo+ICsJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGVfZHVwID0gTlVMTDsKPiAr CXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3I7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCWNv bm5lY3RvciA9IGt6YWxsb2Moc2l6ZW9mKCpjb25uZWN0b3IpLCBHRlBfS0VSTkVMKTsKPiArCWlm ICghY29ubmVjdG9yKQo+ICsJCXJldHVybiBFUlJfUFRSKC1FTk9NRU0pOwo+ICsKPiArCWRybV9j b25uZWN0b3JfaGVscGVyX2FkZChjb25uZWN0b3IsICZkcm1fc2ltcGxlX2Nvbm5lY3Rvcl9oZnVu Y3MpOwo+ICsJcmV0ID0gZHJtX2Nvbm5lY3Rvcl9pbml0KGRldiwgY29ubmVjdG9yLCAmZHJtX3Np bXBsZV9jb25uZWN0b3JfZnVuY3MsCj4gKwkJCQkgY29ubmVjdG9yX3R5cGUpOwo+ICsJaWYgKHJl dCkKPiArCQlnb3RvIGVycl9mcmVlOwo+ICsKPiArCWNvbm5lY3Rvci0+c3RhdHVzID0gY29ubmVj dG9yX3N0YXR1c19jb25uZWN0ZWQ7Cj4gKwo+ICsJbW9kZV9kdXAgPSBkcm1fbW9kZV9kdXBsaWNh dGUoZGV2LCBtb2RlKTsKPiArCWlmICghbW9kZV9kdXApIHsKPiArCQlyZXQgPSAtRU5PTUVNOwo+ ICsJCWdvdG8gZXJyX2NsZWFudXA7Cj4gKwl9Cj4gKwo+ICsJaWYgKHJvdGF0aW9uID09IDkwIHx8 IHJvdGF0aW9uID09IDI3MCkgewo+ICsJCXN3YXAobW9kZV9kdXAtPmhkaXNwbGF5LCBtb2RlX2R1 cC0+dmRpc3BsYXkpOwo+ICsJCXN3YXAobW9kZV9kdXAtPmhzeW5jX3N0YXJ0LCBtb2RlX2R1cC0+ dnN5bmNfc3RhcnQpOwo+ICsJCXN3YXAobW9kZV9kdXAtPmhzeW5jX2VuZCwgbW9kZV9kdXAtPnZz eW5jX2VuZCk7Cj4gKwkJc3dhcChtb2RlX2R1cC0+aHRvdGFsLCBtb2RlX2R1cC0+dnRvdGFsKTsK PiArCQlzd2FwKG1vZGVfZHVwLT53aWR0aF9tbSwgbW9kZV9kdXAtPmhlaWdodF9tbSk7Cj4gKwl9 IGVsc2UgaWYgKHJvdGF0aW9uICE9IDAgJiYgcm90YXRpb24gIT0gMTgwKSB7Cj4gKwkJRFJNX0VS Uk9SKCJJbGxlZ2FsIHJvdGF0aW9uIHZhbHVlICV1XG4iLCByb3RhdGlvbik7Cj4gKwkJcmV0ID0g LUVJTlZBTDsKPiArCQlnb3RvIGVycl9jbGVhbnVwOwo+ICsJfQo+ICsKPiArCW1vZGVfZHVwLT50 eXBlIHw9IERSTV9NT0RFX1RZUEVfUFJFRkVSUkVEOwo+ICsJaWYgKG1vZGVfZHVwLT5uYW1lWzBd ID09ICdcMCcpCj4gKwkJZHJtX21vZGVfc2V0X25hbWUobW9kZV9kdXApOwo+ICsKPiArCWxpc3Rf YWRkKCZtb2RlX2R1cC0+aGVhZCwgJmNvbm5lY3Rvci0+bW9kZXMpOwo+ICsKPiArCWNvbm5lY3Rv ci0+ZGlzcGxheV9pbmZvLndpZHRoX21tID0gbW9kZV9kdXAtPndpZHRoX21tOwo+ICsJY29ubmVj dG9yLT5kaXNwbGF5X2luZm8uaGVpZ2h0X21tID0gbW9kZV9kdXAtPmhlaWdodF9tbTsKPiArCj4g KwlyZXR1cm4gY29ubmVjdG9yOwo+ICsKPiArZXJyX2NsZWFudXA6Cj4gKwlkcm1fY29ubmVjdG9y X2NsZWFudXAoY29ubmVjdG9yKTsKPiArCWRybV9tb2RlX2Rlc3Ryb3koZGV2LCBtb2RlX2R1cCk7 Cj4gK2Vycl9mcmVlOgo+ICsJa2ZyZWUoY29ubmVjdG9yKTsKPiArCj4gKwlyZXR1cm4gRVJSX1BU UihyZXQpOwo+ICt9Cj4gK0VYUE9SVF9TWU1CT0woZHJtX3NpbXBsZV9jb25uZWN0b3JfY3JlYXRl KTsKPiArCj4gKy8qKgo+ICsgKiBkcm1fc2ltcGxlX2Nvbm5lY3Rvcl9zZXRfbW9kZV9jb25maWcg LSBTZXQgJmRybV9tb2RlX2NvbmZpZyB3aWR0aCBhbmQgaGVpZ2h0Cj4gKyAqIEBjb25uZWN0b3I6 IENvbm5lY3Rvcgo+ICsgKgo+ICsgKiBUaGlzIGZ1bmN0aW9uIHNldHMgdGhlICZkcm1fbW9kZV9j b25maWcgbWluL21heCB3aWR0aCBhbmQgaGVpZ2h0IGJhc2VkIG9uIHRoZQo+ICsgKiBjb25uZWN0 b3IgZml4ZWQgZGlzcGxheSBtb2RlLgo+ICsgKi8KPiArdm9pZCBkcm1fc2ltcGxlX2Nvbm5lY3Rv cl9zZXRfbW9kZV9jb25maWcoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiArewo+ ICsJc3RydWN0IGRybV9tb2RlX2NvbmZpZyAqbW9kZV9jb25maWcgPSAmY29ubmVjdG9yLT5kZXYt Pm1vZGVfY29uZmlnOwo+ICsJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGU7Cj4gKwo+ICsJ bW9kZSA9IGxpc3RfZmlyc3RfZW50cnkoJmNvbm5lY3Rvci0+bW9kZXMsIHN0cnVjdCBkcm1fZGlz cGxheV9tb2RlLCBoZWFkKTsKPiArCWlmIChXQVJOX09OKCFtb2RlKSkKPiArCQlyZXR1cm47Cj4g Kwo+ICsJbW9kZV9jb25maWctPm1pbl93aWR0aCA9IG1vZGUtPmhkaXNwbGF5Owo+ICsJbW9kZV9j b25maWctPm1heF93aWR0aCA9IG1vZGUtPmhkaXNwbGF5Owo+ICsJbW9kZV9jb25maWctPm1pbl9o ZWlnaHQgPSBtb2RlLT52ZGlzcGxheTsKPiArCW1vZGVfY29uZmlnLT5tYXhfaGVpZ2h0ID0gbW9k ZS0+dmRpc3BsYXk7Cj4gK30KPiArRVhQT1JUX1NZTUJPTChkcm1fc2ltcGxlX2Nvbm5lY3Rvcl9z ZXRfbW9kZV9jb25maWcpOwo+ICsKPiAgTU9EVUxFX0xJQ0VOU0UoIkdQTCIpOwo+IGRpZmYgLS1n aXQgYS9pbmNsdWRlL2RybS9kcm1fc2ltcGxlX2ttc19oZWxwZXIuaCBiL2luY2x1ZGUvZHJtL2Ry bV9zaW1wbGVfa21zX2hlbHBlci5oCj4gaW5kZXggNDUxOTYwNDM4YTI5Li5hYjNkODQ3Yjc3MTMg MTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX3NpbXBsZV9rbXNfaGVscGVyLmgKPiArKysg Yi9pbmNsdWRlL2RybS9kcm1fc2ltcGxlX2ttc19oZWxwZXIuaAo+IEBAIC0xODIsNCArMTgyLDEw IEBAIGludCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZV9pbml0KHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsCj4gIAkJCWNvbnN0IHVpbnQ2NF90ICpmb3JtYXRfbW9kaWZpZXJzLAo+ICAJCQlzdHJ1Y3Qg ZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKTsKPiAgCj4gK3N0cnVjdCBkcm1fY29ubmVjdG9yICoK PiArZHJtX3NpbXBsZV9jb25uZWN0b3JfY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGlu dCBjb25uZWN0b3JfdHlwZSwKPiArCQkJICAgIGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2Rl ICptb2RlLAo+ICsJCQkgICAgdW5zaWduZWQgaW50IHJvdGF0aW9uKTsKPiArdm9pZCBkcm1fc2lt cGxlX2Nvbm5lY3Rvcl9zZXRfbW9kZV9jb25maWcoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5l Y3Rvcik7Cj4gKwo+ICAjZW5kaWYgLyogX19MSU5VWF9EUk1fU0lNUExFX0tNU19IRUxQRVJfSCAq Lwo+IC0tIAo+IDIuMjAuMQo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIElu dGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=